From patchwork Mon Nov 20 14:41:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 16805 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp2252665vqn; Mon, 20 Nov 2023 06:49:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IEAFyhY+RMc9y8vaEXvilJAzt9Vs8Nx69+/1t5q4/ytPQS3ZeREYe7pPNlzyu69W/AMREsl X-Received: by 2002:a17:90b:38d1:b0:280:2c16:2186 with SMTP id nn17-20020a17090b38d100b002802c162186mr5698652pjb.30.1700491762692; Mon, 20 Nov 2023 06:49:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700491762; cv=none; d=google.com; s=arc-20160816; b=WVHPN8N5YmYnepte9kDH0zxGX9JvJqKNiLw7wHdMQjlmXclX7LZsx7HpkqcYSK4xHY VMZCL925k0Brbe9glRBu85He+LuZIwzgEIV9KjDB4vig2yozGb6xazXW3avjtOpjYNfc 0lPDdUoCFi2RGjvNE8itCFzWXArkVYYO8ACtlLn8tJQaACB9QJAL/6XQ8ekDFv8ipcwr Hlw49OaqOmRr49A2XZj2SlyR2oAjT/LhKR80pfsOujx1/VBeovbd526V7x1GHsf2N6L8 1vh78GjYslm0uEA5XvQe+udLSnLPutDodQun11/HWR6qdtF/+yRinadrrPOMjRQjtJbT WG7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=dg945HurbaDmAjFJGCgBjl/x7wp4qtE2cKk6CjnwAdI=; fh=g3amdiifXhwL/mTWljo4oOX/iLvH3RCBC8SWsJqOWek=; b=u81OS8elEgTXV7kTl3q7NYPs7MddXAK3DsLM9moVF5XCtNerEyhhZjoWKdUR01FGH2 MB++5oYqasRieSXy7WURmmpHd3n4TEhgWseEuME0sb+5j6wRF3bkP32v2oHXrOw1Ql/X veSQCXVmGEwryHpdBJFS325wc0pVy5kbNXOQuYIjyyyzBUINY+L85abhjL7bU1CqA9fP tnrmrXmjOtMvuW/FhQHX2Z8rapY7JHxCKc6DGvcr4VLvtrDfDoEWw9OdB81QIhkeW8k/ 1AoQxaIjXF4e1mtclUkCRTyvEoozZxRHQHZpjJouwRhGn8fuAK7Cgg5lTrZVlKR82AhT enXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FePmihkh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id me18-20020a17090b17d200b002773f96df0esi8650880pjb.3.2023.11.20.06.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 06:49:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FePmihkh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EDAA180A49BD; Mon, 20 Nov 2023 06:49:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233576AbjKTOq4 (ORCPT + 27 others); Mon, 20 Nov 2023 09:46:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232135AbjKTOqx (ORCPT ); Mon, 20 Nov 2023 09:46:53 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0675CA; Mon, 20 Nov 2023 06:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700491609; x=1732027609; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1WcAH3qnIrokblei/Ut5XpiAyV1OZfCsJMBPI5VHzoQ=; b=FePmihkhWLlwuVJHepgjMGQSyy9Ymb5Tx1Cu0wLUfJwPq57+n8aOUnC4 OcVYuG0LkDDeam3jRFS+FGbzkxq0iVvX3mRGB2ICS/+4HsweDXVeU4cJu Gx4no+bQ3ItK+joHszPI/jZvCsD9DlTvM9E5KpSs7Mn2HhctAXlp9YN6v qE0c57iX1RKnwi8/BN+4mshUnuNYn+/tKTHWPfV+rhKg00tP++atLygAE Anzk1O6xsDQVlYieQBKDubb26Uq8+NgIVdzeCh4MJ7ZInlQg9I2AYdMdi d9iEMxsYdLl3x1GsLn+G+qIPJ8pcmJBFC28DvVOgnOpp22dPAdz2E5EQo g==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="455956435" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="455956435" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 06:46:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="801193126" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="801193126" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 20 Nov 2023 06:46:45 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 20E086B; Mon, 20 Nov 2023 16:46:43 +0200 (EET) From: Andy Shevchenko To: Mario Limonciello , Jarkko Nikula , Herbert Xu , Andy Shevchenko , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Andi Shyti , Philipp Zabel Subject: [PATCH v4 00/24] i2c: designware: code consolidation & cleanups Date: Mon, 20 Nov 2023 16:41:42 +0200 Message-ID: <20231120144641.1660574-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 06:49:08 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783094850499154805 X-GMAIL-MSGID: 1783094850499154805 The series now consists the following groups of patches: - fixing cleanup order in error path and remove (patches 1-4) - refactoring i2c_dw_*_lock_support() (patches 5-6) - refactoring module alias and device ID tables (patches 7-10) - unifying firmware parsing and configuring code (patches 11-15) - miscellaneous cleanups (patches 16-17,21-24) - consolidating PM ops (patch 18) - using device_set_node() for all drivers (patches 19-20) The "Consolidate PM ops" might be considered as rft, however I don't think we have any hardware where the behaviour will be changed, anyways, good to test. Changelog v4: - dropped first patch as controversial (Jarkko) - dropped Fixes tag from a few patches (Jarkko) - moved a hunk in patch 1 to patch 2 where it belongs (Jarkko) - exported i2c_dw_disable() for modular building (Jarkko) - added tags (Mario, Jarkko) v3: https://lore.kernel.org/r/20231110182304.3894319-1-andriy.shevchenko@linux.intel.com Changelog v3: - doubled the size of the series - fixed compilation error (LKP) - added tags (Andi) v2: https://lore.kernel.org/r/20231109182823.3531846-1-andriy.shevchenko@linux.intel.com Changelog v2: - reworked the series to make it less twisted (Jarkko, Andi) - added tags to the patches that have been rebased (Andi, Mario, Jarkko) - introduced a few new changes (PM ops, export namespace) v1: https://lore.kernel.org/r/20230725143023.86325-1-andriy.shevchenko@linux.intel.com Andy Shevchenko (24): i2c: designware: Fix PM calls order in dw_i2c_plat_probe() i2c: designware: Fix reset call order in dw_i2c_plat_probe() i2c: designware: Let PCI core to take care about interrupt vectors i2c: designware: Fix lock probe call order in dw_i2c_plat_probe() i2c: designware: Replace a while-loop by for-loop i2c: designware: Save pointer to semaphore callbacks instead of index i2c: designware: Add missing 'c' into PCI IDs variable name i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() i2c: designware: Unify terminator in device ID tables i2c: designware: Always provide device ID tables i2c: designware: Drop return value from i2c_dw_acpi_configure() i2c: designware: Drop return value from dw_i2c_of_configure() i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure() i2c: designware: Consolidate firmware parsing and configuring code i2c: designware: Unify the firmware type checks i2c: designware: Move exports to I2C_DW namespaces i2c: designware: Remove ->disable() callback i2c: designware: Consolidate PM ops i2c: designware: Uninline i2c_dw_probe() i2c: designware: Propagate firmware node i2c: designware: Use pci_get_drvdata() i2c: designware: Use temporary variable for struct device i2c: designware: Get rid of redundant 'else' i2c: designware: Fix spelling and other issues in the comments drivers/i2c/busses/i2c-designware-amdpsp.c | 10 +- drivers/i2c/busses/i2c-designware-common.c | 167 +++++++++- drivers/i2c/busses/i2c-designware-core.h | 47 +-- drivers/i2c/busses/i2c-designware-master.c | 19 +- drivers/i2c/busses/i2c-designware-pcidrv.c | 114 ++----- drivers/i2c/busses/i2c-designware-platdrv.c | 337 +++++++------------- drivers/i2c/busses/i2c-designware-slave.c | 12 +- 7 files changed, 337 insertions(+), 369 deletions(-) Acked-by: Jarkko Nikula Tested-by: Serge Semin