mbox series

[v2,0/2] drm/rockchip: lvds: improve erroring out when drm_of_find_panel_or_bridge fails

Message ID 20231120-rk-lvds-defer-msg-v2-0-9c59a5779cf9@theobroma-systems.com
Headers
Series drm/rockchip: lvds: improve erroring out when drm_of_find_panel_or_bridge fails |

Message

Quentin Schulz Nov. 20, 2023, 12:29 p.m. UTC 
  drm_of_find_panel_or_bridge may return a different error code than
EPROBE_DEFER so let's not overwrite it.

At the same time, let's demote the DRM_DEV_ERROR message to
dev_err_probe so that the scary message isn't shown (by default)
whenever EPROBE_DEFER is returned to not mislead users.

Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
Changes in v2:
- add a patch for not overwriting return code with EPROBE_DEFER
- use dev_err_probe instead of DRM_DEV_DEBUG
- Link to v1: https://lore.kernel.org/r/20231117-rk-lvds-defer-msg-v1-1-1e6894cf9a74@theobroma-systems.com

---
Quentin Schulz (2):
      drm/rockchip: lvds: do not overwrite error code
      drm/rockchip: lvds: do not print scary message when probing defer

 drivers/gpu/drm/rockchip/rockchip_lvds.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
---
base-commit: 98b1cc82c4affc16f5598d4fa14b1858671b2263
change-id: 20231117-rk-lvds-defer-msg-b2944b73d791

Best regards,

Comments

Heiko Stübner Jan. 4, 2024, 10:57 a.m. UTC | #1 
On Mon, 20 Nov 2023 13:29:47 +0100, Quentin Schulz wrote:
> drm_of_find_panel_or_bridge may return a different error code than
> EPROBE_DEFER so let's not overwrite it.
> 
> At the same time, let's demote the DRM_DEV_ERROR message to
> dev_err_probe so that the scary message isn't shown (by default)
> whenever EPROBE_DEFER is returned to not mislead users.
> 
> [...]

Applied, thanks!

[1/2] drm/rockchip: lvds: do not overwrite error code
      commit: 79b09453c4e369ca81cfb670d0136d089e3b92f0
[2/2] drm/rockchip: lvds: do not print scary message when probing defer
      commit: 52d11c863ac92e36a0365249f7f6d27ac48c78bc

Best regards,