From patchwork Fri Nov 17 01:15:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luke Jones X-Patchwork-Id: 16675 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp228677vqn; Thu, 16 Nov 2023 17:17:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEKUbRDRAjldKPVJmRYSxJAWCYV2a5AtwZ7K3i0UnhOVSlauKbyvWcRqIpIIqVXgF99d2DD X-Received: by 2002:a05:6a00:1593:b0:6be:2649:8c6b with SMTP id u19-20020a056a00159300b006be26498c6bmr19339481pfk.32.1700183860013; Thu, 16 Nov 2023 17:17:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700183859; cv=none; d=google.com; s=arc-20160816; b=DiCYUQPUuuUE36DAXwNXrHgldB6phdHdL5++W4Zn+OOF+PeUl42K3jCk8KtNcOQ+QB wnYq6m6YrwHqqtQEb+51dYF6R2WbxTmiRUmWezQzDnxedlIkBuu+vN7E963fcEPYXRu0 M2hygh14hgkg1uFMAomi4n8TVHeiFBNZitXgMzgpV4uT8y5GMc+/+fXp7ii1bO/bbZEr keKI07SehIRMRGP8P3SNe8CAt+Gs8lkzwZTVxCIABCq1rgrndSdXGn24FBtecTSw2ygp NjtyWwSQsTpmbz4HWkYvq9CgfbxWU+zeCOCURzGJYP2JPKwyaiKvTVvHKTMxgLsuIgOl eMoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:feedback-id:dkim-signature :dkim-signature; bh=argAW/l5NVCwSSKLt8lTVPDhHTjwmM5Ir7e3W5JDo04=; fh=JMzzSxVRPA/ydaJ3Dt0QS2ws9NywLb5x5SvfzqU5z7c=; b=Adap3QimKRONfb+IshBny91MVX/fo5zQ6Uvdza6S+JQUoUAXHAZpiR8eqr9QU0kMfX f4B8IjbqrbwGyDIAx9aSp0rD/aFSuMehvdHWGHQo0yeh9G2oSKwCV5vKu4RfTnRs2KF/ ajhIZVR+UOgHcQs74pW0f/Z8KEdN1HU3oGaNmn67m0cPX5vwc9MR/mZOl/hzU/ajuBrS wFW0DeNXuRjR2Iu0vUEKLxFpHYXOzyUGhfbvRJkooMRE2T6Od/vgr2hXOYeuwr3tBN2Y YA9NnDKCf/ELi75D9ubaWRsqg4KBrY60/pi7C8+JBah4emlug6z8uqFjN6fFQ1bCzMYf C1Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ljones.dev header.s=fm2 header.b=GrsbGzEA; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=chjU55KX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id p25-20020a056a000a1900b00690258a9777si825865pfh.20.2023.11.16.17.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 17:17:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@ljones.dev header.s=fm2 header.b=GrsbGzEA; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=chjU55KX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E23D3806A43D; Thu, 16 Nov 2023 17:16:42 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230018AbjKQBQb (ORCPT + 30 others); Thu, 16 Nov 2023 20:16:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjKQBQa (ORCPT ); Thu, 16 Nov 2023 20:16:30 -0500 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7A161A8; Thu, 16 Nov 2023 17:16:20 -0800 (PST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A190F5C0120; Thu, 16 Nov 2023 20:16:17 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 16 Nov 2023 20:16:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1700183777; x=1700270177; bh=argAW/l5NV CwSSKLt8lTVPDhHTjwmM5Ir7e3W5JDo04=; b=GrsbGzEAgT5nR3pCk/pWwpLW1y hFG+ioTZfTPgWpISlI8ZhXvrJ59/SLK0nyGkaoaW5C1GdnGcqSHhozkrlfKhfEPZ dsaVbVo2LLYLBk4z+klgw0LuWo5zYQ9fN+8lvOxjfFl/ACLIdh8XYiP3UKemJI/8 ea63iAAmkW9tO14csBr8VziaoPWXWeKg/t12U2KCn+yGafIQG4FaNeApOn8zwjKL c8/DHHfKtmDcMBkqHpKoYpq8Etqw1dx3Ve6U5tdmhn10OlZBtxVxOWHDWjKZcD5N sOZ4VZHAu1W75O9Mhm14wnoWq1Akje7r8CkPNkbaSoolB93WBe8W1uaUhOXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1700183777; x=1700270177; bh=argAW/l5NVCwS SKLt8lTVPDhHTjwmM5Ir7e3W5JDo04=; b=chjU55KXXMe+tP6cnVAjAwNIAgXdH ELY9t1lNShJvSzO2YyyM7mCO9fcIGeMFoPZIM4P5G9yfTZP9sHUxSE+/wCQvCdKL T+V26SMiSGqtiMJFN59XdLchEgnZAt/1cOqpwXzk+Ui9pmO8rZjacTYI5wilCG6n w3lbtSJjOIL0K+VJKuanVgjYuSTkoHV2znG7Iqfqfb1yhoZbyaYZVRorX0/6K2Ak DCEiqGHL+J5IS326sSmTuqFTJpzkAAXmHeRHDncfY9p7VpWxB1I7KmIoHSfTwET+ siaZ0fI/I5gX3TKQUgLpQRfpUy/D7hvKJFKLgvlThuo25ca3I1I4DZSfQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudefledgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehljhho nhgvshdruggvvheqnecuggftrfgrthhtvghrnhepgfdujedthfduudekffefkeeiffdttd dvhfegudduueffuefhfefggeefteevvdegnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Nov 2023 20:16:14 -0500 (EST) From: "Luke D. Jones" To: jikos@kernel.org Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, benato.denis96@gmail.com Subject: [PATCH 0/2] hid-asus: reset the backlight brightness level on resume Date: Fri, 17 Nov 2023 14:15:54 +1300 Message-ID: <20231117011556.13067-1-luke@ljones.dev> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 16 Nov 2023 17:16:42 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782771992156321770 X-GMAIL-MSGID: 1782771991292352664 From: Denis Benato I have noticed that in my Asus device RC71L the keyboard backlight is LEDs brightness of two RGB rings around two joysticks of this handheld device. The firmware on this device (and other devices from the same manufacturer) restores a default brightness level (that is full brightness for my device and off for some others) after resuming from sleep; that means sysfs will report a wrong brightness level and requires human intervention to restore the desired brightness. I have fixed aforementioned problems with this patch I am submitting. This patch (composed of two distinct patches) compiles without warnings on both gcc and clang and also improves a function signature and constant-correctness of the kernel driver. Denis Benato (2): hid-asus: add const to read-only outgoing usb buffer hid-asus: reset the backlight brightness level on resume drivers/hid/hid-asus.c | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) Signed-off-by: Luke D. Jones