mbox series

[0/2] hid-asus: reset the backlight brightness level on resume

Message ID 20231117011556.13067-1-luke@ljones.dev
Headers
Series hid-asus: reset the backlight brightness level on resume |

Message

Luke Jones Nov. 17, 2023, 1:15 a.m. UTC 
  From: Denis Benato <benato.denis96@gmail.com>

I have noticed that in my Asus device RC71L the keyboard backlight is LEDs brightness of two RGB rings around two joysticks of this handheld device.

The firmware on this device (and other devices from the same manufacturer) restores a default brightness level (that is full brightness for my device and off for some others) after resuming from sleep; that means sysfs will report a wrong brightness level and requires human intervention to restore the desired brightness.

I have fixed aforementioned problems with this patch I am submitting.

This patch (composed of two distinct patches) compiles without warnings on both gcc and clang and also improves a function signature and constant-correctness of the kernel driver.

Denis Benato (2):
  hid-asus: add const to read-only outgoing usb buffer
  hid-asus: reset the backlight brightness level on resume

 drivers/hid/hid-asus.c | 27 +++++++++++++++++++++++----
 1 file changed, 23 insertions(+), 4 deletions(-)

Comments

Denis Benato Nov. 17, 2023, 7:51 p.m. UTC | #1 
> From: Denis Benato <benato.denis96@gmail.com>

I want to express my gratitude toward Luke for his guidance and his help in submitting this fix.

I confirm those patches were sent in my behalf.
Jiri Kosina Nov. 21, 2023, 8:52 a.m. UTC | #2 
On Fri, 17 Nov 2023, Denis Benato wrote:

> > From: Denis Benato <benato.denis96@gmail.com>
> 
> I want to express my gratitude toward Luke for his guidance and his help 
> in submitting this fix.
> 
> I confirm those patches were sent in my behalf.

Luke, as you were in the supply chain of the patches, could you please 
provide Signed-off-by: tags so that I can add them into the chain?

Thanks,
Luke Jones Nov. 21, 2023, 7:35 p.m. UTC | #3 
On Tue, Nov 21 2023 at 09:52:11 AM +01:00:00, Jiri Kosina 
<jikos@kernel.org> wrote:
> On Fri, 17 Nov 2023, Denis Benato wrote:
> 
>>  > From: Denis Benato <benato.denis96@gmail.com>
>> 
>>  I want to express my gratitude toward Luke for his guidance and his 
>> help
>>  in submitting this fix.
>> 
>>  I confirm those patches were sent in my behalf.
> 
> Luke, as you were in the supply chain of the patches, could you please
> provide Signed-off-by: tags so that I can add them into the chain?

Signed-off-by: Luke D. Jones <luke@ljones.dev>
Jiri Kosina Nov. 22, 2023, 10:25 a.m. UTC | #4 
On Wed, 22 Nov 2023, Luke Jones wrote:

> >> I want to express my gratitude toward Luke for his guidance and his help
> >>  in submitting this fix.
> >> 
> >>  I confirm those patches were sent in my behalf.
> > 
> > Luke, as you were in the supply chain of the patches, could you please
> > provide Signed-off-by: tags so that I can add them into the chain?
> 
> Signed-off-by: Luke D. Jones <luke@ljones.dev>

Applied, thanks.