Message ID | 20231117-axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp787696vqn; Fri, 17 Nov 2023 12:15:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFTYsfqMm0HFV0N/++WJHzZwDwcj2td6+gyAH7DvFjlyeXO0uclvaI2PUm3tsnvsz57Q1I X-Received: by 2002:a05:6a00:4c95:b0:6c3:38f5:99d2 with SMTP id eb21-20020a056a004c9500b006c338f599d2mr718940pfb.11.1700252099735; Fri, 17 Nov 2023 12:14:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700252099; cv=none; d=google.com; s=arc-20160816; b=KO1+JhIYXC/gOoyy0VIFvKKVZVrMwK7lVm7kgQNYBHynl1K7mPMQWNm7H13a+FNXQi 808Hc0RC0noBZhyBillVG8U5+tXDQFqljblbYNUYDetURllNRFmdHQYX6W2LuOrI/p6n S1nCqc8byFdD0EkAeRUiquaFlws1cSm8mDs7NlmtgZ1w//gXzqAXWPcxh/40e07Cpu0z i2qnz87fG8VCB9JJmkQdMuhubmi6Grig3WoCXNCW/tZJm3PGnt46ysXQfiR9pHkDkb4V aq1B895Lph2caBW+PcrQoXuz7G0aELjSzXtJzy0baw6r6lZTuiUKbIA7cvXnKa+1Mp5H F+xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=rhumf+S/1zmUfncIex+xhepA+T9wIMv2vyztW6+G6BA=; fh=iMzJmnbboC4LJtlxOKimqPq82YSRfb3zCJyFaxC9c3g=; b=aXWa8RCrTJqG0G2MZ6wkrRfYdOQySakDXjEclMUQ1Rw02dszgTnaiM8AQmZcxGV0jo QK2piVOYcJ6VKj+q5RmgwvaOcNX9TWEk8XeHUhpwWqr4CVl/RsWNj53OUa74jRE2oyOg PUnVvP6J2ozHn/LRBxKzaFj2RpLpVeyl8Gx0f7dnVTTJ1VgcZfHLh29HJO4YjMopuUWl I7Ti6L0kJ9iodDGbSf/si2wYukrAaQ6TY9CFlSVolTUlHnQpJ8LnwJHX78VrpNs+DoZA cTWH8RR+qjmZvPjwqVtcuyNfYRWQLECOZF0Gggtjejprh7+Mc8AToih4XqKuhvY2tK8W rbPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=lsqWx7hm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id h20-20020a056a00219400b006bddac4b018si2672237pfi.107.2023.11.17.12.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 12:14:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=lsqWx7hm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id F238C825024E; Fri, 17 Nov 2023 12:14:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232067AbjKQUN6 (ORCPT <rfc822;jaysivo@gmail.com> + 29 others); Fri, 17 Nov 2023 15:13:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231533AbjKQUN4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 17 Nov 2023 15:13:56 -0500 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA817D6C for <linux-kernel@vger.kernel.org>; Fri, 17 Nov 2023 12:13:51 -0800 (PST) Received: by mail-oi1-x22f.google.com with SMTP id 5614622812f47-3b3f6dd612cso1431542b6e.3 for <linux-kernel@vger.kernel.org>; Fri, 17 Nov 2023 12:13:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1700252031; x=1700856831; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rhumf+S/1zmUfncIex+xhepA+T9wIMv2vyztW6+G6BA=; b=lsqWx7hmnb2o+hQ6cvbPdIkA/XMtr4wg7c8GrbwyNDrm/DgKj/o//s90fnhi++6Jxj znF1XWc+e7ooIFcybvXIkUObb7zB5oPDOx5Zc8c0fcGXKL5spQ+FSqt3Ily4wVyE3gh2 0toW1bZPjSsHFkvfA1mEU+DOAvbUX1jvJUDUhp17PsPFv+VxCuYehVTusVJejhljbbLg xouR8VXVlRcsMOH+odeR6T/gwPjHnXVDKdfwhn3MGIf+fDMjxTgApoo2iwwbNHADb9SE wf26BdcW/VcqvbIU/g8j1HLvYh5oqbq7cRQDtZCJGO1jqtBijQ4WyEnp1lG4p97d7yXP 7Kvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700252031; x=1700856831; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rhumf+S/1zmUfncIex+xhepA+T9wIMv2vyztW6+G6BA=; b=tHwSwmAgFGlW9qrwuEW78TbjTyN6gAaBRSStsJ28j+GW/yW2lgwUN3Jxsb83ss+CiM H+J0wJE4qHN0C2mYWyxA1fL803sXQuIYajShi89Ag9Xjn3wfK4thPmk1cYzp7DsHaw4z Cis8AXoX0HQZxfAZR0eOX6gc/8wpErTsxxXrtwlsmOyyZATHpgGIi4eqjYytsjVYVsxA SWsn8xW8umhS0Hk9RVvsrWvXMUFMjRKVHeGOZRAWnRlaxXAJQX5Ay5DVLuuCrGaU9nux GrhNpVNwgPfliqn+WFNOm/optTzWbrY3NqKY/FA/vrmnpjmL/EVq4d1uS4YC6wJdTyQY rQow== X-Gm-Message-State: AOJu0YxhOXdO+Tjgb7SXtFy4HwFka4ud690QHVooBj9oMGRK8JtPVoCQ K4NWHrrH40ASSKpb2lkWUFk9/w== X-Received: by 2002:a05:6808:19a2:b0:3ab:870d:2d49 with SMTP id bj34-20020a05680819a200b003ab870d2d49mr584414oib.8.1700252031144; Fri, 17 Nov 2023 12:13:51 -0800 (PST) Received: from freyr.lechnology.com (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id l21-20020a544515000000b003a8560a9d34sm393814oil.25.2023.11.17.12.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 12:13:50 -0800 (PST) From: David Lechner <dlechner@baylibre.com> To: linux-spi@vger.kernel.org, devicetree@vger.kernel.org Cc: David Lechner <dlechner@baylibre.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Michael Hennerich <Michael.Hennerich@analog.com>, =?utf-8?q?Nuno_S=C3=A1?= <nuno.sa@analog.com>, Lars-Peter Clausen <lars@metafoo.de>, linux-kernel@vger.kernel.org Subject: [PATCH 00/14] spi: axi-spi-engine improvements Date: Fri, 17 Nov 2023 14:12:51 -0600 Message-ID: <20231117-axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.12.4 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 17 Nov 2023 12:14:33 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782843545836457245 X-GMAIL-MSGID: 1782843545836457245 |
Series |
spi: axi-spi-engine improvements
|
|
Message
David Lechner
Nov. 17, 2023, 8:12 p.m. UTC
We are working towards adding support for the offload feature[1] of the AXI SPI Engine IP core. Before we can do that, we want to make some general fixes and improvements to the driver. In order to avoid a giant series with 35+ patches, we are splitting this up into a few smaller series. This first series mostly doing some housekeeping: * Convert device tree bindings to yaml. * Add a MAINTAINERS entry. * Clean up probe and remove using devm. * Separate message state from driver state. * Add support for cs_off and variable word size. Once this series is applied, we will follow up with a second series of general improvements, and then finally a 3rd series that implements the offload support. The offload support will also involve the IIO subsystem (a new IIO driver will depend on the new SPI offload feature), so I'm mentioning this now in case we want to do anything ahead of time to prepare for that (e.g. putting all of these changes on a separate branch). [1]: https://wiki.analog.com/resources/fpga/peripherals/spi_engine/offload --- David Lechner (14): dt-bindings: spi: axi-spi-engine: convert to yaml MAINTAINERS: add entry for AXI SPI Engine spi: axi-spi-engine: simplify driver data allocation spi: axi-spi-engine: use devm_spi_alloc_host() spi: axi-spi-engine: use devm action to reset hw on remove spi: axi-spi-engine: use devm_request_irq() spi: axi-spi-engine: use devm_spi_register_controller() spi: axi-spi-engine: check for valid clock rate spi: axi-spi-engine: move msg state to new struct spi: axi-spi-engine: use message_prepare/unprepare spi: axi-spi-engine: remove completed_id from driver state spi: axi-spi-engine: remove struct spi_engine::msg spi: axi-spi-engine: add support for cs_off spi: axi-spi-engine: add support for any word size .../devicetree/bindings/spi/adi,axi-spi-engine.txt | 31 -- .../bindings/spi/adi,axi-spi-engine.yaml | 66 ++++ MAINTAINERS | 10 + drivers/spi/spi-axi-spi-engine.c | 399 +++++++++++++-------- 4 files changed, 329 insertions(+), 177 deletions(-) --- base-commit: 6f9da18171889fae105e1413a825c53fa5aab40c change-id: 20231117-axi-spi-engine-series-1-7c76311440f9
Comments
On Fri, 17 Nov 2023 14:12:51 -0600, David Lechner wrote: > We are working towards adding support for the offload feature[1] of the > AXI SPI Engine IP core. Before we can do that, we want to make some > general fixes and improvements to the driver. In order to avoid a giant > series with 35+ patches, we are splitting this up into a few smaller > series. > > This first series mostly doing some housekeeping: > * Convert device tree bindings to yaml. > * Add a MAINTAINERS entry. > * Clean up probe and remove using devm. > * Separate message state from driver state. > * Add support for cs_off and variable word size. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [01/14] dt-bindings: spi: axi-spi-engine: convert to yaml commit: 252eafe11ffc032579a56c7a29faa8431785a91e [02/14] MAINTAINERS: add entry for AXI SPI Engine commit: 68539d1803476b4ecd403c126aa74b9f25b45f2b [03/14] spi: axi-spi-engine: simplify driver data allocation commit: 9e4ce5220eedea2cc440f3961dec1b5122e815b2 [04/14] spi: axi-spi-engine: use devm_spi_alloc_host() commit: e12cd96e8e93044646fdf4b2c9a1de62cfa01e7c [05/14] spi: axi-spi-engine: use devm action to reset hw on remove commit: e094de13ae78035c5642d5dfc65b07301765eebc [06/14] spi: axi-spi-engine: use devm_request_irq() commit: 076f32d5db73f16c95b38149f9168210cf267b33 [07/14] spi: axi-spi-engine: use devm_spi_register_controller() commit: e16e71e3f3c4b73b20f8c79f7ce8465542a337e9 [08/14] spi: axi-spi-engine: check for valid clock rate commit: e6d5eb85e84aeace5e231b951ece86b20df9f63a [09/14] spi: axi-spi-engine: move msg state to new struct commit: 7f970ecb77b6759d37ee743fc36fc0daba960e75 [10/14] spi: axi-spi-engine: use message_prepare/unprepare commit: 0c74de5c6853b0e83413ad237867a37ba30ef3f9 [11/14] spi: axi-spi-engine: remove completed_id from driver state commit: 4a074ddeb90f5e81738b401643651b2dea257f57 [12/14] spi: axi-spi-engine: remove struct spi_engine::msg commit: 4e991445478c6404a6846928093837249c52694a [13/14] spi: axi-spi-engine: add support for cs_off commit: 145bb2aedb9f78f290c2b5503b553894a6ec53fe [14/14] spi: axi-spi-engine: add support for any word size commit: d861b417e1893a46c63cef2cb46d3587da1e5b15 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark