mbox series

[0/5] afs: Miscellaneous small fixes

Message ID 20231116155312.156593-1-dhowells@redhat.com
Headers
Series afs: Miscellaneous small fixes |

Message

David Howells Nov. 16, 2023, 3:53 p.m. UTC 
  Hi Marc,

Here are a set of miscellaneous small fixes to the afs filesystem
including:

 (1) Fix the afs_server_list struct to be cleaned up with RCU.

 (2) Fix afs to translate a no-data result from a DNS lookup into ENOENT,
     not EDESTADDRREQ for consistency with OpenAFS.

 (3) Fix afs to translate a negative DNS lookup result into ENOENT rather
     than EDESTADDRREQ.

 (4) Fix file locking on R/O volumes to operate in local mode as the server
     doesn't handle exclusive locks on such files.

 (5) Not a fix per se, but set SB_RDONLY on superblocks for RO and Backup
     volumes so that the VFS can see that they're read only.

The patches can be found here:

	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-fixes

Thanks,
David

David Howells (5):
  afs: Fix afs_server_list to be cleaned up with RCU
  afs: Make error on cell lookup failure consistent with OpenAFS
  afs: Return ENOENT if no cell DNS record can be found
  afs: Fix file locking on R/O volumes to operate in local mode
  afs: Mark a superblock for an R/O or Backup volume as SB_RDONLY

 fs/afs/dynroot.c     |  4 ++--
 fs/afs/internal.h    |  1 +
 fs/afs/server_list.c |  2 +-
 fs/afs/super.c       |  4 ++++
 fs/afs/vl_rotate.c   | 10 ++++++++++
 5 files changed, 18 insertions(+), 3 deletions(-)

Comments

Jeffrey E Altman Nov. 22, 2023, 6:58 p.m. UTC | #1 
On 11/16/2023 10:53 AM, David Howells wrote:
> Hi Marc,
>
> Here are a set of miscellaneous small fixes to the afs filesystem
> including:
>
>   (1) Fix the afs_server_list struct to be cleaned up with RCU.
>
>   (2) Fix afs to translate a no-data result from a DNS lookup into ENOENT,
>       not EDESTADDRREQ for consistency with OpenAFS.
>
>   (3) Fix afs to translate a negative DNS lookup result into ENOENT rather
>       than EDESTADDRREQ.
>
>   (4) Fix file locking on R/O volumes to operate in local mode as the server
>       doesn't handle exclusive locks on such files.
>
>   (5) Not a fix per se, but set SB_RDONLY on superblocks for RO and Backup
>       volumes so that the VFS can see that they're read only.
>
> The patches can be found here:
>
> 	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-fixes
>
> Thanks,
> David
>
> David Howells (5):
>    afs: Fix afs_server_list to be cleaned up with RCU
>    afs: Make error on cell lookup failure consistent with OpenAFS
>    afs: Return ENOENT if no cell DNS record can be found
>    afs: Fix file locking on R/O volumes to operate in local mode
>    afs: Mark a superblock for an R/O or Backup volume as SB_RDONLY
>
>   fs/afs/dynroot.c     |  4 ++--
>   fs/afs/internal.h    |  1 +
>   fs/afs/server_list.c |  2 +-
>   fs/afs/super.c       |  4 ++++
>   fs/afs/vl_rotate.c   | 10 ++++++++++
>   5 files changed, 18 insertions(+), 3 deletions(-)

Reviewed-by: Jeffrey Altman <jaltman@auristor.com>