Message ID | 20231116-mbly-uart-v2-0-863f665ce520@bootlin.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp3118101vqg; Thu, 16 Nov 2023 02:32:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IH3qql62DFVv9wYzU/kwT1fWwSkAiDYT8iDUeDNRPG1rVrSN6TTQ0jsyhHqKW5MKmBzpPou X-Received: by 2002:a05:6808:4448:b0:3b2:ee69:800b with SMTP id ep8-20020a056808444800b003b2ee69800bmr20087363oib.55.1700130726000; Thu, 16 Nov 2023 02:32:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700130725; cv=none; d=google.com; s=arc-20160816; b=SyggME29IP7A6z3Kw4+NKniwWrNS+9SOvlDEQP29zNTlDUri5SirqvVaWxsl7eQ+Rz YNwOxq7jw6texgTfICYhbzJlzJxRK/AAGUHPk7upLIskQKEYI+tqobu+70KqOoFBrV68 fR88Uq1Q6U/MYXaLZ2xHoXywPNy3V3NzucRDAjJ50288zOA464I/cF/rpm0OcVSiZ3Ql 1uV/ueAG5SGum4JieLtS7JhWGkojh7z5mT9gl9MU0O+rc4nVQtS4JQHGpSIlk8VJXjTO 46TtHaotnbqVOgj4n9tUbA4A+WQ3DCh1GuDXo+jSo9NDWB4mfv2PUyM3DY03y/tGuhmc aleg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=ixpklLWwSkk4I/yPqqbqBcWEcsYH1dKNM9IZkWS8e0M=; fh=QQT0ysDV3C9K/ZwUoBeqi9VulQuaknzQuTSh/MRCItc=; b=V5Clm86ezu78A3G28F8XudOE48cyw4C4v3P5IX4/pKeIxxk3b+nhBivKamiUlZWPzq gjxg0md/20PdKuTpBq/9eydx/slwvIN3v+lCEkCo0aYhjHbgITGLUkap5p8VI8mW454p 8ZDCB6X79frrfuHPupTVHIUemtiyuiiRkKmI0V7JZMkm/4W3isqKEK08zkWQtWn6LrnY 3ZhW7aj5NXzW82OyAmIIRAcYbUVn+brRLHxTe9kN5LlYWjaPxVGwUyjaAo/XtLjRdMTs pIDeaOVcEI/bCeKrAGshNFmds0jrk5YxTesHBJl85+8vJs4x/sH7CAdh86MFkRNGPfh9 VWOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=RcvKFHwK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id bi11-20020a056a02024b00b005b97024487csi13171702pgb.315.2023.11.16.02.32.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 02:32:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=RcvKFHwK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 4502480253A2; Thu, 16 Nov 2023 02:31:53 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344985AbjKPKbf (ORCPT <rfc822;jaysivo@gmail.com> + 29 others); Thu, 16 Nov 2023 05:31:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbjKPKb3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 16 Nov 2023 05:31:29 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 026B8B7; Thu, 16 Nov 2023 02:31:23 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id BAB8660005; Thu, 16 Nov 2023 10:31:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1700130682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ixpklLWwSkk4I/yPqqbqBcWEcsYH1dKNM9IZkWS8e0M=; b=RcvKFHwK/5hxl0ISDxClwPnpyCAZE4zebORmbm+2jMfjVR3am4J9EkJeDaShPuIkHjvlwZ nilZweL4mJSiCtu1rxkqfCBkK6RMFovVGBVw2wo/5OuBvZI6uaNvTHLSZqfgk1mtH6EdgL Px+Fs0uCgJTeTKIoUXTjF8UUC4j2V4DMKO+4I5PIEqRo+qYCjv+sV/WNTMXBFKm0a9RqZx x7KA7sMJJipPIf8N0CJVVenw5YcqXtlTtNnTJWoXoYfYgl0rkHlxDGufWPEDpCJ73sfupu YAzflqr8WqL5QwrgoWi/F0EKhVP6QUDdvPSyUPX41A8/dkbD4h9r98eq1aKSZA== From: =?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com> Subject: [PATCH v2 0/5] Cleanup AMBA PL011 driver Date: Thu, 16 Nov 2023 11:31:03 +0100 Message-Id: <20231116-mbly-uart-v2-0-863f665ce520@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAGfvVWUC/03MQQrDIBCF4auEWdeSGNpqV71HyULN2AwkWtRKQ /DutYFCF7P4h8e3QcRAGOHabBAwUyTvavBDA2ZS7oGMxtrAW9539dii55W9VEhMWaOM1lJYoaH unwEtvXfrPtSeKCYf1p3O3ff7U85/Su5YyyQ/CUTF5WXsb9r7NJM7Gr/AUEr5ACNBik2kAAAA To: Russell King <linux@armlinux.org.uk>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, =?utf-8?q?Gr=C3=A9gory_Clement?= <gregory.clement@bootlin.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>, Tawfik Bayouk <tawfik.bayouk@mobileye.com>, =?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com> X-Mailer: b4 0.12.3 X-GND-Sasl: theo.lebrun@bootlin.com X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 16 Nov 2023 02:31:53 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782716276234140760 X-GMAIL-MSGID: 1782716276234140760 |
Series |
Cleanup AMBA PL011 driver
|
|
Message
Théo Lebrun
Nov. 16, 2023, 10:31 a.m. UTC
Hi,
While adding upstream support to a new platform (Mobileye EyeQ5[1]) that
uses the AMBA PL011 driver, I took some time to look at the PL011
driver and ended up with a few patches that cleanup parts of it. The
line-diff is big mostly because of the checkpatch-fixing commits.
The driver hadn't received any love for quite some time. A single commit
changes the code's behavior: see "tty: serial: amba-pl011: Parse bits
option as 5, 6, 7 or 8 in _get_options". See commit messages for more
information.
Compared to v1, we drop one [PATCH 6/6] & we fix some nits.
[1]: https://lore.kernel.org/all/202310050726.GDpZbMDO-lkp@intel.com/T/
Have a nice day,
Théo Lebrun
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
---
Changes in v2:
- [PATCH 2]: add #include <linux/bits.h> in include/linux/amba/serial.h
as we use the BIT() macro.
- Move one whitespace cleanup from [PATCH 4/6] to [PATCH v2 3/5] where
it belongs.
- Drop [PATCH 6/6]: console will never have a word length of 5 or 6.
- Link to v1: https://lore.kernel.org/r/20231026-mbly-uart-v1-0-9258eea297d3@bootlin.com
---
Théo Lebrun (5):
tty: serial: amba: cleanup whitespace
tty: serial: amba: Use BIT() macro for constant declarations
tty: serial: amba-pl011: cleanup driver
tty: serial: amba-pl011: replace TIOCMBIT macros by static functions
tty: serial: amba-pl011: unindent pl011_console_get_options function body
drivers/tty/serial/amba-pl011.c | 241 ++++++++++++++++++++--------------------
include/linux/amba/serial.h | 193 ++++++++++++++++----------------
2 files changed, 218 insertions(+), 216 deletions(-)
---
base-commit: 82251bf0515a7c32121b0e833922708d4dd70da9
change-id: 20231023-mbly-uart-afcacbb98f8b
Best regards,