[RESEND,v2,0/4] genirq/irq_sim: misc updates

  From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Here are a couple of updates to the interrupt simulator. Two are minor:
remove an unused field and reorder includes for readability. The third
one simplifies the error paths by using new cleanup macros. To that end
we also add a cleanup definition for dynamic bitmaps.

Resending rebased on top of v6.7-rc1 and with tags collected.

v1 -> v2:
- add a NULL-pointer check to the bitmap cleanup macro as advised by
  Peter Zijlstra
- initialize managed pointers when declaring them to create a clear pairing
  between the type and the cleanup action

Bartosz Golaszewski (4):
  bitmap: define a cleanup function for bitmaps
  genirq/irq_sim: remove unused field from struct irq_sim_irq_ctx
  genirq/irq_sim: order headers alphabetically
  genirq/irq_sim: shrink code by using cleanup helpers

 include/linux/bitmap.h |  3 +++
 kernel/irq/irq_sim.c   | 30 ++++++++++++------------------
 2 files changed, 15 insertions(+), 18 deletions(-)
  

On Wed, Nov 15, 2023 at 5:59 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Here are a couple of updates to the interrupt simulator. Two are minor:
> remove an unused field and reorder includes for readability. The third
> one simplifies the error paths by using new cleanup macros. To that end
> we also add a cleanup definition for dynamic bitmaps.
>
> Resending rebased on top of v6.7-rc1 and with tags collected.
>
> v1 -> v2:
> - add a NULL-pointer check to the bitmap cleanup macro as advised by
>   Peter Zijlstra
> - initialize managed pointers when declaring them to create a clear pairing
>   between the type and the cleanup action
>
> Bartosz Golaszewski (4):
>   bitmap: define a cleanup function for bitmaps
>   genirq/irq_sim: remove unused field from struct irq_sim_irq_ctx
>   genirq/irq_sim: order headers alphabetically
>   genirq/irq_sim: shrink code by using cleanup helpers
>
>  include/linux/bitmap.h |  3 +++
>  kernel/irq/irq_sim.c   | 30 ++++++++++++------------------
>  2 files changed, 15 insertions(+), 18 deletions(-)
>
> --
> 2.40.1
>

It's been two weeks since this submission and ~2.5 months since the
first one so I guess, a gentle ping is in order. This is not a very
controversial series - can this be applied?

Bart
  

On Wed, Nov 29, 2023 at 10:18:15AM +0100, Bartosz Golaszewski wrote:
> On Wed, Nov 15, 2023 at 5:59 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Here are a couple of updates to the interrupt simulator. Two are minor:
> > remove an unused field and reorder includes for readability. The third
> > one simplifies the error paths by using new cleanup macros. To that end
> > we also add a cleanup definition for dynamic bitmaps.
> >
> > Resending rebased on top of v6.7-rc1 and with tags collected.
> >
> > v1 -> v2:
> > - add a NULL-pointer check to the bitmap cleanup macro as advised by
> >   Peter Zijlstra
> > - initialize managed pointers when declaring them to create a clear pairing
> >   between the type and the cleanup action
> >
> > Bartosz Golaszewski (4):
> >   bitmap: define a cleanup function for bitmaps
> >   genirq/irq_sim: remove unused field from struct irq_sim_irq_ctx
> >   genirq/irq_sim: order headers alphabetically
> >   genirq/irq_sim: shrink code by using cleanup helpers
> >
> >  include/linux/bitmap.h |  3 +++
> >  kernel/irq/irq_sim.c   | 30 ++++++++++++------------------
> >  2 files changed, 15 insertions(+), 18 deletions(-)
> >
> > --
> > 2.40.1
> >
> 
> It's been two weeks since this submission and ~2.5 months since the
> first one so I guess, a gentle ping is in order. This is not a very
> controversial series - can this be applied?

Hi Bartosz,

I'm the first in the list for this series, but really only 1st patch
is related to bitmaps, and I already acked it. If you prefer that, I
can pull it in the bitmap tree.

Thanks,
Yury
  

On Wed, Nov 29, 2023 at 8:59 PM Yury Norov <yury.norov@gmail.com> wrote:
>
> On Wed, Nov 29, 2023 at 10:18:15AM +0100, Bartosz Golaszewski wrote:
> > On Wed, Nov 15, 2023 at 5:59 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > Here are a couple of updates to the interrupt simulator. Two are minor:
> > > remove an unused field and reorder includes for readability. The third
> > > one simplifies the error paths by using new cleanup macros. To that end
> > > we also add a cleanup definition for dynamic bitmaps.
> > >
> > > Resending rebased on top of v6.7-rc1 and with tags collected.
> > >
> > > v1 -> v2:
> > > - add a NULL-pointer check to the bitmap cleanup macro as advised by
> > >   Peter Zijlstra
> > > - initialize managed pointers when declaring them to create a clear pairing
> > >   between the type and the cleanup action
> > >
> > > Bartosz Golaszewski (4):
> > >   bitmap: define a cleanup function for bitmaps
> > >   genirq/irq_sim: remove unused field from struct irq_sim_irq_ctx
> > >   genirq/irq_sim: order headers alphabetically
> > >   genirq/irq_sim: shrink code by using cleanup helpers
> > >
> > >  include/linux/bitmap.h |  3 +++
> > >  kernel/irq/irq_sim.c   | 30 ++++++++++++------------------
> > >  2 files changed, 15 insertions(+), 18 deletions(-)
> > >
> > > --
> > > 2.40.1
> > >
> >
> > It's been two weeks since this submission and ~2.5 months since the
> > first one so I guess, a gentle ping is in order. This is not a very
> > controversial series - can this be applied?
>
> Hi Bartosz,
>
> I'm the first in the list for this series, but really only 1st patch
> is related to bitmaps, and I already acked it. If you prefer that, I
> can pull it in the bitmap tree.
>
> Thanks,
> Yury

If there's a risk it will conflict then you can apply it and provide
Thomas with an immutable branch against the irq tree, otherwise I
think Thomas can pick up all the patches.

Bartosz
  

On Wed, Nov 29, 2023 at 10:18 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> On Wed, Nov 15, 2023 at 5:59 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Here are a couple of updates to the interrupt simulator. Two are minor:
> > remove an unused field and reorder includes for readability. The third
> > one simplifies the error paths by using new cleanup macros. To that end
> > we also add a cleanup definition for dynamic bitmaps.
> >
> > Resending rebased on top of v6.7-rc1 and with tags collected.
> >
> > v1 -> v2:
> > - add a NULL-pointer check to the bitmap cleanup macro as advised by
> >   Peter Zijlstra
> > - initialize managed pointers when declaring them to create a clear pairing
> >   between the type and the cleanup action
> >
> > Bartosz Golaszewski (4):
> >   bitmap: define a cleanup function for bitmaps
> >   genirq/irq_sim: remove unused field from struct irq_sim_irq_ctx
> >   genirq/irq_sim: order headers alphabetically
> >   genirq/irq_sim: shrink code by using cleanup helpers
> >
> >  include/linux/bitmap.h |  3 +++
> >  kernel/irq/irq_sim.c   | 30 ++++++++++++------------------
> >  2 files changed, 15 insertions(+), 18 deletions(-)
> >
> > --
> > 2.40.1
> >
>
> It's been two weeks since this submission and ~2.5 months since the
> first one so I guess, a gentle ping is in order. This is not a very
> controversial series - can this be applied?
>
> Bart

Another ping...

Bartosz
  

On Mon, Dec 4, 2023 at 9:47 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> On Wed, Nov 29, 2023 at 10:18 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > On Wed, Nov 15, 2023 at 5:59 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > Here are a couple of updates to the interrupt simulator. Two are minor:
> > > remove an unused field and reorder includes for readability. The third
> > > one simplifies the error paths by using new cleanup macros. To that end
> > > we also add a cleanup definition for dynamic bitmaps.
> > >
> > > Resending rebased on top of v6.7-rc1 and with tags collected.
> > >
> > > v1 -> v2:
> > > - add a NULL-pointer check to the bitmap cleanup macro as advised by
> > >   Peter Zijlstra
> > > - initialize managed pointers when declaring them to create a clear pairing
> > >   between the type and the cleanup action
> > >
> > > Bartosz Golaszewski (4):
> > >   bitmap: define a cleanup function for bitmaps
> > >   genirq/irq_sim: remove unused field from struct irq_sim_irq_ctx
> > >   genirq/irq_sim: order headers alphabetically
> > >   genirq/irq_sim: shrink code by using cleanup helpers
> > >
> > >  include/linux/bitmap.h |  3 +++
> > >  kernel/irq/irq_sim.c   | 30 ++++++++++++------------------
> > >  2 files changed, 15 insertions(+), 18 deletions(-)
> > >
> > > --
> > > 2.40.1
> > >
> >
> > It's been two weeks since this submission and ~2.5 months since the
> > first one so I guess, a gentle ping is in order. This is not a very
> > controversial series - can this be applied?
> >
> > Bart
>
> Another ping...
>
> Bartosz

Thomas,

Is there any formal reason why this cannot be processed?

Bartosz
  

On Mon, Dec 11, 2023 at 10:14 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> On Mon, Dec 4, 2023 at 9:47 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > On Wed, Nov 29, 2023 at 10:18 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > On Wed, Nov 15, 2023 at 5:59 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > >
> > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > >
> > > > Here are a couple of updates to the interrupt simulator. Two are minor:
> > > > remove an unused field and reorder includes for readability. The third
> > > > one simplifies the error paths by using new cleanup macros. To that end
> > > > we also add a cleanup definition for dynamic bitmaps.
> > > >
> > > > Resending rebased on top of v6.7-rc1 and with tags collected.
> > > >
> > > > v1 -> v2:
> > > > - add a NULL-pointer check to the bitmap cleanup macro as advised by
> > > >   Peter Zijlstra
> > > > - initialize managed pointers when declaring them to create a clear pairing
> > > >   between the type and the cleanup action
> > > >
> > > > Bartosz Golaszewski (4):
> > > >   bitmap: define a cleanup function for bitmaps
> > > >   genirq/irq_sim: remove unused field from struct irq_sim_irq_ctx
> > > >   genirq/irq_sim: order headers alphabetically
> > > >   genirq/irq_sim: shrink code by using cleanup helpers
> > > >
> > > >  include/linux/bitmap.h |  3 +++
> > > >  kernel/irq/irq_sim.c   | 30 ++++++++++++------------------
> > > >  2 files changed, 15 insertions(+), 18 deletions(-)
> > > >
> > > > --
> > > > 2.40.1
> > > >
> > >
> > > It's been two weeks since this submission and ~2.5 months since the
> > > first one so I guess, a gentle ping is in order. This is not a very
> > > controversial series - can this be applied?
> > >
> > > Bart
> >
> > Another ping...
> >
> > Bartosz
>
> Thomas,
>
> Is there any formal reason why this cannot be processed?
>
> Bartosz

Ping.

Bartosz
  

On Tue, Dec 19, 2023 at 09:17:38PM +0100, Bartosz Golaszewski wrote:
> On Mon, Dec 11, 2023 at 10:14 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > On Mon, Dec 4, 2023 at 9:47 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > On Wed, Nov 29, 2023 at 10:18 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > > On Wed, Nov 15, 2023 at 5:59 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

...

> > > > It's been two weeks since this submission and ~2.5 months since the
> > > > first one so I guess, a gentle ping is in order. This is not a very
> > > > controversial series - can this be applied?
> > >
> > > Another ping...
> >
> > Is there any formal reason why this cannot be processed?
>
> Ping.

Instead you can now just say that you are going to apply this via your tree,
if there won't be objections, e.g., within a week (or two as it's a holiday
season).

In the PR to Linus you can explain why it's taken like this.