mbox series

[0/4] dmaengine: fsl-edma: fix eDMAv4 uart dma loop test failure

Message ID 20231114154824.3617255-1-Frank.Li@nxp.com
Headers
Series dmaengine: fsl-edma: fix eDMAv4 uart dma loop test failure |

Message

Frank Li Nov. 14, 2023, 3:48 p.m. UTC 
  The commit a725990557e7d ("arm64: dts: imx93: Fix the dmas entries order")
trigger a hidden eDMAv4 hardware limitation.

Some channel require stick to odd number, some require stick to even
number.

This fixes include 3 part.
1. add limitation at eDMA driver.
2. create dt-binding header file to share define between driver and dts
3. add ODD and EVEN requirement for uart driver at dts file.

Frank Li (4):
  dmaengine: fsl-edma: fix eDMAv4 channel allocation issue
  dt-bindings: dma: fsl-edma: Add fsl-edma.h to prevent hardcoding in
    dts
  dmaengine: fsl-edma: utilize common dt-binding header file
  arm64: dts: imx93: Fix EDMA transfer failure

 arch/arm64/boot/dts/freescale/imx93.dtsi | 13 +++++++++----
 drivers/dma/fsl-edma-main.c              | 17 ++++++++++-------
 include/dt-bindings/dma/fsl-edma.h       | 21 +++++++++++++++++++++
 3 files changed, 40 insertions(+), 11 deletions(-)
 create mode 100644 include/dt-bindings/dma/fsl-edma.h

Comments

Frank Li Dec. 15, 2023, 5:04 a.m. UTC | #1 
On Tue, Nov 14, 2023 at 10:48:20AM -0500, Frank Li wrote:
> The commit a725990557e7d ("arm64: dts: imx93: Fix the dmas entries order")
> trigger a hidden eDMAv4 hardware limitation.
> 
> Some channel require stick to odd number, some require stick to even
> number.
> 
> This fixes include 3 part.
> 1. add limitation at eDMA driver.
> 2. create dt-binding header file to share define between driver and dts
> 3. add ODD and EVEN requirement for uart driver at dts file.

@vkoul:
	Did you have chance to check this patch?

Frank	

> 
> Frank Li (4):
>   dmaengine: fsl-edma: fix eDMAv4 channel allocation issue
>   dt-bindings: dma: fsl-edma: Add fsl-edma.h to prevent hardcoding in
>     dts
>   dmaengine: fsl-edma: utilize common dt-binding header file
>   arm64: dts: imx93: Fix EDMA transfer failure
> 
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 13 +++++++++----
>  drivers/dma/fsl-edma-main.c              | 17 ++++++++++-------
>  include/dt-bindings/dma/fsl-edma.h       | 21 +++++++++++++++++++++
>  3 files changed, 40 insertions(+), 11 deletions(-)
>  create mode 100644 include/dt-bindings/dma/fsl-edma.h
> 
> -- 
> 2.34.1
>
Vinod Koul Dec. 21, 2023, 4:30 p.m. UTC | #2 
On Tue, 14 Nov 2023 10:48:20 -0500, Frank Li wrote:
> The commit a725990557e7d ("arm64: dts: imx93: Fix the dmas entries order")
> trigger a hidden eDMAv4 hardware limitation.
> 
> Some channel require stick to odd number, some require stick to even
> number.
> 
> This fixes include 3 part.
> 1. add limitation at eDMA driver.
> 2. create dt-binding header file to share define between driver and dts
> 3. add ODD and EVEN requirement for uart driver at dts file.
> 
> [...]

Applied, thanks!

[1/4] dmaengine: fsl-edma: fix eDMAv4 channel allocation issue
      commit: dc51b4442dd94ab12c146c1897bbdb40e16d5636
[2/4] dt-bindings: dma: fsl-edma: Add fsl-edma.h to prevent hardcoding in dts
      commit: 1e9b05258271b76ccc04a4b535009d2cb596506a
[3/4] dmaengine: fsl-edma: utilize common dt-binding header file
      commit: d0e217b72f9f5c5ef35e3423d393ea8093ce98ec

Best regards,