From patchwork Tue Nov 14 14:33:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 16568 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp1909611vqg; Tue, 14 Nov 2023 06:46:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwTnGcMVaEveKpTcpiSvSI6/6T93za8yR5fp33d+YFuMkLh0rX51Oea5di8nGgXDPUVRB4 X-Received: by 2002:a17:903:249:b0:1bd:c7e2:462 with SMTP id j9-20020a170903024900b001bdc7e20462mr2494788plh.11.1699973193781; Tue, 14 Nov 2023 06:46:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699973192; cv=none; d=google.com; s=arc-20160816; b=qmX/eTkWPboTokiS40Zc4Z1JrHF+Xcn6Y9w3x1MnjcTaCzmlA8vPaMPIh5vAbkBs9X Gf0GrODGT7Khm3+5x5VCiN5p8EMjz2h4/drek1N3rIi0vR7csU+CJnAOJmaPPkerdB0i PYXcuy2Ggq6wKGCWS5UWi8S+dp6V1YGPeRlq9SUoUujMMwM5UPPrs0jz0DlK0lryKk2b b3it2084veKPMrY7zi6Bt9sNdM6/3rDOCosfNFRGH60Zhpmn0B5EvzQaSVANwa6koMBv bEiXxDO57DB5mucbrW0HzGBlw5hP6+yDLYVzd7j4Od8u8BXE+cVk0Ro/EN5bkxJ/TaQW O2cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4g88eCA6EwIYiZ04rjdxHvZ1ArZdMv7Uj4NCvc/VZ2E=; fh=srb/EijQIrMEdOeqn3qQX6qrsAGyqHAqeSFkl/qDdLM=; b=QgQ5KdkTwaXPfrslCXwgBHQrRdGZbznhiGA5iN2lSS2LqFtNKIIwo6ofQdb/XgNboe o7SXuuVwwMOTk2NiL0DWx4n/v6NWdUd/87UJctJ3ktSj9nyVekaD4XGziqaRScdf+WsP VcaDyQUmQYIfUYyOXJaLqMQY4x3kjZhc3FXlq1so2MLDaXf76TYSNtXq2xcf+/WXFNPT wKE8cVNfhGjxYklXOxpPjGS/p7HvL9lI2UFtxbT1EFe1QZD4KUsIrMykQT/tTRntHJUe 1wxqFJFBsJT9X1YKjgh+3PAfvtTulCM+OzR90axx9/tHN+edaZ9m07B11pXSrGzIlcDA /BZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rVQqLCH9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id l10-20020a170903244a00b001c5f80bf574si8357118pls.487.2023.11.14.06.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 06:46:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rVQqLCH9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 84B98803248E; Tue, 14 Nov 2023 06:46:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233320AbjKNOqD (ORCPT + 29 others); Tue, 14 Nov 2023 09:46:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231214AbjKNOqC (ORCPT ); Tue, 14 Nov 2023 09:46:02 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EDD710D for ; Tue, 14 Nov 2023 06:45:59 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C316C433C7; Tue, 14 Nov 2023 14:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699973158; bh=z1pm6buW7ZPrKt2TauADLrqPVq3fh/nOdfjF6mt+BNM=; h=From:To:Cc:Subject:Date:From; b=rVQqLCH9RYYQG1ODw4+cBHyWhY++NX4ltchJARQctk6OlmOtkOd3az2gsGOYxRSYP Up51X/vof2D1AhJHxsWYCgF8n6iIWYtHiVGw+VqA3mysv3bx0uoIaldLBsFCMPAgMA 8Mn0GyRbJ4d6gdy8HQX8FayG+ERzSyuFtbfOOdokZnCFdM76cq3zTulshU8i285m2z 2nn99hFfJ2wUTFhELpboyLoclS+0RMcnOd7Zm8I6jRAohKzFnPDThsXl18SDE2kSGL gfCjwKS4AgRzvaFTS+X9x/k9k5ygbuBamr7ulspl74jBmszEoJMltbF+YT1Gv4gnhx 7KSqrOPTm6tdA== From: Jisheng Zhang To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v4 0/2] riscv: errata: thead: use riscv_nonstd_cache_ops for CMO Date: Tue, 14 Nov 2023 22:33:36 +0800 Message-Id: <20231114143338.2406-1-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 14 Nov 2023 06:46:27 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782551087136355430 X-GMAIL-MSGID: 1782551090413660540 Previously, we use alternative mechanism to dynamically patch the CMO operations for THEAD C906/C910 during boot for performance reason. But as pointed out by Arnd, "there is already a significant cost in accessing the invalidated cache lines afterwards, which is likely going to be much higher than the cost of an indirect branch". And indeed, there's no performance difference with GMAC and EMMC per my test on Sipeed Lichee Pi 4A board. Use riscv_nonstd_cache_ops for THEAD C906/C910 CMO to simplify the alternative code, and to acchieve Arnd's goal -- "I think moving the THEAD ops at the same level as all nonstandard operations makes sense, but I'd still leave CMO as an explicit fast path that avoids the indirect branch. This seems like the right thing to do both for readability and for platforms on which the indirect branch has a noticeable overhead." To make bisect easy, I use two patches here: patch1 does the conversion which just mimics current CMO behavior via. riscv_nonstd_cache_ops, I assume no functionalities changes. patch2 uses T-HEAD PA based CMO instructions so that we don't need to covert PA to VA. since v4: - rebase on 6.7rc1 since v3: - collect Reviewed-by tag since v2: - collect Reviewed-by tag (but missed them in fact) - fix typo since v1: - collect Tested-by tag - add patch2 to use T-HEAD PA based CMO instructions. Jisheng Zhang (2): riscv: errata: thead: use riscv_nonstd_cache_ops for CMO riscv: errata: thead: use pa based instructions for CMO arch/riscv/Kconfig.errata | 1 + arch/riscv/errata/thead/errata.c | 69 +++++++++++++++++++++++++++- arch/riscv/include/asm/errata_list.h | 50 +++----------------- 3 files changed, 74 insertions(+), 46 deletions(-)