Message ID | 20231114134535.2455051-1-srasheed@marvell.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp1867280vqg; Tue, 14 Nov 2023 05:47:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1hqJ5NEb/ELVUBoY4Dgymh7Vp2BXklvpiY7JVH8NBWqXgcpbW38lqQOYCzysQPR6U3qsf X-Received: by 2002:a05:6a20:4295:b0:186:2d95:7d8e with SMTP id o21-20020a056a20429500b001862d957d8emr6405640pzj.40.1699969628278; Tue, 14 Nov 2023 05:47:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699969628; cv=none; d=google.com; s=arc-20160816; b=ZnwVIDo7SwrqehEWwLzxC2lEYtfqrq+89+NxG+vQl7GnBLSbbpUSsywbMp225hD0I3 /p0nKuIc7K/bTrYQYz/1fYHEschN3lwdiL1qb6Mf30qfqy1GbMomApN+k1IONdI3pBPh fHRccy805nSkrq7xtwqj4BLHAo7MFDXiZFjqHikL1D9nG4qOyLZbsS7QL/zNNLlGZ5Bo 3PePmcyx/xTzMosTofKFoID0auPSn6N6tUn/rfrJt8Ygzwa/XkctSZfvz3p9eMVSurTl pJlqFW4qmU15hIIpr2AzmA/6J6bnpAaIT4blhZaUua4EyDftegMB3QVQBVxUvvUXME3u XHlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Y6xTKIJSNSycWXwHzIPirKaKql9lBW7UOSjD7UTcWio=; fh=gNr59YhJeSqFpzAl5yMorJ8nj6h+jiBYcBCAuclPfFg=; b=ATpHdbzRxngINiFUr4b+KBwZ3ToFekEDhBpNUPrBsLNb+s6m1cSydHigCSnrW0Qfhb yIOzWqOxhZ9Y2RSQas49/MHSewUCHqnR81bxuj3eNgAtT05HU1ayuAAe3mCuyVElNAPl pEX5QxnMRdzXUZweizqb9wJkVb+2hl8tNPrjcZkloPT6Dp/6OoccNUlKDNLoTGPqyWzA Q+aAJ/pl1SO4qj9DIFuHhMBWya927qsteH75J6jL0iBtTR714E/nLj7hSUueBzfAe2yb Yrm6HUGJ8ErK3V8WsCpbdbf3MYMrowPeJMdoFc0knhU2tUTtt95XS4GvKRFO+fQaF1uj Ug3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=Gwzs6Ujn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id l12-20020a170903120c00b001c60c5bbff2si8454501plh.201.2023.11.14.05.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 05:47:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=Gwzs6Ujn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 056FA80886BD; Tue, 14 Nov 2023 05:46:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231203AbjKNNp4 (ORCPT <rfc822;lhua1029@gmail.com> + 29 others); Tue, 14 Nov 2023 08:45:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbjKNNpz (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 14 Nov 2023 08:45:55 -0500 Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 415771B6; Tue, 14 Nov 2023 05:45:52 -0800 (PST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AE857fF018310; Tue, 14 Nov 2023 05:45:41 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=Y6xTKIJSNSycWXwHzIPirKaKql9lBW7UOSjD7UTcWio=; b=Gwzs6UjnFQjJ8TfWB5Yd6ApuPXKYefENoew+5YUdbkdwAC2FW5FCfa7BKn7tjmtt4kVi IfC0i0jYh3ad5fGZck9UHejk0u1MxdWWoOx3YHhxX0A4RTwoMRjeUOGP4NpKoog63+us 1iArhQ1wZZnRw+jAtTEdwHKuzMf2IzMLla9AGWdnANwptnRrenBPKe3Wtstoeqiakeav Yhs6Wpgs06anRANXgM1UVm4O4pcx6RuxWqgnuFsQv3R3V7a8j75X0B06r73k7F5ixK6u B2i+yi8heDOhWb9xhxoFgg3xs4OM7H8ibA8ub3Of5uThJj3hfkP2KgFouknPhN5oWphm RQ== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3uc52eh2fu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 14 Nov 2023 05:45:41 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 14 Nov 2023 05:45:39 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 14 Nov 2023 05:45:39 -0800 Received: from ubuntu-PowerEdge-T110-II.sclab.marvell.com (unknown [10.106.27.86]) by maili.marvell.com (Postfix) with ESMTP id BFE163F705E; Tue, 14 Nov 2023 05:45:38 -0800 (PST) From: Shinas Rasheed <srasheed@marvell.com> To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org> CC: <hgani@marvell.com>, <vimleshk@marvell.com>, <egallen@redhat.com>, <mschmidt@redhat.com>, <pabeni@redhat.com>, <horms@kernel.org>, <kuba@kernel.org>, <davem@davemloft.net>, <wizhao@redhat.com>, <konguyen@redhat.com>, Shinas Rasheed <srasheed@marvell.com> Subject: [PATCH net-next v3 RESEND 0/4] Cleanup and optimizations to transmit code Date: Tue, 14 Nov 2023 05:45:31 -0800 Message-ID: <20231114134535.2455051-1-srasheed@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: tf2dSm-OW6Bz0Sw-zLmB43Bep35rrorF X-Proofpoint-ORIG-GUID: tf2dSm-OW6Bz0Sw-zLmB43Bep35rrorF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-14_13,2023-11-09_01,2023-05-22_02 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 14 Nov 2023 05:46:02 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782547353015649354 X-GMAIL-MSGID: 1782547353015649354 |
Series |
Cleanup and optimizations to transmit code
|
|
Message
Shinas Rasheed
Nov. 14, 2023, 1:45 p.m. UTC
Pad small packets to ETH_ZLEN before transmit, cleanup dma sync calls, add xmit_more functionality and then further remove atomic variable usage in the prior. Changes: V3: - Stop returning NETDEV_TX_BUSY when ring is full in xmit_patch. Change to inspect early if next packet can fit in ring instead of current packet, and stop queue if not. - Add smp_mb between stopping tx queue and checking if tx queue has free entries again, in queue full check function to let reflect IQ process completions that might have happened on other cpus. - Update small packet padding patch changelog to give more info. V2: https://lore.kernel.org/all/20231024145119.2366588-1-srasheed@marvell.com/ - Added patch for padding small packets to ETH_ZLEN, part of optimization patches for transmit code missed out in V1 - Updated changelog to provide more details for dma_sync remove patch - Updated changelog to use imperative tone in add xmit_more patch V1: https://lore.kernel.org/all/20231023114449.2362147-1-srasheed@marvell.com/ Shinas Rasheed (4): octeon_ep: add padding for small packets octeon_ep: remove dma sync in trasmit path octeon_ep: implement xmit_more in transmit octeon_ep: remove atomic variable usage in Tx data path .../ethernet/marvell/octeon_ep/octep_config.h | 3 +- .../ethernet/marvell/octeon_ep/octep_main.c | 55 +++++++++++-------- .../ethernet/marvell/octeon_ep/octep_main.h | 9 +++ .../net/ethernet/marvell/octeon_ep/octep_tx.c | 5 +- .../net/ethernet/marvell/octeon_ep/octep_tx.h | 3 - 5 files changed, 45 insertions(+), 30 deletions(-)
Comments
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 14 Nov 2023 05:45:31 -0800 you wrote: > Pad small packets to ETH_ZLEN before transmit, cleanup dma sync calls, > add xmit_more functionality and then further remove atomic > variable usage in the prior. > > Changes: > V3: > - Stop returning NETDEV_TX_BUSY when ring is full in xmit_patch. > Change to inspect early if next packet can fit in ring instead of > current packet, and stop queue if not. > - Add smp_mb between stopping tx queue and checking if tx queue has > free entries again, in queue full check function to let reflect > IQ process completions that might have happened on other cpus. > - Update small packet padding patch changelog to give more info. > V2: https://lore.kernel.org/all/20231024145119.2366588-1-srasheed@marvell.com/ > - Added patch for padding small packets to ETH_ZLEN, part of > optimization patches for transmit code missed out in V1 > - Updated changelog to provide more details for dma_sync remove patch > - Updated changelog to use imperative tone in add xmit_more patch > V1: https://lore.kernel.org/all/20231023114449.2362147-1-srasheed@marvell.com/ > > [...] Here is the summary with links: - [net-next,v3,RESEND,1/4] octeon_ep: add padding for small packets https://git.kernel.org/netdev/net-next/c/5827fe2bc9c4 - [net-next,v3,RESEND,2/4] octeon_ep: remove dma sync in trasmit path https://git.kernel.org/netdev/net-next/c/2fba5069959c - [net-next,v3,RESEND,3/4] octeon_ep: implement xmit_more in transmit https://git.kernel.org/netdev/net-next/c/373d9a55ba74 - [net-next,v3,RESEND,4/4] octeon_ep: remove atomic variable usage in Tx data path https://git.kernel.org/netdev/net-next/c/dc9c02b7faa0 You are awesome, thank you!