mbox series

[v1,0/3] Use the standard _PM_OPS() export macro in Intel Tangier GPIO driver

Message ID 20231113131600.10828-1-raag.jadav@intel.com
Headers
Series Use the standard _PM_OPS() export macro in Intel Tangier GPIO driver |

Message

Raag Jadav Nov. 13, 2023, 1:15 p.m. UTC 
  This series exports pm_ops structure from Intel Tangier GPIO driver using
EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper and reuses it into its users.

Raag Jadav (3):
  gpio: tangier: use EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper
  gpio: elkhartlake: reuse pm_ops from Intel Tangier driver
  gpio: tangier: unexport suspend/resume handles

 drivers/gpio/gpio-elkhartlake.c | 14 +-------------
 drivers/gpio/gpio-tangier.c     |  9 +++++----
 drivers/gpio/gpio-tangier.h     |  4 ++--
 3 files changed, 8 insertions(+), 19 deletions(-)

Comments

Andy Shevchenko Nov. 13, 2023, 3:58 p.m. UTC | #1 
On Mon, Nov 13, 2023 at 06:45:57PM +0530, Raag Jadav wrote:
> This series exports pm_ops structure from Intel Tangier GPIO driver using
> EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper and reuses it into its users.

Yet you missed --base...

Pushed to my review and testing queue, thanks!
Raag Jadav Nov. 14, 2023, 4:38 a.m. UTC | #2 
On Mon, Nov 13, 2023 at 05:58:34PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 13, 2023 at 06:45:57PM +0530, Raag Jadav wrote:
> > This series exports pm_ops structure from Intel Tangier GPIO driver using
> > EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper and reuses it into its users.
> 
> Yet you missed --base...

My understanding is that we use --base only for the patches with explicit
in-tree dependency, which this series doesn't have any AFAIK.

Will start using it for every patch if it makes everyone happy :)

Raag
Andy Shevchenko Nov. 14, 2023, 11:49 a.m. UTC | #3 
On Tue, Nov 14, 2023 at 06:38:44AM +0200, Raag Jadav wrote:
> On Mon, Nov 13, 2023 at 05:58:34PM +0200, Andy Shevchenko wrote:
> > On Mon, Nov 13, 2023 at 06:45:57PM +0530, Raag Jadav wrote:
> > > This series exports pm_ops structure from Intel Tangier GPIO driver using
> > > EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper and reuses it into its users.
> > 
> > Yet you missed --base...
> 
> My understanding is that we use --base only for the patches with explicit
> in-tree dependency, which this series doesn't have any AFAIK.
> 
> Will start using it for every patch if it makes everyone happy :)

For single patches it's not so critical, only for the series as I'm using b4
to treat them as PRs, so cover letter goes to the merge commit and b4 tries
to guess the base (often wrongly).
Mika Westerberg Nov. 14, 2023, 11:59 a.m. UTC | #4 
On Mon, Nov 13, 2023 at 06:45:57PM +0530, Raag Jadav wrote:
> This series exports pm_ops structure from Intel Tangier GPIO driver using
> EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper and reuses it into its users.
> 
> Raag Jadav (3):
>   gpio: tangier: use EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper
>   gpio: elkhartlake: reuse pm_ops from Intel Tangier driver
>   gpio: tangier: unexport suspend/resume handles
> 
>  drivers/gpio/gpio-elkhartlake.c | 14 +-------------
>  drivers/gpio/gpio-tangier.c     |  9 +++++----
>  drivers/gpio/gpio-tangier.h     |  4 ++--
>  3 files changed, 8 insertions(+), 19 deletions(-)

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Raag Jadav Nov. 14, 2023, 1:21 p.m. UTC | #5 
On Tue, Nov 14, 2023 at 01:49:08PM +0200, Andy Shevchenko wrote:
> On Tue, Nov 14, 2023 at 06:38:44AM +0200, Raag Jadav wrote:
> > On Mon, Nov 13, 2023 at 05:58:34PM +0200, Andy Shevchenko wrote:
> > > On Mon, Nov 13, 2023 at 06:45:57PM +0530, Raag Jadav wrote:
> > > > This series exports pm_ops structure from Intel Tangier GPIO driver using
> > > > EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper and reuses it into its users.
> > > 
> > > Yet you missed --base...
> > 
> > My understanding is that we use --base only for the patches with explicit
> > in-tree dependency, which this series doesn't have any AFAIK.
> > 
> > Will start using it for every patch if it makes everyone happy :)
> 
> For single patches it's not so critical, only for the series as I'm using b4
> to treat them as PRs, so cover letter goes to the merge commit and b4 tries
> to guess the base (often wrongly).

Understood, will take care from now on.

Raag