Message ID | 20231113131600.10828-1-raag.jadav@intel.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp1193151vqg; Mon, 13 Nov 2023 05:16:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IHADt9kSqKWzJMTD5UTutrVQ6JB88+jJQlUUV58WkYyGg2tAKIT0sSHeOV21F3p6djowh94 X-Received: by 2002:a17:90a:343:b0:280:9074:eb36 with SMTP id 3-20020a17090a034300b002809074eb36mr7037382pjf.14.1699881387578; Mon, 13 Nov 2023 05:16:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699881387; cv=none; d=google.com; s=arc-20160816; b=Tz8Ap+myjfynAm/wO6kenuagYp93hdHSeZ/1eQYFfNSE26Kyk8WLvDXVKBRZqyDLd4 dQVa9dT5jfqZLTD8gZ92fbfjL4g7S3vjPieHM+lWHIGPMaeD347mntx9t9B+NJv73ihE jYi5nZbaaS9rF+RraaKXfKbuPkUsBabahN7S9L5pwpuyl+epgnbbFx+Tn19vzaNZjf4Q HTDsYtjEIvcCMS+1M8OY1J+R7HHWmjep2uDZ0uvQq6NDvOGS8ZpywwdEk7GIyg+/pozD izoGptgowo1kDXBqfp2f89buBBmIbiVMyNxiUxViZr293bi+EX3tDDvE4qnqrRbRVSnE +YSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=gSnbh+ln7rCBbwvJ4aEvDZgoQT5batVef4aC5+18HIs=; fh=AaRHxHroqci6mwsR+355j0Rj4N3vJlegY3E0t/DDErE=; b=yhf6Z/38e+VO+odrYxgCa2rhg7u7vnCxCWqDfj9CpyrDKM+udtjZtW+wF1CeS1+CSY K8jp7smxkyGbz3xjyN6ZeHTMTsr7FnK4Uii4JodCjiBi1cIQEPrjUBRJdD8NZ4kicPZp RZtYplT2V9C2l/r1m1qZPcFj8cW9iiYSepe66lXvslFMJ5xmE5cdHnxhHFlQ5wbZgEg3 aJI8H4RmylB+ZJ1xm8sSADBzh/2Kiw18w0/nkHNIw6nK2rD5cEP91Cv2q7hlnGt3Eqvd TJexb60JETA/egoh86LeXOOU6HJul2LcxinsbCmdDPrP3cfT4jPfBE8De4Xg2y/n9pKD jaBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YobBFgFV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id k15-20020a633d0f000000b005b9a149e61esi5535715pga.649.2023.11.13.05.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 05:16:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YobBFgFV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 31E788063BD4; Mon, 13 Nov 2023 05:16:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbjKMNQQ (ORCPT <rfc822;heyuhang3455@gmail.com> + 29 others); Mon, 13 Nov 2023 08:16:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230322AbjKMNQO (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 13 Nov 2023 08:16:14 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B721D6C; Mon, 13 Nov 2023 05:16:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699881372; x=1731417372; h=from:to:cc:subject:date:message-id; bh=kq9n5m31IGPwjK9ijGxB7eVBkCuVsZqAuHDjOMKrLk8=; b=YobBFgFVyG/mYRx8Mj5uBTsHwVPopVsGvzxUEQnMWpfftM/EPDHMcLaA 37xE52MIihDTLYyQ6bMIo+wjUEax/kHk2r0x8HLd1VouTRbBiWrOjtaYd YRaJQEo7+KTZYBxVRkJdHjOsrlNNNJgs8ZIBlNHs2HYlP84QxFQQesjvB KNdJvhdL5ge3DUzN/8EwWT5dfQ1JpVqnUlXSra6A6BfgK4WlI2G+HEwdd o1SHWgFmL2ImFitbuQfZMQDIwxpUuq9At9sbeIpwyQkznfljL0mckCJOS R0n91+a8YprYQ9d4ginZBR4cI20eOGfS7/g/XtUFC3PfH/lkXZe9QwzYy A==; X-IronPort-AV: E=McAfee;i="6600,9927,10893"; a="454726892" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="454726892" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2023 05:16:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="5649365" Received: from inlubt0316.iind.intel.com ([10.191.20.213]) by fmviesa002.fm.intel.com with ESMTP; 13 Nov 2023 05:16:09 -0800 From: Raag Jadav <raag.jadav@intel.com> To: linus.walleij@linaro.org, brgl@bgdev.pl, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com, Raag Jadav <raag.jadav@intel.com> Subject: [PATCH v1 0/3] Use the standard _PM_OPS() export macro in Intel Tangier GPIO driver Date: Mon, 13 Nov 2023 18:45:57 +0530 Message-Id: <20231113131600.10828-1-raag.jadav@intel.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 13 Nov 2023 05:16:24 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782454826076476380 X-GMAIL-MSGID: 1782454826076476380 |
Series |
Use the standard _PM_OPS() export macro in Intel Tangier GPIO driver
|
|
Message
Raag Jadav
Nov. 13, 2023, 1:15 p.m. UTC
This series exports pm_ops structure from Intel Tangier GPIO driver using EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper and reuses it into its users. Raag Jadav (3): gpio: tangier: use EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper gpio: elkhartlake: reuse pm_ops from Intel Tangier driver gpio: tangier: unexport suspend/resume handles drivers/gpio/gpio-elkhartlake.c | 14 +------------- drivers/gpio/gpio-tangier.c | 9 +++++---- drivers/gpio/gpio-tangier.h | 4 ++-- 3 files changed, 8 insertions(+), 19 deletions(-)
Comments
On Mon, Nov 13, 2023 at 06:45:57PM +0530, Raag Jadav wrote: > This series exports pm_ops structure from Intel Tangier GPIO driver using > EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper and reuses it into its users. Yet you missed --base... Pushed to my review and testing queue, thanks!
On Mon, Nov 13, 2023 at 05:58:34PM +0200, Andy Shevchenko wrote: > On Mon, Nov 13, 2023 at 06:45:57PM +0530, Raag Jadav wrote: > > This series exports pm_ops structure from Intel Tangier GPIO driver using > > EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper and reuses it into its users. > > Yet you missed --base... My understanding is that we use --base only for the patches with explicit in-tree dependency, which this series doesn't have any AFAIK. Will start using it for every patch if it makes everyone happy :) Raag
On Tue, Nov 14, 2023 at 06:38:44AM +0200, Raag Jadav wrote: > On Mon, Nov 13, 2023 at 05:58:34PM +0200, Andy Shevchenko wrote: > > On Mon, Nov 13, 2023 at 06:45:57PM +0530, Raag Jadav wrote: > > > This series exports pm_ops structure from Intel Tangier GPIO driver using > > > EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper and reuses it into its users. > > > > Yet you missed --base... > > My understanding is that we use --base only for the patches with explicit > in-tree dependency, which this series doesn't have any AFAIK. > > Will start using it for every patch if it makes everyone happy :) For single patches it's not so critical, only for the series as I'm using b4 to treat them as PRs, so cover letter goes to the merge commit and b4 tries to guess the base (often wrongly).
On Mon, Nov 13, 2023 at 06:45:57PM +0530, Raag Jadav wrote: > This series exports pm_ops structure from Intel Tangier GPIO driver using > EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper and reuses it into its users. > > Raag Jadav (3): > gpio: tangier: use EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper > gpio: elkhartlake: reuse pm_ops from Intel Tangier driver > gpio: tangier: unexport suspend/resume handles > > drivers/gpio/gpio-elkhartlake.c | 14 +------------- > drivers/gpio/gpio-tangier.c | 9 +++++---- > drivers/gpio/gpio-tangier.h | 4 ++-- > 3 files changed, 8 insertions(+), 19 deletions(-) Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Tue, Nov 14, 2023 at 01:49:08PM +0200, Andy Shevchenko wrote: > On Tue, Nov 14, 2023 at 06:38:44AM +0200, Raag Jadav wrote: > > On Mon, Nov 13, 2023 at 05:58:34PM +0200, Andy Shevchenko wrote: > > > On Mon, Nov 13, 2023 at 06:45:57PM +0530, Raag Jadav wrote: > > > > This series exports pm_ops structure from Intel Tangier GPIO driver using > > > > EXPORT_NS_GPL_SIMPLE_DEV_PM_OPS() helper and reuses it into its users. > > > > > > Yet you missed --base... > > > > My understanding is that we use --base only for the patches with explicit > > in-tree dependency, which this series doesn't have any AFAIK. > > > > Will start using it for every patch if it makes everyone happy :) > > For single patches it's not so critical, only for the series as I'm using b4 > to treat them as PRs, so cover letter goes to the merge commit and b4 tries > to guess the base (often wrongly). Understood, will take care from now on. Raag