From patchwork Fri Nov 10 01:04:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 16441 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp811062vqs; Thu, 9 Nov 2023 17:05:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IEjFdjKTQT79abt2BhjxeDx6lyTxMq1Kj8qVdzc2MBLvx7g7XrGTgXhSSZWMVrt8uaryLej X-Received: by 2002:a05:6870:2a43:b0:1ea:85a:db2e with SMTP id jd3-20020a0568702a4300b001ea085adb2emr7546001oab.45.1699578301716; Thu, 09 Nov 2023 17:05:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699578301; cv=none; d=google.com; s=arc-20160816; b=ldsVse0080xlwKQhJcv1+l19g16wP+R7wGJrJ8li+FEfDdk26baUCPZmcirWYeqGY6 jMmbW0Lz6/j6o2M1Q9a2x3qL1L1leonSeHlPEMEh+UQV6lG4T78PCF+nI9cq1I1+WqQo Z6I6TXDLLOn0lHQms+eQLvxwHGX6axiMRW0/+WlTBhwG9u7d9vSAu3VxVIs/IXCRtS94 R8UfrE70oZ3fogsoYvzZWOkF4OK47oQ2DPlaPwPbv84KM9yVPiLLwDYCwnE7Vl8AS6Oi TUo+Mo0WIqB2L1pRk/E0u9iZvf5vBkwC4bTL6+8S8cLiJPkoyJGZ2hejFr3NCkh0ie/q q0uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=bnRFy/M2jUBSi2yJpJIE9XBcd/KDatAYWr+zVtKN5/g=; fh=JbbXkiP9+kqcX1llmfrYBP+pFau1HrlhgqJxX3xqd34=; b=qFNyow/gGls0AXUp7rPTY+4iF77cJmFtvoPjH9OKCzfxc7AJU7dDmZa8rTMA0n++yK WAIYpZHH6PGMJkAeD79czlMX7TRY69TzFYTMAqypNb8NfQ0gQK8zX05aUdApPEm5m4Pp 2Ef+rxNHFLyBQP2IlS/bNmoVfB/G0QpelvVYYDcRan2/85Vw7GlnT1FTcDD51wwyqwZK c7s95IIMNbxB277RVz9J7eUqFwr8zvHeIVJYdGhfxkRmOEaq+JGGB+L6VwnLjdBwy60H /q+M5qOUtn1NeIKYSpK3LMeEpd+7w3IkqmyRRyyQv4KMyVGkWRnkueuay5qSzThcxwm9 3xzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aZTNyfxd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id bk13-20020a056a02028d00b00578b4082453si8650381pgb.712.2023.11.09.17.05.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 17:05:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aZTNyfxd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 91F90805BCB4; Thu, 9 Nov 2023 17:05:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234801AbjKJBE4 (ORCPT + 30 others); Thu, 9 Nov 2023 20:04:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjKJBEz (ORCPT ); Thu, 9 Nov 2023 20:04:55 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC8033AA7 for ; Thu, 9 Nov 2023 17:04:52 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-409299277bbso10181895e9.2 for ; Thu, 09 Nov 2023 17:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699578291; x=1700183091; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=bnRFy/M2jUBSi2yJpJIE9XBcd/KDatAYWr+zVtKN5/g=; b=aZTNyfxdt00yg5wx4r1amcEQK5jlKbJ4CL85lWNfnkfAOBVPxalp9lgk3ZHBI8gigi I7mWDr8b7P/MtahGCycgPE++K4lMmXVyosY1uutASdVoHRvpe7v2S7ozC7hSDQgtu1eV YPosdNKYfMOMxOUdmlbxlrAp82JMGfNusnBQXZ4Se2BKpYIHL3ZwgwD57w8cP9JL7p3z DdkmqlpE2KNnj8KJMs1KM+QaVG0EhNOI91VBYIyAnqSODMYtFnaM+UcopV/tclQgQiGg rFWcDSTbm/gLbzTIjfiIBG45oiQN2HWqGgdT7/khllgpBxdaGx8riDRt3F4Jv/Bh/PY1 YjdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699578291; x=1700183091; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bnRFy/M2jUBSi2yJpJIE9XBcd/KDatAYWr+zVtKN5/g=; b=vU3g/B351gMSyWixCGCG4Qqm8zZ0SbWHblANcej4TMuy5B6irtX6siF0Yl0S5H4e4o PgIVNs+e6CGyUgP1bCqVz7492Bj9cSr65QZs4i44UGINXsp8dzGSZTzFJ9DyrKZPDV51 Ik8x13uAS6UytVFvf8/6t5CMlTASgzqbt4y8soqugqgV6OPD3ckroLp8WesU4cVKmjZc HrI9kwRHc8EuafzcWGI+8DCSnhl+qRazDbj2msuS32ZTEGrTp1Y6rXZ6iLzx+oks2AH9 1y/+CffUztNGdePe71q0qPs5xf8NYuVAC9YCmpV4ZLAbnk93sMsMo3Jdi6mhz+NDRb31 JtIQ== X-Gm-Message-State: AOJu0Ywvy0aiWBApO7Nr4i+xS/vKU8MQOehfTdFhxITfxOI+Dcs6gg/9 jV1LHQnENdnMJ0CV/xrNOtElyE5UqMOSgtsHIPsCeQ== X-Received: by 2002:a5d:47ca:0:b0:32d:ad4a:bcef with SMTP id o10-20020a5d47ca000000b0032dad4abcefmr5733784wrc.2.1699578290007; Thu, 09 Nov 2023 17:04:50 -0800 (PST) Received: from [127.0.0.1] ([37.228.218.3]) by smtp.gmail.com with ESMTPSA id d1-20020a056000114100b00326f0ca3566sm820562wrx.50.2023.11.09.17.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 17:04:49 -0800 (PST) From: Bryan O'Donoghue Subject: [PATCH v5 0/6] media: qcom: camss: Add sc8280xp support Date: Fri, 10 Nov 2023 01:04:45 +0000 Message-Id: <20231110-b4-camss-sc8280xp-v5-0-7f4947cc59c8@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAK2BTWUC/23OwQoCIRCA4VcJzxnjqKWdeo/o4JiWULuLxlLEv nsWBBt5/Afmm3myEnIKhW0XT5bDmErquxp6uWD+7LpT4OlYmyGgFAIEJ8W9u5bCizdo4D5wCIK sCISCIqt7Qw4x3T/m/lD7nMqtz4/PiVG8p18NG9ooOHBr7Toq8mSi2l1S53K/6vOJvbkR54RsE VgJ2riojqilQ/gj5JzQLUJWQpH0coMxQuMLNSdsi1CV0MZpQx4Bov0hpml6AZ6vujd8AQAA To: hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, Andy Gross , Bjorn Andersson , Konrad Dybcio , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , vincent.knecht@mailoo.org, matti.lehtimaki@gmail.com, quic_grosikop@quicinc.com Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Krzysztof Kozlowski X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 09 Nov 2023 17:05:00 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782137017163876282 X-GMAIL-MSGID: 1782137017163876282 V5: - Fixes the lower case 0x0c to 0x0C not sure how Konrad even saw this. - Drops frequency table to just individual frequencies not full array of opps - Konrad - As explained doesn't change the finding of frequencies. Current array size will ensure testing if (freq[x]) succeeds though I do agree this should be changed up. Plan to restructure struct params for specificity to VFE, CSID and will incorporate this change then. Link: https://lore.kernel.org/all/e80d4026-a525-48ef-b53a-f1276dd316e6@linaro.org - Reset sequence Right now the reset works. I agree qcom's downstream has more stuff in it. I've logged a task to evaluate expansion of the reset and to test across multiple platforms. For now not required for this drop. - _src clocks One assumes the reason at some stage in time we didn't have SET_PARENT in our CAMCC which meant setting _src clocks was necessary. In any case it ought not to be necessary now. Removing the _src from existing platforms should be trivial however we might find that as a result some of the CAMCC drivers need to be updated. That obviously is a separate series. Link to v4: https://lore.kernel.org/r/20231109-b4-camss-sc8280xp-v4-0-58a58bc200f9@linaro.org Link to tree: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/b4/camss-sc8280xp-v5 V4: - Drops all _src clocks and _SRC indexes in series. True enough the CAMCC driver has all of the appropriate SET_PARENT flags so there's no need to represent _src clocks. - Konrad - I've opted not to split C-PHY and D-PHY init sequences up unless/until we have a C-PHY init sequence upstream. - bod/Konrad - b4 trailes --update -> + Konrad's Acks Link to v3: https://lore.kernel.org/r/20231105-b4-camss-sc8280xp-v3-0-4b3c372ff0f4@linaro.org Link to tree: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/b4/camss-sc8280xp-v4 V3: - Strip pointer to dependencies from yaml patch I was hoping the robot would understand the links but it doesn't - Krzysztof Link to v2: https://lore.kernel.org/r/20231103-b4-camss-sc8280xp-v2-0-b7af4d253a20@linaro.org b4 base: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/b4/camss-sc8280xp-v3 V2: - Rebase to capture is_lite flag from named power-domain series - Amends commit log of final patch to give more detail on rename - Konrad - Opted not to change switch() statements with returns. - bod/Konrad Requires CAMCC for sc8280xp which applies to qcom/clk-for-6.7: https://lore.kernel.org/linux-arm-msm/20231026105345.3376-1-bryan.odonoghue@linaro.org/ b4 shazam 20231026105345.3376-1-bryan.odonoghue@linaro.org Requires the named power-domain patches which apply to media-tree/*: https://lore.kernel.org/linux-arm-msm/20231103-b4-camss-named-power-domains-v4-0-33a905359dbc@linaro.org/ b4 shazam e700133b-58f7-4a4d-8e5c-0d04441b789b@linaro.org Link to v1: https://lore.kernel.org/r/20231102-b4-camss-sc8280xp-v1-0-9996f4bcb8f4@linaro.org b4 base: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/b4/camss-sc8280xp-v2 V1: sc8280xp is the SoC found in the Lenovo X13s. This series adds support to bring up the CSIPHY, CSID, VFE/RDI interfaces. A number of precursor patches make this series smaller overall than previous series. sc8280xp provides - 4 x VFE, 4 RDI per VFE - 4 x VFE Lite, 4 RDI per VFE - 4 x CSID - 4 x CSID Lite - 4 x CSI PHY I've taken the yaml from a dtsi series and included it here since 1) I sent the yaml to the wrong person and 2) it already has RB from Krzysztof. Requires CAMCC for sc8280xp which applies to qcom/clk-for-6.7: https://lore.kernel.org/linux-arm-msm/20231026105345.3376-1-bryan.odonoghue@linaro.org/ b4 shazam 20231026105345.3376-1-bryan.odonoghue@linaro.org Requires the named power-domain patches which apply to media-tree/* : https://lore.kernel.org/linux-arm-msm/20231101-b4-camss-named-power-domains-v3-5-bbdf5f22462a@linaro.org/ b4 shazam 20231101-b4-camss-named-power-domains-v3-5-bbdf5f22462a@linaro.org To use the camera on x13s with say Google Hangouts or Microsoft Teams you will need to 1. Run Firefox 2. Update about:config to enable pipewire 3. Use this WIP version of libcamera https://gitlab.freedesktop.org/camera/libcamera-softisp A working bootable tree can be found here: Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/lenovo-x13s-linux-6.5.y b4 base: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/b4/camss-sc8280xp Signed-off-by: Bryan O'Donoghue --- Bryan O'Donoghue (6): media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding media: qcom: camss: Add CAMSS_SC8280XP enum media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 two-phase MIPI CSI-2 DPHY init media: qcom: camss: Add sc8280xp resource details media: qcom: camss: Add sc8280xp support media: qcom: camss: vfe-17x: Rename camss-vfe-170 to camss-vfe-17x .../bindings/media/qcom,sc8280xp-camss.yaml | 512 +++++++++++++++++++++ drivers/media/platform/qcom/camss/Makefile | 2 +- .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 108 ++++- drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + .../camss/{camss-vfe-170.c => camss-vfe-17x.c} | 0 drivers/media/platform/qcom/camss/camss-vfe.c | 25 +- drivers/media/platform/qcom/camss/camss-video.c | 1 + drivers/media/platform/qcom/camss/camss.c | 307 ++++++++++++ drivers/media/platform/qcom/camss/camss.h | 1 + 9 files changed, 948 insertions(+), 9 deletions(-) --- base-commit: 89e965e1a58f58cd359472b14c0cc25587bcf264 change-id: 20231101-b4-camss-sc8280xp-0e1b91eb21bf Best regards,