mbox series

[v3,0/3] s390/vfio-ap: a couple of corrections to the IRQ enablement function

Message ID 20231109164427.460493-1-akrowiak@linux.ibm.com
Headers
Series s390/vfio-ap: a couple of corrections to the IRQ enablement function |

Message

Anthony Krowiak Nov. 9, 2023, 4:44 p.m. UTC 
  This series corrects two issues related to enablement of interrupts in 
response to interception of the PQAP(AQIC) command:

1. Returning a status response code 06 (Invalid address of AP-queue 
   notification byte) when the call to register a guest ISC fails makes no
   sense.
   
2. The pages containing the interrupt notification-indicator byte are not
   freed after a failure to register the guest ISC fails.


Anthony Krowiak (2):
  s390/vfio-ap: unpin pages on gisc registration failure
  s390/vfio-ap: set status response code to 06 on gisc registration
    failure

Tony Krowiak (1):
  s390/vfio-ap: improve reaction to response code 07 from PQAP(AQIC)
    command

 drivers/s390/crypto/vfio_ap_ops.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

Alexander Gordeev Nov. 15, 2023, 2:29 p.m. UTC | #1 
On Thu, Nov 09, 2023 at 11:44:19AM -0500, Tony Krowiak wrote:
> This series corrects two issues related to enablement of interrupts in 
> response to interception of the PQAP(AQIC) command:
...

Hi Tony!

Via which tree this series is to be pulled?

Thanks!
Christian Borntraeger Nov. 17, 2023, 3:31 p.m. UTC | #2 
Am 15.11.23 um 15:29 schrieb Alexander Gordeev:
> On Thu, Nov 09, 2023 at 11:44:19AM -0500, Tony Krowiak wrote:
>> This series corrects two issues related to enablement of interrupts in
>> response to interception of the PQAP(AQIC) command:
> ...
> 
> Hi Tony!
> 
> Via which tree this series is to be pulled?
> 
> Thanks!

I wanted to create a topic repository/branch for s390-specfic vfio code when we expect conflicts or touch kvm or vfio base code.
I started that but I have not finished my preparations.

Given the diffstat:
drivers/s390/crypto/vfio_ap_ops.c | 12 ++++++++----
  1 file changed, 8 insertions(+), 4 deletions(-)

This looks pretty much isolated to s390, so unless Paolo or Alex complain,
we should simply carry that via the s390 tree.
Alexander, can you take those patches?
Tony, I assume none if the patches is urgent and can wait for the next merge window, correct?

Christian
Alexander Gordeev Nov. 17, 2023, 4:27 p.m. UTC | #3 
On Fri, Nov 17, 2023 at 04:31:49PM +0100, Christian Borntraeger wrote:
> Alexander, can you take those patches?

Applied, thanks!

> Christian
Anthony Krowiak Nov. 17, 2023, 10:49 p.m. UTC | #4 
On 11/17/23 10:31, Christian Borntraeger wrote:
> Am 15.11.23 um 15:29 schrieb Alexander Gordeev:
>> On Thu, Nov 09, 2023 at 11:44:19AM -0500, Tony Krowiak wrote:
>>> This series corrects two issues related to enablement of interrupts in
>>> response to interception of the PQAP(AQIC) command:
>> ...
>>
>> Hi Tony!
>>
>> Via which tree this series is to be pulled?
>>
>> Thanks!
> 
> I wanted to create a topic repository/branch for s390-specfic vfio code 
> when we expect conflicts or touch kvm or vfio base code.
> I started that but I have not finished my preparations.
> 
> Given the diffstat:
> drivers/s390/crypto/vfio_ap_ops.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> This looks pretty much isolated to s390, so unless Paolo or Alex complain,
> we should simply carry that via the s390 tree.
> Alexander, can you take those patches?
> Tony, I assume none if the patches is urgent and can wait for the next 
> merge window, correct?

It is not urgent.

> 
> Christian