From patchwork Thu Nov 9 07:37:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 16402 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp274538vqs; Wed, 8 Nov 2023 23:39:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGYpTJKrxz1EIVQG6Bzj3WYWxhLeRXDwlGeFaHOqJI6B2TBi/dOhELNHEQnQNb9Wxmr/sU X-Received: by 2002:a17:90b:3b4b:b0:27d:1339:9176 with SMTP id ot11-20020a17090b3b4b00b0027d13399176mr745599pjb.25.1699515557497; Wed, 08 Nov 2023 23:39:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699515557; cv=none; d=google.com; s=arc-20160816; b=HV7nKmxMXLLUAGsrShwHiqQEMqfRaYE5+uUbj04no6bNW8QCXancue8zDqorjs4s96 qrE3gUEq/wbksCOM1z+jd6DXforKJ+G4K/m5eMyEPOQfJR873Ub74CLH3K5Aeu153NkC 6w1xF+vU5J7WRBcsfZvP+W9nzq36UEvQE90XKBTgUbDdyZshyBdmpRJxfEHFNzOT7y8T W8eS4TkF2I+vFHd5vLSGd8ShdLjlRk+JNrCdxafH0WlyWOAb9vonVMo9kQO2A2PGZQBE ObaSXbPzatrPbMDWP0bhVr99CWuhkVGmM8O1l5tsSc7IVLT5a+XCqO/R4+xthiC9BxTv oh/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=/4xuTOVnSQbp1L8UCL4XJL7XX/0Sv2qRBa1gCZSvAhU=; fh=VcFGZLNWgMGQ4upKwTm/W4LWonQY/s0njiVgLSyQISc=; b=ZSt6QMaMPMjeqYR1CwZ/3MorUccZj3eSZAPxWYe+E/5TwONN+f56++SvZFwLmymo5w 0/7qtDqBYv8Pt8D+qashw+zaDzZq8CT8YbneQn+mJlmCMzsOI3vsipk1KMKXKz67CW2U ybwsfHG77Fi4R7ZZogk4YXQzydfl7uHsr90c3av1UkLE+HaqpKSof5ESIa9ehQoOOe/d 3j7QM6/ycVcYBZpB9QcuAOTViNyU4F17P6OsFKC4PyLuHhd5ugDbYx2vUgvUxxXhVzsk a4ebZ5NJ8tngxIjryAntv5Bv2WCa4p1aVRaskgJr+e+4j+j/gbzPUcQmyb/9XFWD8MMK dZsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=oUXtpzDb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id lp15-20020a17090b4a8f00b002568a675b65si1177692pjb.141.2023.11.08.23.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 23:39:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=oUXtpzDb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 4E998826BBB2; Wed, 8 Nov 2023 23:39:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232753AbjKIHis (ORCPT + 32 others); Thu, 9 Nov 2023 02:38:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbjKIHir (ORCPT ); Thu, 9 Nov 2023 02:38:47 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18E3F173E; Wed, 8 Nov 2023 23:38:45 -0800 (PST) Received: from [127.0.1.1] (91-158-149-209.elisa-laajakaista.fi [91.158.149.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EFE888CD; Thu, 9 Nov 2023 08:38:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1699515500; bh=K5DujEbhOcvF8V0vOBipXP97KqHSFEg9HlwVJty2vcQ=; h=From:Subject:Date:To:Cc:From; b=oUXtpzDbina89XTQ0xCyroC7niGhleWtFzrd5nONQFWnXuynFZIk5SMerX7gJd86K vFZnRcQSM8tt7RThRdnmtX/NVyQQW7OdJcpstV65SXQxYXD5i+NQWCQXYAuJCGjOv7 la2CHaft0vtsXb+msObjhepskpL6pS9+S1/s+H8E= From: Tomi Valkeinen Subject: [PATCH v2 00/11] drm/tidss: Probe related fixes and cleanups Date: Thu, 09 Nov 2023 09:37:53 +0200 Message-Id: <20231109-tidss-probe-v2-0-ac91b5ea35c0@ideasonboard.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAFGMTGUC/1XMMQ6DMAyF4asgz01lhyBBp94DMQRiiocSFCPUC nH3pnTq+D/pfTsoJ2GFW7FD4k1U4pzDXgoYJj8/2EjIDRZtSViiWSWomiXFnk1duZ6wqYfSj5A fS+JRXqfWdrkn0TWm94lv9F1/DiH9ORsZNK4i1zCOjaPqLoG9xrmPPoXrEJ/QHcfxAZa/ehitA AAA To: Aradhya Bhatia , Devarsh Thakkar , Jyri Sarha , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Francesco Dolcini , Tomi Valkeinen , stable@vger.kernel.org X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1683; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=K5DujEbhOcvF8V0vOBipXP97KqHSFEg9HlwVJty2vcQ=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBlTIx5/yLJFpEz95q5saAlhY8HDiWiIQruDALpr YxC4SMpCw6JAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZUyMeQAKCRD6PaqMvJYe 9Q7tEACvpcHd4FERj8bnkkfGozhkNIkIamq2k8bAlryuvPHV6RGk1sFeeOozCSHncd0CK0CIMRu BTMzMyL8JiQyGiPBQyvwaaLJDwEdTvL0+m/sdZvyiDYD6WA46JNJiciJY9JDJrpyVUVrhza8cXQ AtFKQF5e4Hh2+TyyM2Q0+snYwJlppHMxqDBf3T/c3sgLVnGbFLDHJp8FCt7ri8ArmkmS8TSwlUR 78NMjrShiJLFOa5bzMHlhitgTE9DFatush1tkezO1k1tpC6wPs0OqKbpCwW3hKZR/SXmS4wlLNw 2euaNxQrShxJVYzb6tRZy8SaD26Yu802+pGn0kd4H4tkrESLcYlZRD/vVQ2XvmU7z+jxLHqqxwZ eE+T7D/NKNoHibh+knmPX+yH4wka+K4AusC1/pMHXZusU9NzuM0tvzfDoV/yErZFFKqKJ/eduqf 8saGCcnCSX69EdAE7KEFid+mynxGHOSE03y1X/vn4kfyQT8CKYqtCSUIE1HqA3w7Uv7e05GaqsJ 8331ip8Ez0Gcb76na398kO3gDD9xWM8SWV1vq55y2aKO7kYM6Rqpzf8UPkT4FwLr1J4mLAaNTEz GBgCOxMjkkDMJ3FKC0Xdws4o6JYsMTIZpHApJeGSuGLpnytKOT/E3sFR7Y3ay+ZPAvslx1jQFY8 jwjwzxvSeJTaGVw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 08 Nov 2023 23:39:09 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782071225611191738 X-GMAIL-MSGID: 1782071225611191738 While working on the TI BSP kernel, adding bootload splash screen support, I noticed some issues with the driver and opportunities for cleanups and improvements. Tomi Signed-off-by: Tomi Valkeinen Reviewed-by: Aradhya Bhatia --- Changes in v2: - Add missing pm_runtime_dont_use_autosuspend() in error path - Add simple manual "reset" for K2G - Leave tidss->dispc NULL if dispc_init fails - Add Fixes tags - Drop "drm/tidss: Add dispc_is_idle()" - Add "drm/tidss: Use DRM_PLANE_COMMIT_ACTIVE_ONLY" - Link to v1: https://lore.kernel.org/r/20231101-tidss-probe-v1-0-45149e0f9415@ideasonboard.com --- Tomi Valkeinen (11): drm/tidss: Use pm_runtime_resume_and_get() drm/tidss: Use PM autosuspend drm/tidss: Drop useless variable init drm/tidss: Move reset to the end of dispc_init() drm/tidss: Return error value from from softreset drm/tidss: Check for K2G in in dispc_softreset() drm/tidss: Add simple K2G manual reset drm/tidss: Fix dss reset drm/tidss: IRQ code cleanup drm/tidss: Fix atomic_flush check drm/tidss: Use DRM_PLANE_COMMIT_ACTIVE_ONLY drivers/gpu/drm/tidss/tidss_crtc.c | 12 ++---- drivers/gpu/drm/tidss/tidss_dispc.c | 79 +++++++++++++++++++++++++++++++++---- drivers/gpu/drm/tidss/tidss_drv.c | 15 +++++-- drivers/gpu/drm/tidss/tidss_irq.c | 54 ++++--------------------- drivers/gpu/drm/tidss/tidss_kms.c | 2 +- 5 files changed, 97 insertions(+), 65 deletions(-) --- base-commit: 9d7c8c066916f231ca0ed4e4fce6c4b58ca3e451 change-id: 20231030-tidss-probe-854b1098c3af Best regards,