Message ID | 20231108125604.162383-1-EABachinin@salutedevices.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp891431vqo; Wed, 8 Nov 2023 04:57:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNsbIG5CCmARXGBPiIBzgFYO3hU996EYxFxS9FZkXi0ZWQFFF/OMVvVi6EPxkEFnf1MGtb X-Received: by 2002:a17:902:6ac4:b0:1cc:47a6:12bf with SMTP id i4-20020a1709026ac400b001cc47a612bfmr1582936plt.47.1699448254915; Wed, 08 Nov 2023 04:57:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699448254; cv=none; d=google.com; s=arc-20160816; b=WKu8XpR3dV04lsZVTf38/gbT6a7GE7uGf616Kt5/CGL7HqzZhi7d00oI0PrMoo5EmK 1LaJRjpOZQwM/xLXeZvVEW8KQ2I1V4/xEGEOQsyPLaULU8FXbhT8fgmQOuNGLVEWyF8p snD/zeKU6IGorpPGpCt/aeHRRWkBT+OU1lFut3yZ9G0rjbzMBk+cvFQHXWLtRs7SKc6u pgChTO73M4VDYPmoy4+kxSFMrbV7XKJ3hdPBMU4T4cdSO+7UMxzRQMb22tevwvFuiw8G DYbVgCVAKc1o7xq5fNyQa0ovWswEYkG0XilQIi9h240AgMdCmzbX1G+IhQlU0Hhf6iw3 xgOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=o3HN9w6B5G0SK9zVHy0ukaxr6aC9dqXoqv66Yn0Zd9M=; fh=0AE460OZJFTNdZVCaErkEDAIe9NCf6r6sYaEen+oZ9Y=; b=IQKksS70a9DeOjYP3DlfX+dOgcHyiPGWyGMwo62L1rOE/TridHD8C3+aX0y7pTsvwb Swd6Nvl0Vhg6m8F/cj+lV+tFDZTML6MsY7jRU9OuxcnxbM6IiKUaa0YadutUs9TByJbw 9wcmX6FRrwBe3N1tuGTWfWoAdxuKsqQ5LRlj6AhXGAov9TrHLTSijN8ViShyFxVzcS9d QNcxx0JgrWHH1EGbmAkX8FsXEdOObIC8VOT0r04C9V/DuM4kAT3RJq2XUfSoEMa9zN3y lpinm5stQ4B1ojZ9dlEOohsiPGY3hnUddsrAhnQmgvxXgZ501gVO/MjH4QzpurNICxhE FOGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=DdqjDPh8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id kh12-20020a170903064c00b001cc4fbe9281si2014905plb.582.2023.11.08.04.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 04:57:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=DdqjDPh8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C19F0806C375; Wed, 8 Nov 2023 04:57:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344521AbjKHM5E (ORCPT <rfc822;jaysivo@gmail.com> + 32 others); Wed, 8 Nov 2023 07:57:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbjKHM5D (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 8 Nov 2023 07:57:03 -0500 Received: from mx1.sberdevices.ru (mx2.sberdevices.ru [45.89.224.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 276211BF3 for <linux-kernel@vger.kernel.org>; Wed, 8 Nov 2023 04:57:01 -0800 (PST) Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 24A0A120005; Wed, 8 Nov 2023 15:56:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 24A0A120005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1699448219; bh=o3HN9w6B5G0SK9zVHy0ukaxr6aC9dqXoqv66Yn0Zd9M=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=DdqjDPh8qW8V14JgGwGL/HvMuY+T+kFXf/EYR91Btj4Q/P9WbejwgzshPuvYvjZHM sYGp7grnbNQY4Tko58HVM43Qjso+cGCNnj1mqGy0RzseaAiwA7vzb+Gk43ALEu5bqc /HxD9+z6IucoPa3x2QB781ao9GVq4qO0X8UtLNgac1ABArq/7FP6TMqbBHuSKlm+7D OWOVTQHWVYH5XPOn2IIDDP9mENqeMjmiCPNAkDeD2Gi9vAhGVGZJZvMCEBb2Qb3khi De77qVz09nGFcjIh0G/eNV2wH5vSasEt4v+9zizfhEXtWKXq5YcDQxgpMbVX1Bdcod rmxez/vr1KAxQ== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Wed, 8 Nov 2023 15:56:58 +0300 (MSK) Received: from pc (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Wed, 8 Nov 2023 15:56:57 +0300 From: Evgeny Bachinin <EABachinin@salutedevices.com> To: Neil Armstrong <neil.armstrong@linaro.org>, Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, Evgeny Bachinin <EABachinin@salutedevices.com>, Dmitry Rokosov <ddrokosov@sberdevices.ru>, Miles Chen <miles.chen@mediatek.com>, Alexey Romanov <avromanov@salutedevices.com> CC: <kernel@sberdevices.ru>, <evgen89bachinin@gmail.com>, <linux-arm-kernel@lists.infradead.org>, <linux-amlogic@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH v1 0/2] firmware: meson_sm: cleanup error paths inside probe() Date: Wed, 8 Nov 2023 15:56:02 +0300 Message-ID: <20231108125604.162383-1-EABachinin@salutedevices.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 181206 [Nov 08 2023] X-KSMG-AntiSpam-Version: 6.0.0.2 X-KSMG-AntiSpam-Envelope-From: eabachinin@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 543 543 1e3516af5cdd92079dfeb0e292c8747a62cb1ee4, {Tracking_from_domain_doesnt_match_to}, d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;salutedevices.com:7.1.1;p-i-exch-sc-m01.sberdevices.ru:5.0.1,7.1.1;100.64.160.123:7.1.2, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/11/08 12:09:00 #22428609 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 08 Nov 2023 04:57:32 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782000653300975153 X-GMAIL-MSGID: 1782000653300975153 |
Series |
firmware: meson_sm: cleanup error paths inside probe()
|
|
Message
Evgeny Bachinin
Nov. 8, 2023, 12:56 p.m. UTC
At first, patches series refactors sysfs node creation to avoid extra code paths. After that, the resource leak in probe error path is fixed. Evgeny Bachinin (2): firmware: meson_sm: refactor serial sysfs entry via dev_groups attrs firmware: meson-sm: unmap out_base shmem in error path drivers/firmware/meson/meson_sm.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-)
Comments
On 08/11/2023 13:56, Evgeny Bachinin wrote: > At first, patches series refactors sysfs node creation to avoid extra code > paths. After that, the resource leak in probe error path is fixed. > > Evgeny Bachinin (2): > firmware: meson_sm: refactor serial sysfs entry via dev_groups attrs > firmware: meson-sm: unmap out_base shmem in error path > > drivers/firmware/meson/meson_sm.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Hi, On Wed, 08 Nov 2023 15:56:02 +0300, Evgeny Bachinin wrote: > At first, patches series refactors sysfs node creation to avoid extra code > paths. After that, the resource leak in probe error path is fixed. > > Evgeny Bachinin (2): > firmware: meson_sm: refactor serial sysfs entry via dev_groups attrs > firmware: meson-sm: unmap out_base shmem in error path > > [...] Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.8/drivers) [1/2] firmware: meson_sm: refactor serial sysfs entry via dev_groups attrs https://git.kernel.org/amlogic/c/d397965e584e0f2c6193b927c1e7693d514a6738 [2/2] firmware: meson-sm: unmap out_base shmem in error path https://git.kernel.org/amlogic/c/d8385d7433f9c7d718448465e30d6b8c1207b59f These changes has been applied on the intermediate git tree [1]. The v6.8/drivers branch will then be sent via a formal Pull Request to the Linux SoC maintainers for inclusion in their intermediate git branches in order to be sent to Linus during the next merge window, or sooner if it's a set of fixes. In the cases of fixes, those will be merged in the current release candidate kernel and as soon they appear on the Linux master branch they will be backported to the previous Stable and Long-Stable kernels [2]. The intermediate git branches are merged daily in the linux-next tree [3], people are encouraged testing these pre-release kernels and report issues on the relevant mailing-lists. If problems are discovered on those changes, please submit a signed-off-by revert patch followed by a corrective changeset. [1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git