Message ID | 20231106184052.1166579-1-andriy.shevchenko@linux.intel.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp2855002vqu; Mon, 6 Nov 2023 10:41:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IHkeH+FyXaVMG0A9PyKPaZArHgY1M78gNvezibQ88Deh3KbR+rhQdLwI8U4sAMN6XsakN0F X-Received: by 2002:a17:90a:2f62:b0:27f:bd9e:5a19 with SMTP id s89-20020a17090a2f6200b0027fbd9e5a19mr24430454pjd.25.1699296087872; Mon, 06 Nov 2023 10:41:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699296087; cv=none; d=google.com; s=arc-20160816; b=ZlVzKBqrgn0VrQHjWjxn2C5S20g7E24h5ca1Ktk0xRvJyS8i6QAwfCruEFBysFCRtO UPJqF97UXsS8glc91KZ+Kz8U9Ngoh4iJnY6R1xgzrUZB37tgv/Uf41u7JIvPi1exc675 BHK6XUgnqWmh1XG45Y92IWQJf4Rj50qXpSbYWgUi/8/nIXCZF6+pEHpnh56Vpy+DEq+v +LmG+AG79RZpHeA9p5zj3pE1KdPGSOk5a44Z13tvHYb7DloiHt5V0CepWKOvyLq7IDsW q4sDPmGeA2XQ8JaKsiZXTuSuBWCxaDaYlqmzv7VB1pws0ALm7adXlfg53TGaXGRfPeT3 wi4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=DZDTgfGX6qiSnHUX7Lc3ddAcaXTeBea7gBpJ4/8h9aM=; fh=EhYQnArFbMHj9GetyMtC39fFiEl2zsDTlAIuGjtTRaM=; b=LNtm4igD7BnBEteoPzr4ZJROsr7mdiZ9faymUfr+zY8DiRORu0Dqua+wHzCMuoSPCU EYOFSgXnE3XDAKds2wSH2fUzMHJH9gkROFH1AeEpP6fY2CcBLPQ48kECC3IH+4iWgUBU 26AdNFzNKKjPr+OG2Dg3qhvYaGYBbLzHQXraSTRUSNKftXapIqythKN8v9JhDV0zuJyt +/LSMMKL7W/b0J6v8k9SId+ZkrQUjiK9Sv6dIOSxzc+s6IP1BOFis78+mgPrM5BS3BKJ 064gPxpq5OrVazGWzP7z0E/StzDxutHja3EcVmTOQdK0BUlliYSXS2O9YtphWpKSe5sM xS5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Y3O0hyLw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id fw19-20020a17090b129300b002803426321asi8191458pjb.175.2023.11.06.10.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 10:41:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Y3O0hyLw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id DF12680A9B22; Mon, 6 Nov 2023 10:41:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232020AbjKFSlF (ORCPT <rfc822;lhua1029@gmail.com> + 34 others); Mon, 6 Nov 2023 13:41:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232269AbjKFSlD (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 6 Nov 2023 13:41:03 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 784BFD57 for <linux-kernel@vger.kernel.org>; Mon, 6 Nov 2023 10:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699296059; x=1730832059; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nDaE5gZt44QLBdwS8FvZ6dreGzaftv8+ViIX+mgmasM=; b=Y3O0hyLwLqClC2gOpufm6/5V3uPGD8+vsTHdWxVOCpm1EO6/6DBEj8GW 4q2+Wzw82LvEOShbQNrD5Nev1AmiKD1eFCpi/Nu0a0z4t1GgfDd5puul0 +Uq4/Du9hgZ/0ZCswk0wUJBqtoW3F5mtk0k9xY7T5SuAdWCNxFWpYk/s6 j4PamHpFVF6HRKDmIk8zE0Rnn3w7+wQdAD5W1+6IfTZWfuQxBCPXDcQId KTzdSM5j5xRwX5LvDaTqX8PZ86WIB1dxGJ/Madf1h9ya3eFiBIA7nBc1e mIZnsDTEC+Vqj20hpMkihZdiK+BM+EA4SgwlVRMWzLEgsuyYUfLWkZL+8 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10886"; a="7975895" X-IronPort-AV: E=Sophos;i="6.03,282,1694761200"; d="scan'208";a="7975895" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 10:40:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10886"; a="832807950" X-IronPort-AV: E=Sophos;i="6.03,282,1694761200"; d="scan'208";a="832807950" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Nov 2023 10:40:56 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 365961A5; Mon, 6 Nov 2023 20:40:54 +0200 (EET) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Jarkko Nikula <jarkko.nikula@linux.intel.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Chen Ni <nichen@iscas.ac.cn>, linux-kernel@vger.kernel.org Cc: Lee Jones <lee@kernel.org> Subject: [PATCH v3 0/2] mfd: intel-lpss: refactor PCI probe and common IRQ check Date: Mon, 6 Nov 2023 20:40:50 +0200 Message-Id: <20231106184052.1166579-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 06 Nov 2023 10:41:21 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781841094652164893 X-GMAIL-MSGID: 1781841094652164893 |
Series |
mfd: intel-lpss: refactor PCI probe and common IRQ check
|
|
Message
Andy Shevchenko
Nov. 6, 2023, 6:40 p.m. UTC
The PCI code can be refactored to use respective PCI APIs instead of direct dereference of struct pci_dev members. With that, we may unshadow the error code that is promoted in the irq field of info structure. PCI core shouldn't propagate 0 as a value there, and in case it happens it reveals a bug somewhere else. Changelog: v2 -> v3: 1. Refactored PCI glue driver a bit (a new patch) 2. Updated commit message in the original patch v1 -> v2: 1. Update commit message 2. Fix IRQ check in intel_lpcc_probe() Andy Shevchenko (1): mfd: intel-lpss: Use PCI APIs instead of derefereincing Chen Ni (1): mfd: intel-lpss: Amend IRQ check drivers/mfd/intel-lpss-pci.c | 8 ++++++-- drivers/mfd/intel-lpss.c | 5 ++++- 2 files changed, 10 insertions(+), 3 deletions(-)
Comments
On Mon, 06 Nov 2023 20:40:50 +0200, Andy Shevchenko wrote: > The PCI code can be refactored to use respective PCI APIs instead of > direct dereference of struct pci_dev members. > > With that, we may unshadow the error code that is promoted in the irq > field of info structure. PCI core shouldn't propagate 0 as a value > there, and in case it happens it reveals a bug somewhere else. > > [...] Applied, thanks! [1/2] mfd: intel-lpss: Use PCI APIs instead of derefereincing commit: e6951fb7878751aba4c147f1f206a2cbc05d1b9f [2/2] mfd: intel-lpss: Amend IRQ check commit: ec791121b8ace33d2251b6c7a4d11a231ee51c05 -- Lee Jones [李琼斯]