mbox series

[v3,0/2] mfd: intel-lpss: refactor PCI probe and common IRQ check

Message ID 20231106184052.1166579-1-andriy.shevchenko@linux.intel.com
Headers
Series mfd: intel-lpss: refactor PCI probe and common IRQ check |

Message

Andy Shevchenko Nov. 6, 2023, 6:40 p.m. UTC 
  The PCI code can be refactored to use respective PCI APIs instead of
direct dereference of struct pci_dev members.

With that, we may unshadow the error code that is promoted in the irq
field of info structure. PCI core shouldn't propagate 0 as a value
there, and in case it happens it reveals a bug somewhere else.

Changelog:

v2 -> v3:
1. Refactored PCI glue driver a bit (a new patch)
2. Updated commit message in the original patch

v1 -> v2:
1. Update commit message
2. Fix IRQ check in intel_lpcc_probe()

Andy Shevchenko (1):
  mfd: intel-lpss: Use PCI APIs instead of derefereincing

Chen Ni (1):
  mfd: intel-lpss: Amend IRQ check

 drivers/mfd/intel-lpss-pci.c | 8 ++++++--
 drivers/mfd/intel-lpss.c     | 5 ++++-
 2 files changed, 10 insertions(+), 3 deletions(-)

Comments

Lee Jones Nov. 23, 2023, 11:17 a.m. UTC | #1 
On Mon, 06 Nov 2023 20:40:50 +0200, Andy Shevchenko wrote:
> The PCI code can be refactored to use respective PCI APIs instead of
> direct dereference of struct pci_dev members.
> 
> With that, we may unshadow the error code that is promoted in the irq
> field of info structure. PCI core shouldn't propagate 0 as a value
> there, and in case it happens it reveals a bug somewhere else.
> 
> [...]

Applied, thanks!

[1/2] mfd: intel-lpss: Use PCI APIs instead of derefereincing
      commit: e6951fb7878751aba4c147f1f206a2cbc05d1b9f
[2/2] mfd: intel-lpss: Amend IRQ check
      commit: ec791121b8ace33d2251b6c7a4d11a231ee51c05

--
Lee Jones [李琼斯]