From patchwork Fri Nov 3 08:47:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Adrian Hunter X-Patchwork-Id: 16208 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp884070vqu; Fri, 3 Nov 2023 01:48:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEx0YMHjKqW9+cuyAYaDoFitIVB+jYhWWo7esWTTBJVcp9B444D5hZBs/ZJFt1rssOZ5c7R X-Received: by 2002:a17:90a:ff0e:b0:280:37a0:69d4 with SMTP id ce14-20020a17090aff0e00b0028037a069d4mr2298957pjb.19.1699001304823; Fri, 03 Nov 2023 01:48:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699001304; cv=none; d=google.com; s=arc-20160816; b=d+0E/RGS8WMSfkQmt9DbWAgr+z/DPsiFUH5fS4n0Ko1uYT2+6Lm+EY+ZIr2+RlxLfv P7yME8p3f39t6KfQJxJMi4UwNajLB1plg2LBuuDJfQ8mHXyNgbWxBbYHwMiSQ7gbYzfg 6VgoMg942tAbWEHdk9vh1q5nCwUYJnEpKKORhlONVBqnKOyjUdOHrV/9UdZQJIlixqkA OzNOFoLGrf6KD69lPex57WZXrvjJeFKsYFfpZ+oV247qCq3/yYey72EOGFmoqvwgCwc6 b6HXus0GpCjjuzO3urGqeMef97sVbYuUJ0P02OQ4I8SAIumeOO7CREo97+8LOOMHpc9E pL1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:organization :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=XE0eqAFE4/QQInItes14ipnZaTnea+18EtZ6N3y70zc=; fh=aIvDo0DPc47ZdKemLI3k3NodRhLAZ2m+5rlxdvTm1gA=; b=1B4xN7tkOPsCPpB60meHTswJtSGXA46X0x8kaY0QDcE9gtxb3EhEKEViTrRrUuPEpw B9TVnhoJ3OHLW83OYIEomr9/ObS++Qx2uLf1gf+eG8WTi2k4zPVaXrrzRI528fsAI1xS 2uuveFjaVjKRMNIJmkoyHTHhWktFvfirzkR/AGfFaNSF1bIy/9j4X3YBRcJoBvU+ZX67 yrLKG7XNHhPC/bqQbZKwbV/MdN/VlnHTUpqBLoUpunghH9YRZtF/xq7upkFQKEd8NKgZ ObwrGfC/cH3hv2utZHd7ZjLbkAbjMXda/MOr7lchux3ndOK+uoCKJGH8zddpbW65+M9p QPYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XVk89u7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id r18-20020a63ce52000000b005b8f0ff9b35si1139776pgi.406.2023.11.03.01.48.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 01:48:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XVk89u7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 1A92E83792F4; Fri, 3 Nov 2023 01:48:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235169AbjKCIsT (ORCPT + 36 others); Fri, 3 Nov 2023 04:48:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235136AbjKCIsR (ORCPT ); Fri, 3 Nov 2023 04:48:17 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1570BD5E; Fri, 3 Nov 2023 01:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699001291; x=1730537291; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=pgGJxu22SuOko7jFYhtpgXsdMllFfBeSM101ozpIhzo=; b=XVk89u7TqoH56DMFL2Zr2HGqAPdC1fevrvR0Eg4cBOGHWBkYEUfzoMKm a72Ec0bwa06gjgLPEvDHpM8Mm42WInjb5rtkZCQFIKcJph/5P4STYH6so 6I7Pp/86bPqSCtcWuxPiWdOW2QNax4OonXw0ecCd90AxK21uBQ/UUpJ+O VXmb1DQ1iZRGDA8NMojKlFqwZD4oJqcm6MOOznzd+L9rGxwANhnOODEcm 0uKLdarRC3tYNhWRJwWFEbXuXAzUSsyqT3bBoqvYri+cqpkazxtmwfT6Y gHGYG80lYvXdIW7A9PpDNLh8bLEMv85ckUpfBvaALwgsKivPt1N9ah3Rb g==; X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="391774470" X-IronPort-AV: E=Sophos;i="6.03,273,1694761200"; d="scan'208";a="391774470" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 01:48:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="796556409" X-IronPort-AV: E=Sophos;i="6.03,273,1694761200"; d="scan'208";a="796556409" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO ahunter-VirtualBox.home\044ger.corp.intel.com) ([10.252.51.133]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 01:48:04 -0700 From: Adrian Hunter To: Ulf Hansson , =?utf-8?q?Kornel_Dul=C4=99ba?= , Radoslaw Biernacki , Gwendal Grignou , Asutosh Das Cc: Chaotian Jing , Bhavya Kapoor , Kamal Dasu , Al Cooper , Haibo Chen , Shaik Sajida Bhanu , Sai Krishna Potthuri , Victor Shih , Ben Chuang , Thierry Reding , Aniruddha Tvs Rao , Chun-Hung Wu , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 0/6] mmc: block: Fixes for CQE error recovery recovery Date: Fri, 3 Nov 2023 10:47:14 +0200 Message-Id: <20231103084720.6886-1-adrian.hunter@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 03 Nov 2023 01:48:24 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781531992219217636 X-GMAIL-MSGID: 1781531992219217636 Hi Some issues have been found with CQE error recovery. Here are some fixes. As of V2, the alternative implementation for the patch from Kornel Dulęba: https://lore.kernel.org/linux-mmc/e7c12e07-7540-47ea-8891-2cec73d58df1@intel.com/T/#u is now included, see patch 6 "mmc: cqhci: Fix task clearing in CQE error recovery") Please also note ->post_disable() seems to be missing from cqhci_recovery_start(). It would be good if ->post_disable() users could check if this needs attention. Changes in V2: mmc: cqhci: Fix task clearing in CQE error recovery New patch mmc: cqhci: Warn of halt or task clear failure Add fixes and stable tags Adrian Hunter (6): mmc: block: Do not lose cache flush during CQE error recovery mmc: cqhci: Increase recovery halt timeout mmc: block: Be sure to wait while busy in CQE error recovery mmc: block: Retry commands in CQE error recovery mmc: cqhci: Warn of halt or task clear failure mmc: cqhci: Fix task clearing in CQE error recovery drivers/mmc/core/block.c | 2 ++ drivers/mmc/core/core.c | 9 +++++++-- drivers/mmc/host/cqhci-core.c | 44 +++++++++++++++++++++---------------------- 3 files changed, 31 insertions(+), 24 deletions(-) Regards Adrian