From patchwork Fri Nov 3 06:15:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 16205 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp830800vqu; Thu, 2 Nov 2023 23:16:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEdoc+9r+IonEPJ5u6PUCDtkzvQlzK/bs1DYa3VMxioXJOv0TvwxusagTKWLLB/kjxBUBxq X-Received: by 2002:a17:90a:f0d8:b0:274:4e9b:7a1a with SMTP id fa24-20020a17090af0d800b002744e9b7a1amr17057755pjb.44.1698992183095; Thu, 02 Nov 2023 23:16:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698992183; cv=none; d=google.com; s=arc-20160816; b=I5F4Gs8+zDblTRjk/7XaBnyGVhGXu/0sChmz1dTvQFavXGUpfJiFE8R92aN5xC36mt PtHMmSm1LJxhxFmyeaRqTKgNSI7wRZvG8MtSqLswxfHh0+pFjgm2zq1dSCKxkB5NqwSH kDxq7vvPt+UFL860LFmX4Uf8WRgmK+ZtnLFs58fx+txBU46VR0Q9gXj5oih1bMVJvYMM ocL9TT+D2h7FYCciYH9EZA2rk9OdvUpRJjuWsiuKiSD1s2FVUfFWp/uZTOQsoBdLe4x1 qSfaoCNyNXfwjuF9ZckQlfspCqRu3xmKA3I2gU8AR2tuQQCSjmIg7Ml1rkkrcj/GWgxg ZJww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9uBDHUEXTjz3mCrbNalyoZITY3Ldzz/4xXHCv3UN9mU=; fh=J5fZGSGUmoD0NT+ZfFkgng7qPhvONoMGdVOrNctU85A=; b=hYqbrLdMVI8SEOxQ19aLn9/gH+P2EPt/96iDcH5XVMP6MeNGms+rIGWscOYWrqrdda 35gJDISbLB/lKNmyftSxzGqG2L9tIW9vvcbMnqyb3fLfYMAZU35sJQoWF+QBrlFT9Y8q 9oj4dZkwUMWOxyg+qPmM0OYZguK96G3UbGQ9yLY/41z9zeF2EWrIlKKnBNljI4gY0d0T nSE5UVVv2Wd32Nd8fj6JVDPB09EsCzX0JkmUidJB3rnFvKifXL641vEwJQw5MsQStlW3 arRMqypYa6LsTdrz4Xu5wpsjp4BYmF104UFtYk0fLsPawnUDh9k6WJnBJkTwoyoAhLZi i9FQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b=K3v0iWVm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id i13-20020a17090acf8d00b0028072770ee5si1154953pju.37.2023.11.02.23.16.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 23:16:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b=K3v0iWVm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 6A85680254EB; Thu, 2 Nov 2023 23:16:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230163AbjKCGPr (ORCPT + 36 others); Fri, 3 Nov 2023 02:15:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjKCGPq (ORCPT ); Fri, 3 Nov 2023 02:15:46 -0400 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBCAB19D for ; Thu, 2 Nov 2023 23:15:38 -0700 (PDT) Received: from localhost.localdomain (ppp14-2-79-67.adl-apt-pir-bras31.tpg.internode.on.net [14.2.79.67]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id C19172012B; Fri, 3 Nov 2023 14:15:32 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1698992133; bh=9uBDHUEXTjz3mCrbNalyoZITY3Ldzz/4xXHCv3UN9mU=; h=From:To:Cc:Subject:Date; b=K3v0iWVmX+gSRJXB26gV0dszp3ioYxD5gBAE+cy0+zwC19GLqz5VDol6j+LnRWD/n YlbCEQrNWQN0SuaRaBwed6fHcStypW1bRb1J5pA4+cYL1rNc81JTR/TOdhXKCgV9cH JCcmbNitu6A2AfDnryd/i7/T8L+yvIV9cGbS+pZ4huMCvTKQs6bQyEh46wLbkHJfKJ LoPky8QxVqefzGZ6H1xvZDjkFphmhWY8lgBQB/EO2QrUj67tLxqv61zXVxebNbbd/+ 3IzR6MAn0UL7VzICnVUuBls2Ad46YaJMPOzd7jeC7kVzBuuyWZhoDPp0Hvdzo/njEH SjtXB2PUMmd9Q== From: Andrew Jeffery To: minyard@acm.org, openipmi-developer@lists.sourceforge.net Cc: Andrew Jeffery , linux-kernel@vger.kernel.org, Jonathan.Cameron@Huawei.com, aladyshev22@gmail.com, jk@codeconstruct.com.au Subject: [PATCH 00/10] ipmi: kcs_bmc: Miscellaneous cleanups Date: Fri, 3 Nov 2023 16:45:12 +1030 Message-Id: <20231103061522.1268637-1-andrew@codeconstruct.com.au> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 02 Nov 2023 23:16:04 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781522427379330062 X-GMAIL-MSGID: 1781522427379330062 Hello, A cleanup of the KCS subsystem was prompted after some concerns raised by Jonathan on Konstantin's series implementing DSP0254[1] (the MCTP KCS Transport Binding Specification): https://lore.kernel.org/all/20230929120835.0000108e@Huawei.com/ [1]: https://www.dmtf.org/sites/default/files/standards/documents/DSP0254_1.0.0.pdf The MCTP KCS patches are currently at v5: https://lore.kernel.org/all/20231010122321.823-1-aladyshev22@gmail.com/ A v6 will be necessary to rework them in terms of the cleanup done here. I've pushed a preview of that work here: https://github.com/amboar/linux/compare/d2cc82b50335c8fcf83e1d8f396c8f8cf4333ac4...mctp-kcs In addition to addressing some of the resource lifetime concerns I've added kerneldoc for the subsystem in anticipation of Konstantin's series moving the headers to include/linux/. To get Konstantin's work merged I expect we'll have to either take these KCS patches through netdev or the MCTP patches through the IPMI tree. We should figure out which way we want to go, but netdev's not open right now and so that's not a pressing concern. Please review! Thanks, Andrew Andrew Jeffery (10): ipmi: kcs_bmc: Update module description ipmi: kcs_bmc: Include spinlock.h ipmi: kcs_bmc: Make kcs_bmc_update_event_mask() static ipmi: kcs_bmc: Make remove_device() callback return void ipmi: kcs_bmc: Define client actions in terms of kcs_bmc_client ipmi: kcs_bmc: Integrate buffers into driver struct ipmi: kcs_bmc: Disassociate client from device lifetimes ipmi: kcs_bmc: Track clients in core ipmi: kcs_bmc: Add module_kcs_bmc_driver() ipmi: kcs_bmc: Add subsystem kerneldoc drivers/char/ipmi/kcs_bmc.c | 160 +++++++++++--------- drivers/char/ipmi/kcs_bmc.h | 41 +++++ drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 152 +++++++------------ drivers/char/ipmi/kcs_bmc_client.h | 206 +++++++++++++++++++++++--- drivers/char/ipmi/kcs_bmc_device.h | 44 +++++- drivers/char/ipmi/kcs_bmc_serio.c | 84 ++++------- 6 files changed, 448 insertions(+), 239 deletions(-)