From patchwork Wed Nov 1 07:38:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Adrian Hunter X-Patchwork-Id: 16131 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:abcd:0:b0:403:3b70:6f57 with SMTP id f13csp244096vqx; Wed, 1 Nov 2023 00:38:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHu+6zB/x6aszqA8QQpSpeu6aqZLGHOM//SFQgdGbD4YKm9AvOJPoOOialJFbrZDiVUi9S3 X-Received: by 2002:a05:6830:1351:b0:6c6:1c54:a1b7 with SMTP id r17-20020a056830135100b006c61c54a1b7mr15772376otq.24.1698824332778; Wed, 01 Nov 2023 00:38:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698824332; cv=none; d=google.com; s=arc-20160816; b=TlnAeuu4lNdG/PLPSUkcTv9D5/Z10EiXjWKrBoL3IE7Kk2ftv0c+OODI/+574rHGMK wMhndTT1OTVIpyNFEvTFsIUpKthbY7IPrdYjkDoX4Rdxs+UCeN5BH6M0pbJlQ1nxJjz+ p42nYBuRSy1z48d6pSWTLWPFnKmqqgjhpsk6WVqBKO42WwGKmCMPUDb6UJbG1Pp6uMQO nol0+2q0EOLmo8vYG4p2PrkG9Z5MCwrGh4ay/NxkygL2N61YJl0pPOw8pKnYihpg5y63 sIlXZ+qMxVqbS779/XECU26Xp8W4/7Q/usVc4TP9bKqSvw0JSVPAAASW54q/wvwvevyd Qscg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:organization :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=D8V5fNo/Okh13nkLESilka9eLiVabMI4CV476t4F2zw=; fh=B/ymYvz68TmAYsy3osQThBsQqGybcLhrtzuZ248faME=; b=DmGA9H1j5G5yRC5cF30QJtlSP8ev01gl6fkgj1lALc6YLMPRE5K9qXfC9PXx58b/Bk jqrZQtXTzZYAZLf7J+AaSoTtAh9bsLhRcUXGReUZZv6DbeBogtt/SQ8lMcLDkb+MdB20 +FcNrO116JfbgDnRQl02UM2RHM9XJS0dFsdMkp1khYdF5lbhObU/aO85ZB3aUBrkuwki Zs7Dl/BIuxzQJEYx5EtMGK6Edzd/8RaP5i+/BVmBhycBInLRBRSOe+I239e6GEgbqPXB tjaFkyeWJ6uqxU8dA6LcEUPPrG96GA8ClS38DEkW89tMcXtYrIgt2KUCNEt14Ylmvey7 DLcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JkO9uUKI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id s22-20020a056a00195600b006c0fe935fa1si1147196pfk.181.2023.11.01.00.38.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 00:38:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JkO9uUKI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 4D4AC80A7E57; Wed, 1 Nov 2023 00:38:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231251AbjKAHiu (ORCPT + 35 others); Wed, 1 Nov 2023 03:38:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231169AbjKAHit (ORCPT ); Wed, 1 Nov 2023 03:38:49 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDB17E4; Wed, 1 Nov 2023 00:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698824324; x=1730360324; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=KagOix17M6bQzQZUD36jEg+Kj080AKQxOTN/L7teNfM=; b=JkO9uUKI4kcVJGjZEajLuDkkolxfNn995ubZ6NgicQOSRir4LnWl/Ha8 rnuE2wvmIvcRKoskaJjsjUo2y8L2mtqOLWrz3Tjq05zTmbxy2D2xWhWMe k9/UBBv/TIZ+w8QQFNd8O8h4OuJpk1nMZTcgszH/iLnLVR8egYjAXeOC2 YyZWLopYGKrE/QC/Q9r20xp1PfeS5fLjot4k2pdTKeQTYeHwjdTgb7lVD qh8bGUROFh13xHhZ4tnQ6qtTsueGWXqZ887plU07JPASK7SMfn1/64hJA N6UCfjo7K4/WAWL4BFSyLlqNM8WomdsuB6JIwRC8y+oyjFu2fsxBd3q33 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="9982612" X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="9982612" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 00:38:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="934357503" X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="934357503" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO ahunter-VirtualBox.home\044ger.corp.intel.com) ([10.252.34.17]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 00:38:37 -0700 From: Adrian Hunter To: Ulf Hansson , =?utf-8?q?Kornel_Dul=C4=99ba?= , Radoslaw Biernacki , Gwendal Grignou , Ritesh Harjani , Asutosh Das Cc: Chaotian Jing , Aswath Govindraju , Bhavya Kapoor , Kamal Dasu , Al Cooper , Haibo Chen , Bhupesh Sharma , Shaik Sajida Bhanu , Sai Krishna Potthuri , Swati Agarwal , Victor Shih , Ben Chuang , Thierry Reding , Aniruddha Tvs Rao , Chun-Hung Wu , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/5] mmc: block: Fixes for CQE error recovery recovery Date: Wed, 1 Nov 2023 09:38:22 +0200 Message-Id: <20231101073827.4772-1-adrian.hunter@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 01 Nov 2023 00:38:51 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781346423430627801 X-GMAIL-MSGID: 1781346423430627801 Hi Some issues have been found with CQE error recovery. Here are some fixes. There is also a patch from Kornel Dulęba: https://lore.kernel.org/linux-mmc/e7c12e07-7540-47ea-8891-2cec73d58df1@intel.com/T/#u which is still under review. Please also note ->post_disable() seems to be missing from cqhci_recovery_start(). It would be good if ->post_disable() users could check if this needs attention. Adrian Hunter (5): mmc: block: Do not lose cache flush during CQE error recovery mmc: cqhci: Increase recovery halt timeout mmc: block: Be sure to wait while busy in CQE error recovery mmc: block: Retry commands in CQE error recovery mmc: cqhci: Warn of halt or task clear failure drivers/mmc/core/block.c | 2 ++ drivers/mmc/core/core.c | 9 +++++++-- drivers/mmc/host/cqhci-core.c | 12 ++++++------ 3 files changed, 15 insertions(+), 8 deletions(-) Regards Adrian