mbox series

[0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

Message ID 20231031-tc358767-v1-0-392081ad9f4b@ideasonboard.com
Headers
Series drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case |

Message

Tomi Valkeinen Oct. 31, 2023, 1:26 p.m. UTC 
  These two patches are needed to make tc358767 work in the
DRM_BRIDGE_ATTACH_NO_CONNECTOR case, at least when using a DP connector.
The first patch, "drm/bridge: tc358767: Support input format negotiation
hook" was already sent separately, but I included it here for
completeness, as both are needed to get a working display.

I have tested this with TI AM654 EVM with a tc358767 add-on card.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
Aradhya Bhatia (1):
      drm/bridge: tc358767: Support input format negotiation hook

Tomi Valkeinen (1):
      drm/bridge: tc358767: Fix link properties discovery

 drivers/gpu/drm/bridge/tc358767.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
---
base-commit: 79d94360d50fcd487edcfe118a47a2881534923f
change-id: 20231031-tc358767-58e3ebdf95f0

Best regards,

Comments

Jan Kiszka Oct. 31, 2023, 5:59 p.m. UTC | #1 
On 31.10.23 14:26, Tomi Valkeinen wrote:
> These two patches are needed to make tc358767 work in the
> DRM_BRIDGE_ATTACH_NO_CONNECTOR case, at least when using a DP connector.
> The first patch, "drm/bridge: tc358767: Support input format negotiation
> hook" was already sent separately, but I included it here for
> completeness, as both are needed to get a working display.
> 
> I have tested this with TI AM654 EVM with a tc358767 add-on card.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
> Aradhya Bhatia (1):
>       drm/bridge: tc358767: Support input format negotiation hook
> 
> Tomi Valkeinen (1):
>       drm/bridge: tc358767: Fix link properties discovery
> 
>  drivers/gpu/drm/bridge/tc358767.c | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> ---
> base-commit: 79d94360d50fcd487edcfe118a47a2881534923f
> change-id: 20231031-tc358767-58e3ebdf95f0
> 
> Best regards,

Tested-by: Jan Kiszka <jan.kiszka@siemens.com>

Would be good to have that in stable for 6.6 as well then.

Thanks,
Jan
Jan Kiszka Dec. 15, 2023, 1:33 p.m. UTC | #2 
On 31.10.23 14:26, Tomi Valkeinen wrote:
> These two patches are needed to make tc358767 work in the
> DRM_BRIDGE_ATTACH_NO_CONNECTOR case, at least when using a DP connector.
> The first patch, "drm/bridge: tc358767: Support input format negotiation
> hook" was already sent separately, but I included it here for
> completeness, as both are needed to get a working display.
> 
> I have tested this with TI AM654 EVM with a tc358767 add-on card.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
> Aradhya Bhatia (1):
>       drm/bridge: tc358767: Support input format negotiation hook
> 
> Tomi Valkeinen (1):
>       drm/bridge: tc358767: Fix link properties discovery
> 
>  drivers/gpu/drm/bridge/tc358767.c | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> ---
> base-commit: 79d94360d50fcd487edcfe118a47a2881534923f
> change-id: 20231031-tc358767-58e3ebdf95f0
> 
> Best regards,

What's the plan for these fixes? I'm not yet seeing them in Linus' tree,
thus also not in stable.

Jan
Tomi Valkeinen Dec. 19, 2023, 10 a.m. UTC | #3 
On 15/12/2023 15:33, Jan Kiszka wrote:
> On 31.10.23 14:26, Tomi Valkeinen wrote:
>> These two patches are needed to make tc358767 work in the
>> DRM_BRIDGE_ATTACH_NO_CONNECTOR case, at least when using a DP connector.
>> The first patch, "drm/bridge: tc358767: Support input format negotiation
>> hook" was already sent separately, but I included it here for
>> completeness, as both are needed to get a working display.
>>
>> I have tested this with TI AM654 EVM with a tc358767 add-on card.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>> ---
>> Aradhya Bhatia (1):
>>        drm/bridge: tc358767: Support input format negotiation hook
>>
>> Tomi Valkeinen (1):
>>        drm/bridge: tc358767: Fix link properties discovery
>>
>>   drivers/gpu/drm/bridge/tc358767.c | 32 ++++++++++++++++++++++++++++++++
>>   1 file changed, 32 insertions(+)
>> ---
>> base-commit: 79d94360d50fcd487edcfe118a47a2881534923f
>> change-id: 20231031-tc358767-58e3ebdf95f0
>>
>> Best regards,
> 
> What's the plan for these fixes? I'm not yet seeing them in Linus' tree,
> thus also not in stable.
> 
> Jan
> 

The discussion continued in v2 of the series. There are some open 
question in the tc358767 behavior.

  Tomi