mbox series

[v8,0/5] leds: Allwinner A100 LED controller support

Message ID 20231029212738.7871-1-samuel@sholland.org
Headers
Series leds: Allwinner A100 LED controller support |

Message

Samuel Holland Oct. 29, 2023, 9:26 p.m. UTC 
  This series adds bindings and a driver for the RGB LED controller found
in some Allwinner SoCs, starting with A100. The hardware in the R329 and
D1 SoCs appears to be identical.

This series was tested on the Nezha board (one onboard LED) and the
Dongshan Nezha STU board (with an external strip of 16/32/48 LEDs, also
with gaps in the LED addresses).

Changes in v8:
 - Remove redundant "Bindings" from the binding document title
 - Make the DMA channel optional; the driver now works without DMA
 - Fix spelling in the Kconfig description
 - Fix the file header comment style
 - Wrap to 100 columns instead of 80
 - Use GENMASK for register bit fields
 - Use FIELD_PREP for setting all multiple-bit register fields
 - Add and use the LEDC_CHANNELS_PER_LED macro
 - Make length and offset variables unsigned to avoid mixed signedness
 - Add __counted_by for sun50i_a100_ledc::leds
 - Move the new/existing xfer logic out of sun50i_a100_ledc_pio_xfer()
 - Get the FIFO usage from INT_STS instead of assuming it is half full
 - Make the DMA channel optional; always use PIO if it is unavailable
 - Set up DMA before triggering the LEDC transfer to avoid underrun
 - Correctly enable/disable the DRQ for each transfer
 - Use more descriptive names for variables containing register values
 - Add blank lines and comments to improve readability
 - Add a comment explaining the write to the status register
 - Remove unnecessary debugging prints
 - Use the more-idiomatic post-increment operator in for loops
 - Allow gaps in child node 'reg' values (separate max_addr/num_leds)
 - Use device-managed allocation for the DMA buffer
 - Unregister LEDs before shutting down the controller to correctly
   respect LED_RETAIN_AT_SHUTDOWN (or lack thereof)
 - Use the .remove_new platform driver hook
 - Collected tags, except Tested-by for the driver due to large changes

Changes in v7:
 - Use DEFINE_SIMPLE_DEV_PM_OPS

Changes in v6:
 - Drop the A100 DMA controller DT node patch, which was merged via a
   different series

Changes in v5:
 - A100 contains the original implementation, so use that as the base
   compatible string, and rename the binding to match
 - Add "unevaluatedProperties: false" to the child multi-led binding
 - Rename the driver R329 -> A100, since that is the actual original
   implementation

Changes in v4:
 - Use "default" instead of "maxItems" for timing properties
 - Depend on LEDS_CLASS_MULTICOLOR

Changes in v3:
 - Removed quotes from enumeration values
 - Added vendor prefix to timing/format properties
 - Renamed "format" property to "pixel-format" for clarity
 - Dropped "vled-supply" as it is unrelated to the controller hardware
 - Added vendor prefix to timing/format properties
 - Renamed "format" property to "pixel-format" for clarity
 - Dropped "vled-supply" as it is unrelated to the controller hardware
 - Changed "writesl" to "iowrite32_rep" so the driver builds on hppa

Changes in v2:
 - Fixed typo leading to duplicate t1h-ns property
 - Removed "items" layer in definition of dmas/dma-names
 - Replaced uint32 type reference with maxItems in timing properties
 - Renamed from sunxi-ledc to sun50i-r329-ledc
 - Added missing "static" to functions/globals as reported by 0day bot

Samuel Holland (5):
  dt-bindings: leds: Add Allwinner A100 LED controller
  leds: sun50i-a100: New driver for the A100 LED controller
  arm64: dts: allwinner: a100: Add LED controller node
  riscv: dts: allwinner: d1: Add LED controller node
  riscv: dts: allwinner: d1: Add RGB LEDs to boards

 .../leds/allwinner,sun50i-a100-ledc.yaml      | 137 +++++
 .../arm64/boot/dts/allwinner/sun50i-a100.dtsi |  14 +
 .../allwinner/sun20i-d1-lichee-rv-dock.dts    |  12 +
 .../boot/dts/allwinner/sun20i-d1-nezha.dts    |  13 +
 arch/riscv/boot/dts/allwinner/sun20i-d1.dtsi  |   6 +
 .../boot/dts/allwinner/sunxi-d1s-t113.dtsi    |  15 +
 drivers/leds/Kconfig                          |   9 +
 drivers/leds/Makefile                         |   1 +
 drivers/leds/leds-sun50i-a100.c               | 580 ++++++++++++++++++
 9 files changed, 787 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/allwinner,sun50i-a100-ledc.yaml
 create mode 100644 drivers/leds/leds-sun50i-a100.c

Comments

Lee Jones Nov. 23, 2023, 10:55 a.m. UTC | #1 
On Sun, 29 Oct 2023 16:26:54 -0500, Samuel Holland wrote:
> This series adds bindings and a driver for the RGB LED controller found
> in some Allwinner SoCs, starting with A100. The hardware in the R329 and
> D1 SoCs appears to be identical.
> 
> This series was tested on the Nezha board (one onboard LED) and the
> Dongshan Nezha STU board (with an external strip of 16/32/48 LEDs, also
> with gaps in the LED addresses).
> 
> [...]

Applied, thanks!

[1/5] dt-bindings: leds: Add Allwinner A100 LED controller
      commit: 57ef666e1586823adc1b7909ed3472dec117df1f
[2/5] leds: sun50i-a100: New driver for the A100 LED controller
      commit: 090a25ad97983720f52b11d9c5a8d1a446217c1d

--
Lee Jones [李琼斯]