Message ID | 20231027121639.2382565-1-srasheed@marvell.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp557382vqb; Fri, 27 Oct 2023 05:17:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHb2ljvV4MSYUxTcYfiMULGkwR6cOMnwbZZ6T09RZPak4NkBNZVWEvZ+hHOd4r9Q3BzRhER X-Received: by 2002:a9d:62d6:0:b0:6b9:c7de:68e0 with SMTP id z22-20020a9d62d6000000b006b9c7de68e0mr2256602otk.29.1698409050938; Fri, 27 Oct 2023 05:17:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698409050; cv=none; d=google.com; s=arc-20160816; b=zeBFzmn5H5XWaQWaDllTplTCz/+c177mN77OUUhe3rt6A2lfgpoRJpnkgMP9HoHQ9Y PG3vk4b1dGWKPZUk197CfF1rgvJ+dRBfyzXQANmU3IDH9ql/hWHkG5109t1ePcLMeCp1 nfRNJ/PYcfXQA/vnaXqmAg6tmP2z7auTYzg7q9n/iIhIRWB63D0yZbqzc2ZBiU32xR/i 6/co5IahsGllyPhrCKTvYIs4qfIar4DeC4jCKLbEFYm/llbauea8PvTjLKCcdWYEVpWp 0QC388pUl5dGqjgEFI/SzIMM4TVROmMm4uk0hck/cf2/MhMXnfmP7s3roG6+P7EF/HC+ naew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Y6xTKIJSNSycWXwHzIPirKaKql9lBW7UOSjD7UTcWio=; fh=gNr59YhJeSqFpzAl5yMorJ8nj6h+jiBYcBCAuclPfFg=; b=TCDkTRz7FFnrQDFGyctCEg9KlcSaPbnhhbCfUpbcREkLxnD8XpBY2GnBCPj+EFiAkx KlLpD7NsW830+Eq1k/tohe0J946hX3m85vIBRAcjIAz8it5t3XZbpMdBKYmir06nqoTS JDIl+nl9NwrI5ZPsZR082x2WdYkpQqLofJw2LOTYIJe13qebgttyZNxgaadUGP1bbNoF /CMn4cB/EE95eTJLGJ9ycDkipDMHZ4/33Kd/AqfacZxFhsQiek6M5XxE/OcTPsIcUrhG ckcYHeImNPdRWI7w3X6S2kWzqFK+DiX3fDMvYBkBIdqrSDszt5eWoMqjjdw6Szuig/2/ 5Sxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=B9FACaBg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id d188-20020a0df4c5000000b0059ea3308a16si2161449ywf.496.2023.10.27.05.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 05:17:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=B9FACaBg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 98C458456522; Fri, 27 Oct 2023 05:17:20 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345789AbjJ0MQ7 (ORCPT <rfc822;a1648639935@gmail.com> + 25 others); Fri, 27 Oct 2023 08:16:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231386AbjJ0MQ6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 27 Oct 2023 08:16:58 -0400 Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AB83128; Fri, 27 Oct 2023 05:16:56 -0700 (PDT) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39R5Tuq9012500; Fri, 27 Oct 2023 05:16:51 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=Y6xTKIJSNSycWXwHzIPirKaKql9lBW7UOSjD7UTcWio=; b=B9FACaBgUcdszqiQz669apVjPGmlM37xLlA+cBhM0d4jWa1Zzsp477VTzwa5AGrM4v7x SWSTQanuFQObOznb/wZbZm6wkPpN0WmRfpUy0pRJOqMhhmamLx/DJjBSoXvLvBVzg8If aD7Fra67U5OrucLUuCxiBr8uT+f03Jm8VDGizkwcfkU8mWAAFkwraFJZzAXFz4f0OlaD VHxYHXiPuYa9GiqoYkbE5e4aDD4B4TOVCTNvnAauTnF7ZJRvBB37x65wVmc8ydcUVTm7 XvpUHRwDDmSX62odFEBNbphLSHJpBL3/Lg10lRQc3fkIw5ISpNLRbEhLRlnrpqsQdxlK Aw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3tywr83b23-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 27 Oct 2023 05:16:51 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Fri, 27 Oct 2023 05:16:49 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Fri, 27 Oct 2023 05:16:49 -0700 Received: from ubuntu-PowerEdge-T110-II.sclab.marvell.com (unknown [10.106.27.86]) by maili.marvell.com (Postfix) with ESMTP id 597073F7050; Fri, 27 Oct 2023 05:16:49 -0700 (PDT) From: Shinas Rasheed <srasheed@marvell.com> To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org> CC: <hgani@marvell.com>, <vimleshk@marvell.com>, <egallen@redhat.com>, <mschmidt@redhat.com>, <pabeni@redhat.com>, <horms@kernel.org>, <kuba@kernel.org>, <davem@davemloft.net>, <wizhao@redhat.com>, <konguyen@redhat.com>, Shinas Rasheed <srasheed@marvell.com> Subject: [PATCH net-next v3 0/4] Cleanup and optimizations to transmit code Date: Fri, 27 Oct 2023 05:16:35 -0700 Message-ID: <20231027121639.2382565-1-srasheed@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: Gg8ZBtEi-m6sgKEgmOSJILCTcSgEbTCb X-Proofpoint-ORIG-GUID: Gg8ZBtEi-m6sgKEgmOSJILCTcSgEbTCb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-27_10,2023-10-27_01,2023-05-22_02 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 27 Oct 2023 05:17:20 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780910968730047501 X-GMAIL-MSGID: 1780910968730047501 |
Series |
Cleanup and optimizations to transmit code
|
|
Message
Shinas Rasheed
Oct. 27, 2023, 12:16 p.m. UTC
Pad small packets to ETH_ZLEN before transmit, cleanup dma sync calls, add xmit_more functionality and then further remove atomic variable usage in the prior. Changes: V3: - Stop returning NETDEV_TX_BUSY when ring is full in xmit_patch. Change to inspect early if next packet can fit in ring instead of current packet, and stop queue if not. - Add smp_mb between stopping tx queue and checking if tx queue has free entries again, in queue full check function to let reflect IQ process completions that might have happened on other cpus. - Update small packet padding patch changelog to give more info. V2: https://lore.kernel.org/all/20231024145119.2366588-1-srasheed@marvell.com/ - Added patch for padding small packets to ETH_ZLEN, part of optimization patches for transmit code missed out in V1 - Updated changelog to provide more details for dma_sync remove patch - Updated changelog to use imperative tone in add xmit_more patch V1: https://lore.kernel.org/all/20231023114449.2362147-1-srasheed@marvell.com/ Shinas Rasheed (4): octeon_ep: add padding for small packets octeon_ep: remove dma sync in trasmit path octeon_ep: implement xmit_more in transmit octeon_ep: remove atomic variable usage in Tx data path .../ethernet/marvell/octeon_ep/octep_config.h | 3 +- .../ethernet/marvell/octeon_ep/octep_main.c | 55 +++++++++++-------- .../ethernet/marvell/octeon_ep/octep_main.h | 9 +++ .../net/ethernet/marvell/octeon_ep/octep_tx.c | 5 +- .../net/ethernet/marvell/octeon_ep/octep_tx.h | 3 - 5 files changed, 45 insertions(+), 30 deletions(-)
Comments
On Fri, 27 Oct 2023 05:16:35 -0700 Shinas Rasheed wrote: > Pad small packets to ETH_ZLEN before transmit, cleanup dma sync calls, > add xmit_more functionality and then further remove atomic > variable usage in the prior. ## Form letter - net-next-closed The merge window for v6.7 has begun and we have already posted our pull request. Therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after Nov 12th. RFC patches sent for review only are obviously welcome at any time. See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle