Message ID | 20231025192225.468228-1-lukasz.luba@arm.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp183851vqb; Wed, 25 Oct 2023 12:22:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEFgC5ayleLfh3s3Rm+kVw8DwFgFWM248T9dDrIlz/J/fguT+86Ma28MGGLz+YjSjAV+u8M X-Received: by 2002:a25:bcc6:0:b0:d9a:d8bd:7b9c with SMTP id l6-20020a25bcc6000000b00d9ad8bd7b9cmr1055423ybm.11.1698261753239; Wed, 25 Oct 2023 12:22:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698261753; cv=none; d=google.com; s=arc-20160816; b=v52KfO8EfS+Fi0qimS+8SpDUfF9AAmn6PI3YZR+U5KrY5ezj3Xo9db/+uwm3MBwB7s X4kDROHcK64HznUmpB5y9hrCNjbJC2qxa1tAGc1QUdTguMXRcawJnJeVNCU7nzRha5Xz G8MNFbILR4esv+CA2+RUzmMd3xPOYBet9b6zxTtVAvFVeGOX0MXfM1icVQ0SDB0HEMwp RpkHOfNIqNzAewjaAFGr+5ifHIUJrB7QhtTkpekxIZVAQHbcT3ZbUBVGtDkD8YEnmmsb updgTiBNOMZOokDNTe21STzEIUGK7wDS+oEnrx9JB+PZ0zeYYu+mMgWdHdAUyrRC/JUk b69A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=gAkESoVHIKAZFBYDsL+MiPH7e6pVgviB3JwFsLJ+DAo=; fh=8IgpUQ2T6XGOjA/qDosxdUSIIBz0a6nQ23NA8pgv1Tg=; b=z4epZG0Ls2IUWB+sMSO6L/LhmCK+TLya2OuQKX8Nk70Q7i1p4sPmd7gNNvzJ1C/ioY ES+PKtL3BdNCtpvVGzHGodu3C29qoaE7LC6Kv88TEzBMspFCf3VgOZHeuYuv2iOydPlK YE2k+yMByZO0wvkbkJs4X7opRSDwMuBoOUKxjlrIJXU/fHUU0NBhCFyDgFg3pn9RkrTN o/N1zHaRQkbbJumPlgGoqHtve2SKuMvL/lmoAiHxkX8FwUiolDatemaUI5Xt81nGRnt3 RPuvV0KmBVv5XqCxKwnpClrBu7gM1+aMq3IsSaMiFUgBrVhzIiizb1I0cRbW4+7s+4Uu pAwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id 187-20020a2503c4000000b00da05f6bc29fsi3811648ybd.509.2023.10.25.12.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 12:22:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id D60F5816EBF5; Wed, 25 Oct 2023 12:22:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229632AbjJYTVp (ORCPT <rfc822;a1648639935@gmail.com> + 25 others); Wed, 25 Oct 2023 15:21:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjJYTVo (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 25 Oct 2023 15:21:44 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 48D4213A; Wed, 25 Oct 2023 12:21:41 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 904C92F4; Wed, 25 Oct 2023 12:22:22 -0700 (PDT) Received: from e129166.arm.com (unknown [10.57.81.88]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B0F103F738; Wed, 25 Oct 2023 12:21:39 -0700 (PDT) From: Lukasz Luba <lukasz.luba@arm.com> To: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org Cc: linux-pm@vger.kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com Subject: [PATCH 0/7] Minor cleanup for thermal gov power allocator Date: Wed, 25 Oct 2023 20:22:18 +0100 Message-Id: <20231025192225.468228-1-lukasz.luba@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 25 Oct 2023 12:22:00 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780756515773323015 X-GMAIL-MSGID: 1780756515773323015 |
Series |
Minor cleanup for thermal gov power allocator
|
|
Message
Lukasz Luba
Oct. 25, 2023, 7:22 p.m. UTC
Hi all, The patch set does some small clean up for Intelligent Power Allocator. Those changes are not expected to alter the general functionality. They just improve the code reading. Only patch 3/7 might improve the use case for binding the governor to thermal zone (very unlikely in real products, but it's needed for correctness). The changes are based on top of current PM thermal branch, so with the new trip points. Regards, Lukasz Lukasz Luba (7): thermal: gov_power_allocator: Rename trip_max_desired_temperature thermal: gov_power_allocator: Setup trip points earlier thermal: gov_power_allocator: Check the cooling devices only for trip_max thermal: gov_power_allocator: Rearrange the order of variables thermal: gov_power_allocator: Use shorter variable when possible thermal: gov_power_allocator: Remove unneeded local variables thermal: gov_power_allocator: Clean needed variables at the beginning drivers/thermal/gov_power_allocator.c | 123 ++++++++++++++------------ 1 file changed, 64 insertions(+), 59 deletions(-)
Comments
On Wed, Oct 25, 2023 at 9:21 PM Lukasz Luba <lukasz.luba@arm.com> wrote: > > Hi all, > > The patch set does some small clean up for Intelligent Power Allocator. > Those changes are not expected to alter the general functionality. They just > improve the code reading. Only patch 3/7 might improve the use case for > binding the governor to thermal zone (very unlikely in real products, but > it's needed for correctness). > > The changes are based on top of current PM thermal branch, so with the > new trip points. > > Regards, > Lukasz > > Lukasz Luba (7): > thermal: gov_power_allocator: Rename trip_max_desired_temperature > thermal: gov_power_allocator: Setup trip points earlier > thermal: gov_power_allocator: Check the cooling devices only for > trip_max > thermal: gov_power_allocator: Rearrange the order of variables > thermal: gov_power_allocator: Use shorter variable when possible > thermal: gov_power_allocator: Remove unneeded local variables > thermal: gov_power_allocator: Clean needed variables at the beginning > > drivers/thermal/gov_power_allocator.c | 123 ++++++++++++++------------ > 1 file changed, 64 insertions(+), 59 deletions(-) > > -- The series looks good to me overall, but I'd prefer to make these changes in the 6.8 cycle, because the 6.7 merge window is around the corner and there is quite a bit of thermal material in this cycle already.
On 10/26/23 09:54, Rafael J. Wysocki wrote: > On Wed, Oct 25, 2023 at 9:21 PM Lukasz Luba <lukasz.luba@arm.com> wrote: >> >> Hi all, >> >> The patch set does some small clean up for Intelligent Power Allocator. >> Those changes are not expected to alter the general functionality. They just >> improve the code reading. Only patch 3/7 might improve the use case for >> binding the governor to thermal zone (very unlikely in real products, but >> it's needed for correctness). >> >> The changes are based on top of current PM thermal branch, so with the >> new trip points. >> >> Regards, >> Lukasz >> >> Lukasz Luba (7): >> thermal: gov_power_allocator: Rename trip_max_desired_temperature >> thermal: gov_power_allocator: Setup trip points earlier >> thermal: gov_power_allocator: Check the cooling devices only for >> trip_max >> thermal: gov_power_allocator: Rearrange the order of variables >> thermal: gov_power_allocator: Use shorter variable when possible >> thermal: gov_power_allocator: Remove unneeded local variables >> thermal: gov_power_allocator: Clean needed variables at the beginning >> >> drivers/thermal/gov_power_allocator.c | 123 ++++++++++++++------------ >> 1 file changed, 64 insertions(+), 59 deletions(-) >> >> -- > > The series looks good to me overall, but I'd prefer to make these > changes in the 6.8 cycle, because the 6.7 merge window is around the > corner and there is quite a bit of thermal material in this cycle > already. Thanks for having a look! Yes, I agree, we can wait after the merge window. It just have to be cleaned one day a bit and I postponed this a few times, so no rush ;)
Hi Rafael, Gentle ping On 10/26/23 13:22, Lukasz Luba wrote: > > > On 10/26/23 09:54, Rafael J. Wysocki wrote: >> On Wed, Oct 25, 2023 at 9:21 PM Lukasz Luba <lukasz.luba@arm.com> wrote: >>> >>> Hi all, >>> >>> The patch set does some small clean up for Intelligent Power Allocator. >>> Those changes are not expected to alter the general functionality. >>> They just >>> improve the code reading. Only patch 3/7 might improve the use case for >>> binding the governor to thermal zone (very unlikely in real products, >>> but >>> it's needed for correctness). >>> >>> The changes are based on top of current PM thermal branch, so with the >>> new trip points. >>> >>> Regards, >>> Lukasz >>> >>> Lukasz Luba (7): >>> thermal: gov_power_allocator: Rename trip_max_desired_temperature >>> thermal: gov_power_allocator: Setup trip points earlier >>> thermal: gov_power_allocator: Check the cooling devices only for >>> trip_max >>> thermal: gov_power_allocator: Rearrange the order of variables >>> thermal: gov_power_allocator: Use shorter variable when possible >>> thermal: gov_power_allocator: Remove unneeded local variables >>> thermal: gov_power_allocator: Clean needed variables at the beginning >>> >>> drivers/thermal/gov_power_allocator.c | 123 ++++++++++++++------------ >>> 1 file changed, 64 insertions(+), 59 deletions(-) >>> >>> -- >> >> The series looks good to me overall, but I'd prefer to make these >> changes in the 6.8 cycle, because the 6.7 merge window is around the >> corner and there is quite a bit of thermal material in this cycle >> already. > > Thanks for having a look! Yes, I agree, we can wait after the > merge window. It just have to be cleaned one day a bit and I postponed > this a few times, so no rush ;) I've seen you've created the new pm/thermal. Could you consider to take those in, please? I would send some RFC on top showing the issue with reading back the CPU max frequency from the PM_QoS chain. Regards, Lukasz
Hi Lukasz, On Thu, Nov 23, 2023 at 4:19 PM Lukasz Luba <lukasz.luba@arm.com> wrote: > > Hi Rafael, > > Gentle ping > > On 10/26/23 13:22, Lukasz Luba wrote: > > > > > > On 10/26/23 09:54, Rafael J. Wysocki wrote: > >> On Wed, Oct 25, 2023 at 9:21 PM Lukasz Luba <lukasz.luba@arm.com> wrote: > >>> > >>> Hi all, > >>> > >>> The patch set does some small clean up for Intelligent Power Allocator. > >>> Those changes are not expected to alter the general functionality. > >>> They just > >>> improve the code reading. Only patch 3/7 might improve the use case for > >>> binding the governor to thermal zone (very unlikely in real products, > >>> but > >>> it's needed for correctness). > >>> > >>> The changes are based on top of current PM thermal branch, so with the > >>> new trip points. > >>> > >>> Regards, > >>> Lukasz > >>> > >>> Lukasz Luba (7): > >>> thermal: gov_power_allocator: Rename trip_max_desired_temperature > >>> thermal: gov_power_allocator: Setup trip points earlier > >>> thermal: gov_power_allocator: Check the cooling devices only for > >>> trip_max > >>> thermal: gov_power_allocator: Rearrange the order of variables > >>> thermal: gov_power_allocator: Use shorter variable when possible > >>> thermal: gov_power_allocator: Remove unneeded local variables > >>> thermal: gov_power_allocator: Clean needed variables at the beginning > >>> > >>> drivers/thermal/gov_power_allocator.c | 123 ++++++++++++++------------ > >>> 1 file changed, 64 insertions(+), 59 deletions(-) > >>> > >>> -- > >> > >> The series looks good to me overall, but I'd prefer to make these > >> changes in the 6.8 cycle, because the 6.7 merge window is around the > >> corner and there is quite a bit of thermal material in this cycle > >> already. > > > > Thanks for having a look! Yes, I agree, we can wait after the > > merge window. It just have to be cleaned one day a bit and I postponed > > this a few times, so no rush ;) > > I've seen you've created the new pm/thermal. Could you consider to take > those in, please? Sure, I'll get to them presumably tomorrow and if not then early next week. > I would send some RFC on top showing the issue with reading back the CPU > max frequency from the PM_QoS chain. Sounds good.
On 11/23/23 19:50, Rafael J. Wysocki wrote: > Hi Lukasz, > > On Thu, Nov 23, 2023 at 4:19 PM Lukasz Luba <lukasz.luba@arm.com> wrote: >> >> Hi Rafael, >> >> Gentle ping >> >> On 10/26/23 13:22, Lukasz Luba wrote: >>> >>> >>> On 10/26/23 09:54, Rafael J. Wysocki wrote: >>>> On Wed, Oct 25, 2023 at 9:21 PM Lukasz Luba <lukasz.luba@arm.com> wrote: >>>>> >>>>> Hi all, >>>>> >>>>> The patch set does some small clean up for Intelligent Power Allocator. >>>>> Those changes are not expected to alter the general functionality. >>>>> They just >>>>> improve the code reading. Only patch 3/7 might improve the use case for >>>>> binding the governor to thermal zone (very unlikely in real products, >>>>> but >>>>> it's needed for correctness). >>>>> >>>>> The changes are based on top of current PM thermal branch, so with the >>>>> new trip points. >>>>> >>>>> Regards, >>>>> Lukasz >>>>> >>>>> Lukasz Luba (7): >>>>> thermal: gov_power_allocator: Rename trip_max_desired_temperature >>>>> thermal: gov_power_allocator: Setup trip points earlier >>>>> thermal: gov_power_allocator: Check the cooling devices only for >>>>> trip_max >>>>> thermal: gov_power_allocator: Rearrange the order of variables >>>>> thermal: gov_power_allocator: Use shorter variable when possible >>>>> thermal: gov_power_allocator: Remove unneeded local variables >>>>> thermal: gov_power_allocator: Clean needed variables at the beginning >>>>> >>>>> drivers/thermal/gov_power_allocator.c | 123 ++++++++++++++------------ >>>>> 1 file changed, 64 insertions(+), 59 deletions(-) >>>>> >>>>> -- >>>> >>>> The series looks good to me overall, but I'd prefer to make these >>>> changes in the 6.8 cycle, because the 6.7 merge window is around the >>>> corner and there is quite a bit of thermal material in this cycle >>>> already. >>> >>> Thanks for having a look! Yes, I agree, we can wait after the >>> merge window. It just have to be cleaned one day a bit and I postponed >>> this a few times, so no rush ;) >> >> I've seen you've created the new pm/thermal. Could you consider to take >> those in, please? > > Sure, I'll get to them presumably tomorrow and if not then early next week. OK, thank you Rafael! > >> I would send some RFC on top showing the issue with reading back the CPU >> max frequency from the PM_QoS chain. > > Sounds good.
On Fri, Nov 24, 2023 at 8:44 AM Lukasz Luba <lukasz.luba@arm.com> wrote: > > > > On 11/23/23 19:50, Rafael J. Wysocki wrote: > > Hi Lukasz, > > > > On Thu, Nov 23, 2023 at 4:19 PM Lukasz Luba <lukasz.luba@arm.com> wrote: > >> > >> Hi Rafael, > >> > >> Gentle ping > >> > >> On 10/26/23 13:22, Lukasz Luba wrote: > >>> > >>> > >>> On 10/26/23 09:54, Rafael J. Wysocki wrote: > >>>> On Wed, Oct 25, 2023 at 9:21 PM Lukasz Luba <lukasz.luba@arm.com> wrote: > >>>>> > >>>>> Hi all, > >>>>> > >>>>> The patch set does some small clean up for Intelligent Power Allocator. > >>>>> Those changes are not expected to alter the general functionality. > >>>>> They just > >>>>> improve the code reading. Only patch 3/7 might improve the use case for > >>>>> binding the governor to thermal zone (very unlikely in real products, > >>>>> but > >>>>> it's needed for correctness). > >>>>> > >>>>> The changes are based on top of current PM thermal branch, so with the > >>>>> new trip points. > >>>>> > >>>>> Regards, > >>>>> Lukasz > >>>>> > >>>>> Lukasz Luba (7): > >>>>> thermal: gov_power_allocator: Rename trip_max_desired_temperature > >>>>> thermal: gov_power_allocator: Setup trip points earlier > >>>>> thermal: gov_power_allocator: Check the cooling devices only for > >>>>> trip_max > >>>>> thermal: gov_power_allocator: Rearrange the order of variables > >>>>> thermal: gov_power_allocator: Use shorter variable when possible > >>>>> thermal: gov_power_allocator: Remove unneeded local variables > >>>>> thermal: gov_power_allocator: Clean needed variables at the beginning > >>>>> > >>>>> drivers/thermal/gov_power_allocator.c | 123 ++++++++++++++------------ > >>>>> 1 file changed, 64 insertions(+), 59 deletions(-) > >>>>> > >>>>> -- > >>>> > >>>> The series looks good to me overall, but I'd prefer to make these > >>>> changes in the 6.8 cycle, because the 6.7 merge window is around the > >>>> corner and there is quite a bit of thermal material in this cycle > >>>> already. > >>> > >>> Thanks for having a look! Yes, I agree, we can wait after the > >>> merge window. It just have to be cleaned one day a bit and I postponed > >>> this a few times, so no rush ;) > >> > >> I've seen you've created the new pm/thermal. Could you consider to take > >> those in, please? > > > > Sure, I'll get to them presumably tomorrow and if not then early next week. > > OK, thank you Rafael! I've queued up the whole lot for 6.8 and in the process I've edited all of the changelogs and some subjects for clarity and English grammar improvements. Thanks!
On 11/28/23 15:17, Rafael J. Wysocki wrote: > On Fri, Nov 24, 2023 at 8:44 AM Lukasz Luba <lukasz.luba@arm.com> wrote: >> >> >> >> On 11/23/23 19:50, Rafael J. Wysocki wrote: >>> Hi Lukasz, >>> >>> On Thu, Nov 23, 2023 at 4:19 PM Lukasz Luba <lukasz.luba@arm.com> wrote: >>>> >>>> Hi Rafael, >>>> >>>> Gentle ping >>>> >>>> On 10/26/23 13:22, Lukasz Luba wrote: >>>>> >>>>> >>>>> On 10/26/23 09:54, Rafael J. Wysocki wrote: >>>>>> On Wed, Oct 25, 2023 at 9:21 PM Lukasz Luba <lukasz.luba@arm.com> wrote: >>>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> The patch set does some small clean up for Intelligent Power Allocator. >>>>>>> Those changes are not expected to alter the general functionality. >>>>>>> They just >>>>>>> improve the code reading. Only patch 3/7 might improve the use case for >>>>>>> binding the governor to thermal zone (very unlikely in real products, >>>>>>> but >>>>>>> it's needed for correctness). >>>>>>> >>>>>>> The changes are based on top of current PM thermal branch, so with the >>>>>>> new trip points. >>>>>>> >>>>>>> Regards, >>>>>>> Lukasz >>>>>>> >>>>>>> Lukasz Luba (7): >>>>>>> thermal: gov_power_allocator: Rename trip_max_desired_temperature >>>>>>> thermal: gov_power_allocator: Setup trip points earlier >>>>>>> thermal: gov_power_allocator: Check the cooling devices only for >>>>>>> trip_max >>>>>>> thermal: gov_power_allocator: Rearrange the order of variables >>>>>>> thermal: gov_power_allocator: Use shorter variable when possible >>>>>>> thermal: gov_power_allocator: Remove unneeded local variables >>>>>>> thermal: gov_power_allocator: Clean needed variables at the beginning >>>>>>> >>>>>>> drivers/thermal/gov_power_allocator.c | 123 ++++++++++++++------------ >>>>>>> 1 file changed, 64 insertions(+), 59 deletions(-) >>>>>>> >>>>>>> -- >>>>>> >>>>>> The series looks good to me overall, but I'd prefer to make these >>>>>> changes in the 6.8 cycle, because the 6.7 merge window is around the >>>>>> corner and there is quite a bit of thermal material in this cycle >>>>>> already. >>>>> >>>>> Thanks for having a look! Yes, I agree, we can wait after the >>>>> merge window. It just have to be cleaned one day a bit and I postponed >>>>> this a few times, so no rush ;) >>>> >>>> I've seen you've created the new pm/thermal. Could you consider to take >>>> those in, please? >>> >>> Sure, I'll get to them presumably tomorrow and if not then early next week. >> >> OK, thank you Rafael! > > I've queued up the whole lot for 6.8 and in the process I've edited > all of the changelogs and some subjects for clarity and English > grammar improvements. Thank you and I really appreciate the improvements!