From patchwork Tue Oct 24 10:19:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nylon Chen X-Patchwork-Id: 15805 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1839972vqx; Tue, 24 Oct 2023 03:19:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFB0ELdjrmEpqFNTYM78GeRSHr2ZDIvaTjB6ZutpNFAUUTo+VftcdepQWgo39jy6sQ7QCHS X-Received: by 2002:a05:6a00:2382:b0:6b1:cc77:4d2 with SMTP id f2-20020a056a00238200b006b1cc7704d2mr14755379pfc.15.1698142770875; Tue, 24 Oct 2023 03:19:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698142770; cv=none; d=google.com; s=arc-20160816; b=vwliF/WwajgCr2tApEGPHXZ1pFLs8ixYg2CU29HX+5PrdzTY/wuIkEQ1GbvhVhlD4t wm1TIzDDhnmc8TiZ++KiMRNhNsLmKfynyJbCfpy0j+Vp3yocUEXurtO2q4WGlSOYg/59 Ul14tlF+1FaTkOw3w73JsA8vthl191Y+VJTaAEcEzKmY0D5q/A4Xu42ZurSULhmx5j8e wsyO3K3pKB/QyCbIhbIhNfV/lkLsdB7ITwv1HtFfGQpNnGeJLl2jzCc5cGP4FiimlJ+0 ruFpgsU91pEUK3on/cXH0pwPHQcEnGdYiDtJVrIWlzy7RYV6GB+PxRk3L8XKiojFnVCS BYiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=oqO6g6+dHIfm5WicwZoijQGJjSQbfYTG3kfOYZFggB8=; fh=vzn9DV0ufbr7wYsjTsRdOZVrIZLib+mpPLCJoIeO9uA=; b=EbsMH8xg/fL0xodxa4ggVyPu8Pd1COahkZMez1lmAnYrmNQxKaMpMeTJLyUQ2PVOlU 9A+wa9vyn5Hsu3detf4iJJhqhkl0cP1l3zq8dbk/PbsDlqsKRDvtaqwRGNh00ynoJvWf 6Fd/asIduigQteOgtC0T0RMmm3TzkPfsTmArfxGRZTk9duv3D7huts39rlLLyfyEN8kt bzSV+xxDfHanh0B5w+5YAlmKZdaz3qWO7n+/PY2RpYnUsHCIyL/ilmxQ0a06T+c/Xc0v IyS23RW846mACh2OEXDFGJ6QsusMURlPbyApVu5LqApxpkND3Skj/UfsV/vHLzFostid mvqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=fqQD3tpa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id fc23-20020a056a002e1700b0068e3f55075esi8436022pfb.134.2023.10.24.03.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 03:19:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=fqQD3tpa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id AB8F680A7CC7; Tue, 24 Oct 2023 03:19:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234186AbjJXKTO (ORCPT + 26 others); Tue, 24 Oct 2023 06:19:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233977AbjJXKTL (ORCPT ); Tue, 24 Oct 2023 06:19:11 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E26AFAC for ; Tue, 24 Oct 2023 03:19:09 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6b7f0170d7bso4081607b3a.2 for ; Tue, 24 Oct 2023 03:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1698142749; x=1698747549; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oqO6g6+dHIfm5WicwZoijQGJjSQbfYTG3kfOYZFggB8=; b=fqQD3tpamQ8xRx16KWqnyhhyesq7hJIuEAK0zDJnYwtVA2f5Ku8l8UB0/eBN31rlMM P2mlG/HptRsniSV/A9XDaWMoG7QsozsNO3R0YYiG3C/XTq2TCYwhVt9zWTBHcK7s+YJr Kbd3NaYuxFyDnO6oo8Q768vVvzwEVOcpimAxn0Aa5oxkUGmaz+LMYMLIiBRyufQw2Ndc xum7MwSsRFJAz1pv0QTx3OTft9FufjPtfzpmMwnsldB/v40z9JMXQzH5Xcn7ql96Bldq m/0kNVJF0ywVIY+5tXtGl3kOVVVSaa/U6zbIvPaFqsmPie62R/XngO8fVS+XHOYD+GbH puhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698142749; x=1698747549; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oqO6g6+dHIfm5WicwZoijQGJjSQbfYTG3kfOYZFggB8=; b=Hc6Ftgjgm/OKdGbRG0qdrv2VcW4rh7mcNMuNzTG3Zwg04JqL4Wi1FdhJAJhS3y0zVl W0M3rDflwo35exUj1gJdjTKK3W2qaKpvfXXTflIxEimsmU+m1rS+OtALcbXbLL+70mx2 9zr2Hm7s53KbGVpcgVngB5C9UeN7NJMvGh+8nf4/vdPMVI7O/YM8IZ1uVHPNbkCWHNb8 B7OFoKnLn2/K7GSOOp09M1bnhuyloc8OVacUraNHZz0lKjqKQ9tya/L49D4jKG6Nfd5U 6IIfqJjSL93qOo/OTssDVK6Rj4nCY07SCZWDRh+5ZTzmobxHpYOv2qMaNxncgHd6CFk5 TmkA== X-Gm-Message-State: AOJu0YzxP7wbjH5Ya4tGfMr+EU8oz41Ijf3EYrbBQV7cyvcHM26AZNOL I78LE/wj186LuGzTmuWTrI/lIQ== X-Received: by 2002:a05:6a20:96d5:b0:17e:4f56:f5be with SMTP id hq21-20020a056a2096d500b0017e4f56f5bemr1810110pzc.22.1698142749323; Tue, 24 Oct 2023 03:19:09 -0700 (PDT) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id u202-20020a6279d3000000b006b3dc56c944sm7708372pfc.133.2023.10.24.03.19.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 03:19:08 -0700 (PDT) From: Nylon Chen To: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, emil.renner.berthing@canonical.com, vincent.chen@sifive.com Cc: nylon.chen@sifive.com, greentime.hu@sifive.com, zong.li@sifive.com, nylon7717@gmail.com Subject: [v5 0/2] Change PWM-controlled LED pin active mode and algorithm Date: Tue, 24 Oct 2023 18:19:00 +0800 Message-ID: <20231024101902.6689-1-nylon.chen@sifive.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 24 Oct 2023 03:19:28 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780631754281516379 X-GMAIL-MSGID: 1780631754281516379 According to the circuit diagram of User LEDs - RGB described in the manual hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1]. The behavior of PWM is acitve-high. According to the descriptionof PWM for pwmcmp in SiFive FU740-C000 Manual[2]. The pwm algorithm is (PW) pulse active time = (D) duty * (T) period. The `frac` variable is pulse "inactive" time so we need to invert it. So this patchset removes active-low in DTS and adds reverse logic to the driver. Updated patches: 1 New patches: 1 Unchanged patches: 1 Links: - [0]: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf - [1]: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf - [2]: https://sifive.cdn.prismic.io/sifive/1a82e600-1f93-4f41-b2d8-86ed8b16acba_fu740-c000-manual-v1p6.pdf Changed in v5: - Add the updates to the PWM algorithm based on version 2 back in. - Replace div64_ul with DIV_ROUND_UP_ULL to correct the error in the period value of the idempotent test in pwm_apply_state_debug. Changed in v4: - Remove previous updates to the PWM algorithm. Changed in v3: - Convert the reference link to standard link. - Move the inverted function before taking the minimum value. - Change polarity check condition(high and low). - Pick the biggest period length possible that is not bigger than the requested period. Changed in v2: - Convert the reference link to standard link. - Fix typo: s/sifive unmatched:/sifive: unmatched:/. - Remove active-low from hifive-unleashed-a00.dts. - Include this reference link in the dts and pwm commit messages. Nylon Chen (2): riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties pwm: sifive: change the PWM controlled LED algorithm arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 8 ++++---- arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++-------- drivers/pwm/pwm-sifive.c | 10 ++++++---- 3 files changed, 14 insertions(+), 16 deletions(-)