| Message ID | 20231024062018.23839-1-raag.jadav@intel.com |
|---|---|
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1747467vqx;
Mon, 23 Oct 2023 23:21:06 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IH2mgqKaoVDw0WJuPUDOkgvXWOLxWBJPIyOf9cBVpGI/TXdgqVBl8rDXx/B+enf28DKFt/d
X-Received: by 2002:a05:6359:7301:b0:168:e452:c163 with SMTP id
ux1-20020a056359730100b00168e452c163mr3788131rwb.17.1698128465822;
Mon, 23 Oct 2023 23:21:05 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1698128465; cv=none;
d=google.com; s=arc-20160816;
b=wyBbhcO6Z1baDkdBC2r/eX/9Fy/2oH5rnHF61Dx6UfH9k+qj8DjAYQvISpG3l4ZNt9
DeEqFAyXGPyb582eljJ8U2Eu9Z23V2lgxWhYtM2xXJ4TmXw9uQjtYUBMQB7ugJIqwu8V
9l/Jr5ENRJLcB7dP9myvDcHE0sh639b536KBSanPAkeeEMqqGSG6o5b7272HxGEJcdkQ
Ce++Th2R/GZPalE8ANRPyVnNPycIKP71XgH27mf6DC5bPqkSM8cvLZntXDHFoLsuVstr
4PrpcgZR6qiGSR743uybWx1bhdFQ1JAkpGWvs/NGv5B33L0bHYCF8oXVehjNE6LVmjje
oN2g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:message-id:date:subject:cc:to:from
:dkim-signature;
bh=VsPyzv+nKGihG894v2k2QhzmzCjsgR1/TB/UQViuNN0=;
fh=jahFJYSZbW5wMNYi6sgvoYqPjA4Ed86fT1kpbcI5rrM=;
b=XienY/0tmZSWhyLslOQRdrBtCqKs9NRCX0hvMhv4dquJck8LdiMHgt1ET8MBLg93hc
W/iEZc3u3b+sO0Go2BNdJuM5YnbauiN5btTo/TCEfnLQtvak+zwLXPV7wh6j/QXqeYyP
pQDub/TL48/MWEG8l+f1IprZ730S+KcrZTxlGzTneJraHX9wF1ssYCafF8KAgdlO9d8a
0948CGz/65zNl1OqCIXztK+aYPxYldOS3hx5bbIeBJ2SIvv2yVWsua0qktvyYm/Wsui7
hfBxGCDMvDu7p6HDripnnwmyjqyFNrZlP8Edap3n0wPpB+9s4tcPYbmuJp4yTF4QLY7H
tq2Q==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=bqHnj0PK;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:3 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3])
by mx.google.com with ESMTPS id
x14-20020aa79ace000000b006b7582b294dsi7775482pfp.129.2023.10.23.23.21.05
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 23 Oct 2023 23:21:05 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:3 as permitted sender)
client-ip=2620:137:e000::3:3;
Authentication-Results: mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=bqHnj0PK;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:3 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by lipwig.vger.email (Postfix) with ESMTP id 70A3A807C5C5;
Mon, 23 Oct 2023 23:20:47 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232607AbjJXGUl (ORCPT <rfc822;aposhian.dev@gmail.com>
+ 27 others); Tue, 24 Oct 2023 02:20:41 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50420 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230017AbjJXGUj (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 24 Oct 2023 02:20:39 -0400
Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C83AAC0;
Mon, 23 Oct 2023 23:20:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1698128437; x=1729664437;
h=from:to:cc:subject:date:message-id;
bh=6u6XekGST951M7tNhGalGj6hn+WiLeARLcL22/cN7BU=;
b=bqHnj0PK9wogBVuKcIpeRjgLuKCpc/iwmJ0vRTDztl/4/mAEJ7bJmb3h
o3rPadjdlzoAq8pBDLESP1JX1sVI+Mh7ogfIAO1CZ0Z1xiCUE1JtJWBCt
TYMMkdjYCpyl0ilAte2xY/huSo8JyQFWWCqnLSVEjncUGEdbuM16O6DUN
28JypIGbcCDR89qTHCxzi/s2dNihKatEK0HdGog4nFvzM7MOxiSWjswF6
Ry819kn/m+t3s0ePgnn5xWkQ7NW3cFz0HoJHpTdpIGjzpKMKCubIO7H/8
YNEOnOV5rwyDApeTdz0oCUhUYxz8ThEXCQGuVm4cb5bDgbc+lHasQrohb
g==;
X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="386806551"
X-IronPort-AV: E=Sophos;i="6.03,246,1694761200";
d="scan'208";a="386806551"
Received: from orsmga007.jf.intel.com ([10.7.209.58])
by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
23 Oct 2023 23:20:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="751891289"
X-IronPort-AV: E=Sophos;i="6.03,246,1694761200";
d="scan'208";a="751891289"
Received: from inlubt0316.iind.intel.com ([10.191.20.213])
by orsmga007.jf.intel.com with ESMTP; 23 Oct 2023 23:20:31 -0700
From: Raag Jadav <raag.jadav@intel.com>
To: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com,
mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com,
mark.rutland@arm.com, will@kernel.org, linux@roeck-us.net,
Jonathan.Cameron@Huawei.com
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com,
Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v3 0/6] Refine _UID references across kernel
Date: Tue, 24 Oct 2023 11:50:12 +0530
Message-Id: <20231024062018.23839-1-raag.jadav@intel.com>
X-Mailer: git-send-email 2.17.1
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]);
Mon, 23 Oct 2023 23:20:47 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1780616753985811031
X-GMAIL-MSGID: 1780616753985811031
|
| Series |
Refine _UID references across kernel
|
|
Message
Raag Jadav
Oct. 24, 2023, 6:20 a.m. UTC
This series refines _UID references across kernel by:
- Extracting _UID matching functionality from acpi_dev_hid_uid_match()
helper and introducing it as a separate acpi_dev_uid_match() helper.
- Converting manual _UID references to use the standard ACPI helpers.
Changes since v2:
- Drop review tags as suggested by Andy.
Changes since v1:
- Change acpi_dev_uid_match() to return false in case of NULL argument.
- Drop accepted patches.
Raag Jadav (6):
ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID
pinctrl: intel: use acpi_dev_uid_match() for matching _UID
ACPI: utils: use acpi_dev_uid_match() for matching _UID
ACPI: x86: use acpi_dev_uid_match() for matching _UID
hwmon: nct6775: use acpi_dev_hid_uid_match() for matching _HID and
_UID
perf: arm_cspmu: use acpi_dev_hid_uid_match() for matching _HID and
_UID
drivers/acpi/utils.c | 34 ++++++++++++++++++++++-----
drivers/acpi/x86/utils.c | 3 +--
drivers/hwmon/nct6775-platform.c | 4 +---
drivers/perf/arm_cspmu/arm_cspmu.c | 8 +++----
drivers/pinctrl/intel/pinctrl-intel.c | 2 +-
include/acpi/acpi_bus.h | 1 +
include/linux/acpi.h | 5 ++++
7 files changed, 40 insertions(+), 17 deletions(-)
base-commit: a4ed5bffbeb19cfb7e21ac3b3f09d7bfe39a849b
Comments
On Tue, Oct 24, 2023 at 11:50:12AM +0530, Raag Jadav wrote: > This series refines _UID references across kernel by: > > - Extracting _UID matching functionality from acpi_dev_hid_uid_match() > helper and introducing it as a separate acpi_dev_uid_match() helper. > > - Converting manual _UID references to use the standard ACPI helpers. > > Changes since v2: > - Drop review tags as suggested by Andy. > > Changes since v1: > - Change acpi_dev_uid_match() to return false in case of NULL argument. > - Drop accepted patches. > > Raag Jadav (6): > ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID > pinctrl: intel: use acpi_dev_uid_match() for matching _UID > ACPI: utils: use acpi_dev_uid_match() for matching _UID > ACPI: x86: use acpi_dev_uid_match() for matching _UID > hwmon: nct6775: use acpi_dev_hid_uid_match() for matching _HID and > _UID > perf: arm_cspmu: use acpi_dev_hid_uid_match() for matching _HID and > _UID For the series, Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > drivers/acpi/utils.c | 34 ++++++++++++++++++++++----- > drivers/acpi/x86/utils.c | 3 +-- > drivers/hwmon/nct6775-platform.c | 4 +--- > drivers/perf/arm_cspmu/arm_cspmu.c | 8 +++---- > drivers/pinctrl/intel/pinctrl-intel.c | 2 +- This pinctrl one is also fine by me so if Andy does not have objections, feel free to add my, Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> > include/acpi/acpi_bus.h | 1 + > include/linux/acpi.h | 5 ++++ > 7 files changed, 40 insertions(+), 17 deletions(-) > > > base-commit: a4ed5bffbeb19cfb7e21ac3b3f09d7bfe39a849b > -- > 2.17.1
On Tue, Oct 24, 2023 at 12:30:10PM +0300, Mika Westerberg wrote: > On Tue, Oct 24, 2023 at 11:50:12AM +0530, Raag Jadav wrote: > > This series refines _UID references across kernel by: ... > > drivers/pinctrl/intel/pinctrl-intel.c | 2 +- > > This pinctrl one is also fine by me so if Andy does not have objections, > feel free to add my, TL;DR: I had, but Rafael seems wanted your opinion. Whatever, I'm not preventing this from happening, but I still consider that the uid check for NULL in the helper should mimic the same logic as in acpi_dev_hid_uid_match(). That's why I asked to drop my tags from this series.
On Tue, Oct 24, 2023 at 11:30 AM Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > > On Tue, Oct 24, 2023 at 11:50:12AM +0530, Raag Jadav wrote: > > This series refines _UID references across kernel by: > > > > - Extracting _UID matching functionality from acpi_dev_hid_uid_match() > > helper and introducing it as a separate acpi_dev_uid_match() helper. > > > > - Converting manual _UID references to use the standard ACPI helpers. > > > > Changes since v2: > > - Drop review tags as suggested by Andy. > > > > Changes since v1: > > - Change acpi_dev_uid_match() to return false in case of NULL argument. > > - Drop accepted patches. > > > > Raag Jadav (6): > > ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID > > pinctrl: intel: use acpi_dev_uid_match() for matching _UID > > ACPI: utils: use acpi_dev_uid_match() for matching _UID > > ACPI: x86: use acpi_dev_uid_match() for matching _UID > > hwmon: nct6775: use acpi_dev_hid_uid_match() for matching _HID and > > _UID > > perf: arm_cspmu: use acpi_dev_hid_uid_match() for matching _HID and > > _UID > > For the series, > > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > > drivers/acpi/utils.c | 34 ++++++++++++++++++++++----- > > drivers/acpi/x86/utils.c | 3 +-- > > drivers/hwmon/nct6775-platform.c | 4 +--- > > drivers/perf/arm_cspmu/arm_cspmu.c | 8 +++---- > > drivers/pinctrl/intel/pinctrl-intel.c | 2 +- > > This pinctrl one is also fine by me so if Andy does not have objections, > feel free to add my, > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Whole series applied as 6.7 material with tags as per the above, thanks!
On Tue, Oct 24, 2023 at 09:51:08PM +0200, Rafael J. Wysocki wrote: > On Tue, Oct 24, 2023 at 11:30 AM Mika Westerberg > <mika.westerberg@linux.intel.com> wrote: > > > > On Tue, Oct 24, 2023 at 11:50:12AM +0530, Raag Jadav wrote: > > > This series refines _UID references across kernel by: > > > > > > - Extracting _UID matching functionality from acpi_dev_hid_uid_match() > > > helper and introducing it as a separate acpi_dev_uid_match() helper. > > > > > > - Converting manual _UID references to use the standard ACPI helpers. > > > > > > Changes since v2: > > > - Drop review tags as suggested by Andy. > > > > > > Changes since v1: > > > - Change acpi_dev_uid_match() to return false in case of NULL argument. > > > - Drop accepted patches. > > > > > > Raag Jadav (6): > > > ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID > > > pinctrl: intel: use acpi_dev_uid_match() for matching _UID > > > ACPI: utils: use acpi_dev_uid_match() for matching _UID > > > ACPI: x86: use acpi_dev_uid_match() for matching _UID > > > hwmon: nct6775: use acpi_dev_hid_uid_match() for matching _HID and > > > _UID > > > perf: arm_cspmu: use acpi_dev_hid_uid_match() for matching _HID and > > > _UID > > > > For the series, > > > > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > > > > drivers/acpi/utils.c | 34 ++++++++++++++++++++++----- > > > drivers/acpi/x86/utils.c | 3 +-- > > > drivers/hwmon/nct6775-platform.c | 4 +--- > > > drivers/perf/arm_cspmu/arm_cspmu.c | 8 +++---- > > > drivers/pinctrl/intel/pinctrl-intel.c | 2 +- > > > > This pinctrl one is also fine by me so if Andy does not have objections, > > feel free to add my, > > > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > Whole series applied as 6.7 material with tags as per the above, thanks! Ok, that means I will _not_ apply the hwmon patch through the hwmon tree. FWIW, please note that I would have very much preferred applying it through the hwmon tree, and I did _not_ Ack it. Guenter
On Wed, Oct 25, 2023 at 4:05 AM Guenter Roeck <linux@roeck-us.net> wrote: > > On Tue, Oct 24, 2023 at 09:51:08PM +0200, Rafael J. Wysocki wrote: > > On Tue, Oct 24, 2023 at 11:30 AM Mika Westerberg > > <mika.westerberg@linux.intel.com> wrote: > > > > > > On Tue, Oct 24, 2023 at 11:50:12AM +0530, Raag Jadav wrote: > > > > This series refines _UID references across kernel by: > > > > > > > > - Extracting _UID matching functionality from acpi_dev_hid_uid_match() > > > > helper and introducing it as a separate acpi_dev_uid_match() helper. > > > > > > > > - Converting manual _UID references to use the standard ACPI helpers. > > > > > > > > Changes since v2: > > > > - Drop review tags as suggested by Andy. > > > > > > > > Changes since v1: > > > > - Change acpi_dev_uid_match() to return false in case of NULL argument. > > > > - Drop accepted patches. > > > > > > > > Raag Jadav (6): > > > > ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID > > > > pinctrl: intel: use acpi_dev_uid_match() for matching _UID > > > > ACPI: utils: use acpi_dev_uid_match() for matching _UID > > > > ACPI: x86: use acpi_dev_uid_match() for matching _UID > > > > hwmon: nct6775: use acpi_dev_hid_uid_match() for matching _HID and > > > > _UID > > > > perf: arm_cspmu: use acpi_dev_hid_uid_match() for matching _HID and > > > > _UID > > > > > > For the series, > > > > > > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > > > > > > drivers/acpi/utils.c | 34 ++++++++++++++++++++++----- > > > > drivers/acpi/x86/utils.c | 3 +-- > > > > drivers/hwmon/nct6775-platform.c | 4 +--- > > > > drivers/perf/arm_cspmu/arm_cspmu.c | 8 +++---- > > > > drivers/pinctrl/intel/pinctrl-intel.c | 2 +- > > > > > > This pinctrl one is also fine by me so if Andy does not have objections, > > > feel free to add my, > > > > > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > > > Whole series applied as 6.7 material with tags as per the above, thanks! > > Ok, that means I will _not_ apply the hwmon patch through > the hwmon tree. > > FWIW, please note that I would have very much preferred applying > it through the hwmon tree, and I did _not_ Ack it. OK, I'll drop it now and please feel free to pick it up (whenever it is convenient to do so), or if you'd rather let me carry it, please let me know. It's only been in my bleeding-edge branch so far.