From patchwork Tue Oct 24 09:24:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 15800 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1818753vqx; Tue, 24 Oct 2023 02:25:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdk0A0iDlDUXNn01BggmyvW95+32CM0i78hislFAAJYVZblRlSEHm59JoXfKDxkFeDbBt+ X-Received: by 2002:a17:902:ec89:b0:1c7:1f3f:b6dc with SMTP id x9-20020a170902ec8900b001c71f3fb6dcmr9278610plg.11.1698139558517; Tue, 24 Oct 2023 02:25:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698139558; cv=none; d=google.com; s=arc-20160816; b=DuD8uRXrf8rp5ipSVi532sGLunWPx+D2nF6K562WANlAsLmUtygENUld19cVu8/rYN O4Y49VgeaZ8LwoeIpzboCMQ0aIC3UHKIL7sOmvj/+673rd/eiZfiAee4r3g+ARqSOQNi 96JnOzK1z1yNii9S6zO6rHoYSPuWjYTkflueZ+Jes3Znteqso5Vt6KALlc4IhCibTiP+ EWJNoAE8RNs+GSFyM4KgBFHXyscVUHEBugCa3kflKNoN8JseX4PsGJ1WllqJGFXDVOmS XSws33yy/Rc0hA17KwBJHu+R1Lfff7z6SLlIf/dghBfxPivF6u2qSDJZVyKMkwvqq23P ZQeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=V4drfBU1NndBBEL9qL7PFTO+dnjU+af8Xvi9HMH+C3g=; fh=6LzVZbiZkLT/dGa7vuRgIb98uqw/Vq+x9hguoxT8GNk=; b=oWiRitvf2BtrB5x5QHu5R4eKu7igmrYKpUcNmsBdcruOPF8csF63Q7hswkTRvUVImu g8hpb3onRyTw9v05xyIkdWYUx1Mi2OoilT8mq3yVG+D0kUyM1KM80ppS9o+uv/VDqt8Q ysEO0kbWaCwKwOCGNNAtKQpRaoqnsvRdAxgDTGXGPxyUbGi1QHy7q9KOXFVr8g3tqAjd 9c4UhgPMaqtMzMGew3TVMBYX84gzru8XZt6rf6Ep3s48UOLkhlVlqmXXCsc+bH4PHkiF M0djsslPGaHW1FY4GnFzoEMBz8fJhoeNoY50q6EVVtcGz0Ukl977nksp9sJUKyB6GbQb A8/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Eph6JMVL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id e7-20020a170902744700b001c9c967e77esi7577645plt.207.2023.10.24.02.25.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 02:25:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Eph6JMVL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 51E8B809C134; Tue, 24 Oct 2023 02:25:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234023AbjJXJZU (ORCPT + 26 others); Tue, 24 Oct 2023 05:25:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234060AbjJXJZR (ORCPT ); Tue, 24 Oct 2023 05:25:17 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 523B510D9 for ; Tue, 24 Oct 2023 02:25:13 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-507ac66a969so5725070e87.3 for ; Tue, 24 Oct 2023 02:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698139511; x=1698744311; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=V4drfBU1NndBBEL9qL7PFTO+dnjU+af8Xvi9HMH+C3g=; b=Eph6JMVLb5ezLaDhqTYG0RaloZfwokHpJmNKcsbZnslUXvMPS58IS4/UgxYK7Cmpi5 oeWmRlWOJWu2tpAlbdZ5xTv9l++BX/UCfN4hd+d/8ojsfqHBKkfEGQTL7QcE3U/80O7i Q29J0fUUglHS+EMIMVdCf0NPMsczCwXh4PhBeRWnDOaG8SPLd5gKsBiXNp9E4fGWDbVh 8jt+7WRFFqvE3ZZJLQSY3lw7BYZadrnoDQT5HJvxrtXg3HdxdsvttlR+nbkKzEQQi+xK imMyTl6p3N+HxUXK32fxvSHm3vJHPMlfYdBmtiCGcx3pui2kpzwqJ5/sT10T4jgZ+8ET pItA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698139511; x=1698744311; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V4drfBU1NndBBEL9qL7PFTO+dnjU+af8Xvi9HMH+C3g=; b=b25OnFOTaTekg7uqv2ibnY+ipG33VMDEFsMWRn+72j4l4pvFfWuUPEhY1uS5RKniOW NkuJtuoRed+SHTlC9WQzTmVJrKnuxId5ICAnFD1Hum8NmLir9EIajBFYBRyLPMMZPDW+ 671QSfR4YqTRPqupoFVkNCcjh67Y/amEPllBWtdLGpSUC5YF+8t6wl+BXfKi1NVPfI3p 0y1b/1vXkJZqnZ9gtx3TlEtGoNft/2JYKW2xJ+RePG8rhCdYJeRWKuBt5p25ng/mEEoA vDeAf1PNfg8lcsAoqPd1AwpDeDmqj5NTmnZQjngn3Rba4eoaVFvDV7YwS6vd1COEly9Q rB6g== X-Gm-Message-State: AOJu0YzjNxN1vj5GiURw7iN6+vRf3py7bm3cgmxHFa8kh9C95xDKKPj9 T5iSCPywNctFS+iFewk31Evstw== X-Received: by 2002:ac2:5308:0:b0:500:a3be:1ab6 with SMTP id c8-20020ac25308000000b00500a3be1ab6mr8272530lfh.6.1698139511223; Tue, 24 Oct 2023 02:25:11 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id c12-20020ac25f6c000000b004fbc82dd1a5sm2060246lfc.13.2023.10.24.02.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 02:25:10 -0700 (PDT) From: Linus Walleij Subject: [PATCH net-next v6 0/7] Create a binding for the Marvell MV88E6xxx DSA switches Date: Tue, 24 Oct 2023 11:24:52 +0200 Message-Id: <20231024-marvell-88e6152-wan-led-v6-0-993ab0949344@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAGSNN2UC/33QyWrDMBQF0F8JWldF89BV/6NkoeEpEbhykY2SE vzvVdyNi3GXl8s7D+4DTVAzTOjt9EAVWp7yWHpQLycUrq5cAOfYM2KEcUqIwZ+uNhgGbAwoKhm +uYIHiD0Hwb1OkaWI+vVXhZTvq/yBCsy4wH1G595c8zSP9Xt92eja/+qUH+qNYoKJpsw7a43U4 X3IxdXxdayXFW1sC4ljiHVIp+CI8coYYXcQ30LqGOId4iZEIWxMnsodJLbQ8XBNPCEAEpTmhnv YQXIDsX82ks+NwDArGaHS6T/Qsiw/VY5Wwe0BAAA= To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?utf-8?q?Marek_Beh=C3=BAn?= Cc: Christian Marangi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Linus Walleij , Rob Herring , Vladimir Oltean X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 24 Oct 2023 02:25:49 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780628385988462291 X-GMAIL-MSGID: 1780628385988462291 The Marvell switches are lacking DT bindings. I need proper schema checking to add LED support to the Marvell switch. Just how it is, it can't go on like this. Some Device Tree fixes are included in the series, these remove the major and most annoying warnings fallout noise: some warnings remain, and these are of more serious nature, such as missing phy-mode. They can be applied individually, or to the networking tree with the rest of the patches. Thanks to Andrew Lunn, Vladimir Oltean and Russell King for excellent review and feedback! Signed-off-by: Linus Walleij --- Changes in v6: - Fix ports/ethernet-ports requirement with proper indenting (hopefully). - Link to v5: https://lore.kernel.org/r/20231023-marvell-88e6152-wan-led-v5-0-0e82952015a7@linaro.org Changes in v5: - Consistently rename switch@n to ethernet-switch@n in all cleanup patches - Consistently rename ports to ethernet-ports in all cleanup patches - Consistently rename all port@n to ethernet-port@n in all cleanup patches - Consistently rename all phy@n to ethernet-phy@n in all cleanup patches - Restore the nodename on the Turris MOX which has a U-Boot binary using the nodename as ABI, put in a blurb warning about this so no-one else tries to change it in the future. - Drop dsa.yaml direct references where we reference dsa.yaml#/$defs/ethernet-ports - Replace the conjured MV88E6xxx example by a better one based on imx6qdl plus strictly named nodes and added reset-gpios for a more complete example, and another example using the interrupt controller based on armada-381-netgear-gs110emx.dts - Bump lineage to 2008 as Vladimir says the code was developed starting 2008. - Link to v4: https://lore.kernel.org/r/20231018-marvell-88e6152-wan-led-v4-0-3ee0c67383be@linaro.org Changes in v4: - Rebase the series on top of Rob's series "dt-bindings: net: Child node schema cleanups" (or the hex numbered ports will not work) - Fix up a whitespacing error corrupting v3... - Add a new patch making the generic DSA binding require ports or ethernet-ports in the switch node. - Drop any corrections of port@a in the patches. - Drop oneOf in the compatible enum for mv88e6xxx - Use ethernet-switch, ethernet-ports and ethernet-phy in the examples - Transclude the dsa.yaml#/$defs/ethernet-ports define for ports - Move the DTS and binding fixes first, before the actual bindings, so they apply without (too many) warnings as fallout. - Drop stray colon in text. - Drop example port in the mveusb binding. - Link to v3: https://lore.kernel.org/r/20231016-marvell-88e6152-wan-led-v3-0-38cd449dfb15@linaro.org Changes in v3: - Fix up a related mvusb example in a different binding that the scripts were complaining about. - Fix up the wording on internal vs external MDIO buses in the mv88e6xxx binding document. - Remove pointless label and put the right rev-mii into the MV88E6060 schema. - Link to v2: https://lore.kernel.org/r/20231014-marvell-88e6152-wan-led-v2-0-7fca08b68849@linaro.org Changes in v2: - Break out a separate Marvell MV88E6060 binding file. I stand corrected. - Drop the idea to rely on nodename mdio-external for the external MDIO bus, keep the compatible, drop patch for the driver. - Fix more Marvell DT mistakes. - Fix NXP DT mistakes in a separate patch. - Fix Marvell ARM64 mistakes in a separate patch. - Link to v1: https://lore.kernel.org/r/20231013-marvell-88e6152-wan-led-v1-0-0712ba99857c@linaro.org --- Linus Walleij (7): dt-bindings: net: dsa: Require ports or ethernet-ports dt-bindings: net: mvusb: Fix up DSA example ARM: dts: marvell: Fix some common switch mistakes ARM: dts: nxp: Fix some common switch mistakes ARM64: dts: marvell: Fix some common switch mistakes dt-bindings: marvell: Rewrite MV88E6xxx in schema dt-bindings: marvell: Add Marvell MV88E6060 DSA schema Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 + .../bindings/net/dsa/marvell,mv88e6060.yaml | 88 ++++++ .../bindings/net/dsa/marvell,mv88e6xxx.yaml | 330 +++++++++++++++++++++ .../devicetree/bindings/net/dsa/marvell.txt | 109 ------- .../devicetree/bindings/net/marvell,mvusb.yaml | 7 +- MAINTAINERS | 3 +- arch/arm/boot/dts/marvell/armada-370-rd.dts | 24 +- .../dts/marvell/armada-381-netgear-gs110emx.dts | 44 ++- .../dts/marvell/armada-385-clearfog-gtr-l8.dts | 38 +-- .../dts/marvell/armada-385-clearfog-gtr-s4.dts | 22 +- arch/arm/boot/dts/marvell/armada-385-linksys.dtsi | 18 +- .../boot/dts/marvell/armada-385-turris-omnia.dts | 20 +- arch/arm/boot/dts/marvell/armada-388-clearfog.dts | 20 +- .../boot/dts/marvell/armada-xp-linksys-mamba.dts | 18 +- arch/arm/boot/dts/nxp/vf/vf610-zii-cfu1.dts | 14 +- arch/arm/boot/dts/nxp/vf/vf610-zii-scu4-aib.dts | 70 ++--- arch/arm/boot/dts/nxp/vf/vf610-zii-spb4.dts | 18 +- arch/arm/boot/dts/nxp/vf/vf610-zii-ssmb-dtu.dts | 20 +- arch/arm/boot/dts/nxp/vf/vf610-zii-ssmb-spu3.dts | 18 +- .../dts/marvell/armada-3720-espressobin-ultra.dts | 14 +- .../boot/dts/marvell/armada-3720-espressobin.dtsi | 20 +- .../boot/dts/marvell/armada-3720-gl-mv1000.dts | 20 +- .../boot/dts/marvell/armada-3720-turris-mox.dts | 189 ++++++------ .../boot/dts/marvell/armada-7040-mochabin.dts | 24 +- .../dts/marvell/armada-8040-clearfog-gt-8k.dts | 22 +- arch/arm64/boot/dts/marvell/cn9130-crb.dtsi | 42 ++- 26 files changed, 761 insertions(+), 457 deletions(-) --- base-commit: 1c9be5fea84e409542a186893d219bf7cff22f5a change-id: 20231008-marvell-88e6152-wan-led-88c43b7fd2fd Best regards,