Message ID | 20231023140003.58019-1-shiftee@posteo.net |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1316533vqx; Mon, 23 Oct 2023 07:01:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkKOBcyfqjgHQ2HOpSEo39AOljV8QEGbtCfMndwktvnQVo/uyJI8FJlQqaeCTOr9xXGAbU X-Received: by 2002:a17:90a:c087:b0:27e:277:3015 with SMTP id o7-20020a17090ac08700b0027e02773015mr8901286pjs.16.1698069695635; Mon, 23 Oct 2023 07:01:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698069695; cv=none; d=google.com; s=arc-20160816; b=EXabWF+C7HWOgq2sFXo4NwM8dIM+TiwGBeQb7L1icIVYqjYM3cLV2fd47etxSelluh aQZg9QepgbJcYMusXt4jbYBgCdo8ADHyHIQLh6jN9VaCTRbhAhp6TsR9dHy1z7Sulsno GlWc8JDj0/epP1Y3qq15HBhRwBzjS/9aaO8Nh9X5wN1kB2MXlad2cBBvjV+NgNES+GJp cQpzs9s0XQ1s3JPMQN/05J2J0lip52Oeb1pZxJDYfLWzvlnhszCpFeEzGvhdLEEbdMdC ciisognlnWQl3vCDYmCvLaDsl8y6UCvAWV5erIhAfvxqpWcGngQfuahljSyg06u76Ni3 sDig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=pq71ZFQSmqDBvaHKCanMYuz149NpjN7yRS2IvpkR2UA=; fh=nK/B2gIzvYPsKU0sJgdKEVdz5eoE00hHt727sEimwsQ=; b=idi5s/0uQR3xMJOaFNB1gEaLWmWJPdJ7MU2JiFutbivqr5B+Bz+7IVUrEa2hskCZym ai4NFzRtAv9y21osjywf64u2KsOo9O97BGzRapvQfCAiB7Rh5+iM72uARUvwWQRYo1V0 L8VSDu0uDRbjJNLgch6c5nh0VmmodQp4wkXKALgxBL0qHwVMjvDm8+d8fISKQEGy4xyR t2Mg3sf/qfyrX0EPeYd+bt7j7cRiPfny/rdVXGzpghHcVSAkEDdUxZv5UC3rroplPrnY xdouPyZi+C0/9rkrWNPinyAL3R5/RKlBQqXz/kkac5HEDJdMkHlYlqhvKPdUAKW1hxQZ /46A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@posteo.net header.s=2017 header.b=N7uhrotP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=posteo.net Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id fz15-20020a17090b024f00b002680e08a877si8854815pjb.186.2023.10.23.07.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 07:01:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@posteo.net header.s=2017 header.b=N7uhrotP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=posteo.net Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id AC7D18076D2C; Mon, 23 Oct 2023 07:00:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229835AbjJWOAU (ORCPT <rfc822;aposhian.dev@gmail.com> + 27 others); Mon, 23 Oct 2023 10:00:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230238AbjJWOAS (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 23 Oct 2023 10:00:18 -0400 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22241110 for <linux-kernel@vger.kernel.org>; Mon, 23 Oct 2023 07:00:15 -0700 (PDT) Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id DA0D124002A for <linux-kernel@vger.kernel.org>; Mon, 23 Oct 2023 16:00:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1698069612; bh=iFQQRi702AynL/9DH88qNRr40fv94tsGYlUkbNd2M+0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version: Content-Transfer-Encoding:From; b=N7uhrotP+wekJVq0e7CpzAlPHahMV8F+OMntufbLbW3Apeuc82xdLHC/ivS6frjlI FtZU50WLmF+P4EpVqOlcRIEwBlmpXQ4NoloC0RngwitC7wI7IMkAlFvviPnRU3lux0 gkt9JhMCjyKO3tmW1pbM4JwqfsLlVxTZwP0w+76XGRG/9yFhTbgtrAZ/3GXwkZ3/Fs 5GZfz7rVMcCxN0wVkYLZVhB8fFM3T19qpCc5HLIH+m4dou98HTq4/SwgbT8lMt8TfO oBGMYwQzm1cdQMwXPjdgdkBxZdD9n3Wo0dprvZIibCeuzpmGfkF8Xmz+Np0qxT63H0 jaGk7dWzvLsSQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SDcJp23Dnz6tvl; Mon, 23 Oct 2023 16:00:10 +0200 (CEST) From: Mark O'Donovan <shiftee@posteo.net> To: linux-kernel@vger.kernel.org Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de, axboe@kernel.dk, kbusch@kernel.org, hare@suse.de, Mark O'Donovan <shiftee@posteo.net> Subject: [PATCH v2 0/3] nvme-tcp: always set valid seq_num in dhchap reply Date: Mon, 23 Oct 2023 14:00:00 +0000 Message-Id: <20231023140003.58019-1-shiftee@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 23 Oct 2023 07:00:38 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780555129245821817 X-GMAIL-MSGID: 1780555129245821817 |
Series |
nvme-tcp: always set valid seq_num in dhchap reply
|
|
Message
Mark O'Donovan
Oct. 23, 2023, 2 p.m. UTC
The first patch is a small unrelated fix which makes it clear that the response data section of the Success1 message is not optional. The second patch removes use of the host sequence number (S2) as an indicator of bi-directional authentication. The third patch causes us to always set the host sequence number (S2) to a non-zero value instead of the 0 value reserved for the secure channel feature. Mark O'Donovan (3): nvme-auth: auth success1 msg always includes resp nvme-auth: add flag for bi-directional auth nvme-auth: always set valid seq_num in dhchap reply drivers/nvme/host/auth.c | 13 ++++++------- include/linux/nvme.h | 2 +- 2 files changed, 7 insertions(+), 8 deletions(-) base-commit: 05d3ef8bba77c1b5f98d941d8b2d4aeab8118ef1
Comments
On Mon, Oct 23, 2023 at 02:00:00PM +0000, Mark O'Donovan wrote: > The first patch is a small unrelated fix which makes it clear that the > response data section of the Success1 message is not optional. > > The second patch removes use of the host sequence number (S2) as an > indicator of bi-directional authentication. > > The third patch causes us to always set the host sequence number (S2) > to a non-zero value instead of the 0 value reserved for the secure > channel feature. Should these go in now for 6.6? We're pretty close to the end. If for 6.7, there is a merge conflict that I think would be easiest resolved if I wait until the block tree resyncs after the 6.7 merge window opens.
On 10/24/23 18:40, Keith Busch wrote: > On Mon, Oct 23, 2023 at 02:00:00PM +0000, Mark O'Donovan wrote: >> The first patch is a small unrelated fix which makes it clear that the >> response data section of the Success1 message is not optional. >> >> The second patch removes use of the host sequence number (S2) as an >> indicator of bi-directional authentication. >> >> The third patch causes us to always set the host sequence number (S2) >> to a non-zero value instead of the 0 value reserved for the secure >> channel feature. > > Should these go in now for 6.6? We're pretty close to the end. If for > 6.7, there is a merge conflict that I think would be easiest resolved if > I wait until the block tree resyncs after the 6.7 merge window opens. > I'd suggest to wait, as we'll need to fixup nvmet, too. Cheers, Hannes