mbox series

[v3,0/7] staging: octeon: Fix warnings due to introduction of new typedefs

Message ID 20231021101238.81466-1-bergh.jonathan@gmail.com
Headers
Series staging: octeon: Fix warnings due to introduction of new typedefs |

Message

Jonathan Bergh Oct. 21, 2023, 10:12 a.m. UTC 
  This patch series fixes (removes) the introduction of several new typedefs
for enums and structs in the octeon driver. First the declarations are
fixed and then implementations are updated to remove references to the 
old typedefs.

Changelog:
 * v1 -> v2: Fix breaking change spread across multiple patches
 * v2 -> v3: Break changes up into individual patches for each removed
   typedef

Jonathan Bergh (7):
  staging: octeon: Fix introduction of new enum typedef cvmx_spi_mode_t
    in octeon
  staging: octeon: Fix up introduction of new typedef
    cvmx_helper_interface_mode_t  in octeon
  staging: octeon: Fix introduction of following new typedef
    cvmx_pow_wait_t in octeon
  staging: octeon: Fix up introduction of new typedef cvmx_pko_lock_t in
    octeon
  staging: octeon: Fix introduction of new typedef cvmx_pko_status_t in
    octeon
  staging: octeon: Fix introduction of new typedef
    cvmx_pip_port_status_t in octeon
  staging: octeon: Fix introduction of new typedef
    cvmx_pko_port_status_t in octeon driver

 drivers/staging/octeon/ethernet.c     |  6 ++--
 drivers/staging/octeon/octeon-stubs.h | 48 +++++++++++++--------------
 2 files changed, 27 insertions(+), 27 deletions(-)

Comments

Greg KH Oct. 21, 2023, 8:54 p.m. UTC | #1 
On Sat, Oct 21, 2023 at 12:12:31PM +0200, Jonathan Bergh wrote:
> This patch series fixes (removes) the introduction of several new typedefs
> for enums and structs in the octeon driver. First the declarations are
> fixed and then implementations are updated to remove references to the 
> old typedefs.
> 
> Changelog:
>  * v1 -> v2: Fix breaking change spread across multiple patches
>  * v2 -> v3: Break changes up into individual patches for each removed
>    typedef


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did not apply to any known trees that Greg is in control
  of.  Possibly this is because you made it against Linus's tree, not
  the linux-next tree, which is where all of the development for the
  next version of the kernel is at.  Please refresh your patch against
  the linux-next tree, or even better yet, the development tree
  specified in the MAINTAINERS file for the subsystem you are submitting
  a patch for, and resend it.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
Dan Carpenter Oct. 23, 2023, 2:41 p.m. UTC | #2 
On Sat, Oct 21, 2023 at 12:12:31PM +0200, Jonathan Bergh wrote:
> This patch series fixes (removes) the introduction of several new typedefs
> for enums and structs in the octeon driver. First the declarations are
> fixed and then implementations are updated to remove references to the 
> old typedefs.
> 
> Changelog:
>  * v1 -> v2: Fix breaking change spread across multiple patches
>  * v2 -> v3: Break changes up into individual patches for each removed
>    typedef
> 
> Jonathan Bergh (7):
>   staging: octeon: Fix introduction of new enum typedef cvmx_spi_mode_t
>     in octeon
>   staging: octeon: Fix up introduction of new typedef
>     cvmx_helper_interface_mode_t  in octeon
>   staging: octeon: Fix introduction of following new typedef
>     cvmx_pow_wait_t in octeon
>   staging: octeon: Fix up introduction of new typedef cvmx_pko_lock_t in
>     octeon
>   staging: octeon: Fix introduction of new typedef cvmx_pko_status_t in
>     octeon
>   staging: octeon: Fix introduction of new typedef
>     cvmx_pip_port_status_t in octeon
>   staging: octeon: Fix introduction of new typedef
>     cvmx_pko_port_status_t in octeon driver
> 
>  drivers/staging/octeon/ethernet.c     |  6 ++--
>  drivers/staging/octeon/octeon-stubs.h | 48 +++++++++++++--------------

Please don't change the stubs without change the arch/ code.

regards,
dan carpenter
Jonathan Bergh Oct. 26, 2023, 8:02 p.m. UTC | #3 
On Mon, Oct 23, 2023 at 05:41:38PM +0300, Dan Carpenter wrote:
> On Sat, Oct 21, 2023 at 12:12:31PM +0200, Jonathan Bergh wrote:
> > This patch series fixes (removes) the introduction of several new typedefs
> > for enums and structs in the octeon driver. First the declarations are
> > fixed and then implementations are updated to remove references to the 
> > old typedefs.
> > 
> > Changelog:
> >  * v1 -> v2: Fix breaking change spread across multiple patches
> >  * v2 -> v3: Break changes up into individual patches for each removed
> >    typedef
> > 
> > Jonathan Bergh (7):
> >   staging: octeon: Fix introduction of new enum typedef cvmx_spi_mode_t
> >     in octeon
> >   staging: octeon: Fix up introduction of new typedef
> >     cvmx_helper_interface_mode_t  in octeon
> >   staging: octeon: Fix introduction of following new typedef
> >     cvmx_pow_wait_t in octeon
> >   staging: octeon: Fix up introduction of new typedef cvmx_pko_lock_t in
> >     octeon
> >   staging: octeon: Fix introduction of new typedef cvmx_pko_status_t in
> >     octeon
> >   staging: octeon: Fix introduction of new typedef
> >     cvmx_pip_port_status_t in octeon
> >   staging: octeon: Fix introduction of new typedef
> >     cvmx_pko_port_status_t in octeon driver
> > 
> >  drivers/staging/octeon/ethernet.c     |  6 ++--
> >  drivers/staging/octeon/octeon-stubs.h | 48 +++++++++++++--------------

Hi
 
> Please don't change the stubs without change the arch/ code.

My tree was out of date, so these changes had already actually been applied
by basically the same patches (ie removing these typedefs) around 17/09 
(Sep).
 
> regards,
> dan carpenter
>