mbox series

[0/2] sc7180: Add qdsp baked soundcard

Message ID 20231020-sc7180-qdsp-sndcard-v1-0-157706b7d06f@trvn.ru
Headers
Series sc7180: Add qdsp baked soundcard |

Message

Nikita Travkin Oct. 20, 2023, 3:33 p.m. UTC 
  Some devices, such as Acer Aspire 1, can't use lpass dirrectly, but
instead must use adsp core to play sound. Since otherwise the hardware
is, usually, very similar across the devices on the same platform, it
makes sense to reuse the same boardfile.

This series refactors the sc7180.c slightly and adds the functions to
control clocks via adsp instead of controlling the hardware directly.

Existing google devices should experience no change.

Signed-off-by: Nikita Travkin <nikita@trvn.ru>
---
Nikita Travkin (2):
      ASoC: dt-bindings: qcom,sm8250: Add sc7180-qdsp6-sndcard
      ASoC: qcom: sc7180: Add support for qdsp6 baked sound

 .../devicetree/bindings/sound/qcom,sm8250.yaml     |   1 +
 sound/soc/qcom/sc7180.c                            | 195 ++++++++++++++++++---
 2 files changed, 174 insertions(+), 22 deletions(-)
---
base-commit: 2030579113a1b1b5bfd7ff24c0852847836d8fd1
change-id: 20231020-sc7180-qdsp-sndcard-e8067017eb4c

Best regards,

Comments

Konrad Dybcio Oct. 21, 2023, 4:17 p.m. UTC | #1 
On 10/20/23 17:33, Nikita Travkin wrote:
> Some devices, such as Acer Aspire 1, can't use lpass dirrectly, but
> instead must use adsp core to play sound. Since otherwise the hardware
> is, usually, very similar across the devices on the same platform, it
> makes sense to reuse the same boardfile.
> 
> This series refactors the sc7180.c slightly and adds the functions to
> control clocks via adsp instead of controlling the hardware directly.
> 
> Existing google devices should experience no change.
> 
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> ---
s/baked/backed, unless it's a nice bread :)

Konrad
Nikita Travkin Oct. 21, 2023, 4:47 p.m. UTC | #2 
Konrad Dybcio писал(а) 21.10.2023 21:17:
> On 10/20/23 17:33, Nikita Travkin wrote:
>> Some devices, such as Acer Aspire 1, can't use lpass dirrectly, but
>> instead must use adsp core to play sound. Since otherwise the hardware
>> is, usually, very similar across the devices on the same platform, it
>> makes sense to reuse the same boardfile.
>>
>> This series refactors the sc7180.c slightly and adds the functions to
>> control clocks via adsp instead of controlling the hardware directly.
>>
>> Existing google devices should experience no change.
>>
>> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
>> ---
> s/baked/backed, unless it's a nice bread :)

At least I was consistent in failing to pick the correct word...

If we get to v2, I will try to remember about those, but if not,
I guess I will accept the chance, that in a couple of years I may
wake up in cold sweat upon realizing that this mistake is forever
immortalized in the Linux git history...

Thanks for noticing this!
Nikita

> 
> Konrad
Mark Brown Oct. 26, 2023, 5:10 p.m. UTC | #3 
On Fri, 20 Oct 2023 20:33:45 +0500, Nikita Travkin wrote:
> Some devices, such as Acer Aspire 1, can't use lpass dirrectly, but
> instead must use adsp core to play sound. Since otherwise the hardware
> is, usually, very similar across the devices on the same platform, it
> makes sense to reuse the same boardfile.
> 
> This series refactors the sc7180.c slightly and adds the functions to
> control clocks via adsp instead of controlling the hardware directly.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: dt-bindings: qcom,sm8250: Add sc7180-qdsp6-sndcard
      commit: 5443d186163c6ab0084a5b23c901e0f9ba792463
[2/2] ASoC: qcom: sc7180: Add support for qdsp6 baked sound
      commit: 4531f512e3ef147f07d47bceb256c0af5ab130b7

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark