From patchwork Thu Oct 19 14:40:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Ene X-Patchwork-Id: 15629 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2010:b0:403:3b70:6f57 with SMTP id fe16csp432090vqb; Thu, 19 Oct 2023 07:41:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGsIOpo/9clcspZ2khwd+tWar55242GNC/RBx+l3mX+HdgT9V6Xh5KKmkTIZyN7rfOzturf X-Received: by 2002:a05:6e02:1ba4:b0:350:f2a0:5c44 with SMTP id n4-20020a056e021ba400b00350f2a05c44mr3085294ili.2.1697726477796; Thu, 19 Oct 2023 07:41:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697726477; cv=none; d=google.com; s=arc-20160816; b=aRcHoImhFGKn77MXwR9yfPmp1wfRgvK49ahHMSMQbuMbhBpzYT4lmcSfTL89kTsfV3 jbC+w73+j53JkaMoUqbSCollCxWXB82sh71KMZbu/sAr6Txepb+Me6Dkr1K8+AtvA0lF 1JU733AL2r0nrUCy450k24uiOp58UvVGOT0RpwCKVRuV0EqKwjxaAwZBbQQoIhGtp4F3 /sSwvA9HObPWQ1hlirqLPTTvdtEZyj57ZXHh2cHgpyJj/1PPBb74xPfB7R1IjikiAc4R aiIrifINxKaZlPF1v8jCYjF8g5LAtTY+b6R/vo4gW4qEgGMOD6bULFN2bPuLdNwLg03F ol3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=VwGo+pxMqRlSrxNR7lfucT+VBcms/xUP2WA4dRFnCj4=; fh=t9YKxUPg1Kt5PJ3n0c95aaxkMlch/EFXblRJVyulW1I=; b=ads2he6zH/mokxwxhi7gVEPQ4cNLa8W3OIkM3HR4hVbVKUflzbq98IIG7Q6YOkVYMY fTWBkVEPg0fHvz4MB9fJVTgm4bUqSUdvXO9wzA73fOJinOVvMUmf6s3RpgMikv8QBmbv EjHTB7NUFVN2HdJdOpFTuNgmeop59aLHHIqndqxeHDSlH6CTafiei+BnBR16cgQQ0dJe r/0uvcF1DufGfa4IPHJZZUnlWUlymq4/KWelPNH559oSkKMgN8K/6ChjeMXkIBMDAZEh 10qinGcLY2rWwGfm516Jv7XoN1S3J28vApZTlRJXGc7CHodw0Wsl258zJpx5wF1PAPCb JgQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=VG2hVk9F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id w9-20020a056a0014c900b00690c19cb105si6175108pfu.250.2023.10.19.07.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 07:41:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=VG2hVk9F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id F1A308228988; Thu, 19 Oct 2023 07:41:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346078AbjJSOkt (ORCPT + 25 others); Thu, 19 Oct 2023 10:40:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346204AbjJSOkn (ORCPT ); Thu, 19 Oct 2023 10:40:43 -0400 Received: from mail-wr1-x449.google.com (mail-wr1-x449.google.com [IPv6:2a00:1450:4864:20::449]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DAC518E for ; Thu, 19 Oct 2023 07:40:40 -0700 (PDT) Received: by mail-wr1-x449.google.com with SMTP id ffacd0b85a97d-32dceab634dso955699f8f.2 for ; Thu, 19 Oct 2023 07:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697726438; x=1698331238; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=VwGo+pxMqRlSrxNR7lfucT+VBcms/xUP2WA4dRFnCj4=; b=VG2hVk9F+nnrPsmVmXWMsUPLWSclBiXbEMhbPG6yll9TrLkv/riQY0fmPPlYFHYuLV bAgf8CTFTNGMqRra5ywZwOZZwJtfC+eJi4zy/d8KflxsSVy0qYyoBhi6ZfXpCMLXLQsm vnZfWGkHrcaGeyOYlfS10e0mhHXsNnigNh0sdlyXilnkdEcWXwISWKPsB/aPsO9wzRAg XOMi53waf9mZDmHrKiOZFozyYivMFvnAFSUYFbbY5zlkvKRZyQiv/boWzJjLUO2hm6CS lLbAVkDfiNn83vNfL5yRuFsoMnEa215a1TeZDc3TW9Am0UefTAVvi2vF9GA3KVisoABK 8j6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697726438; x=1698331238; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VwGo+pxMqRlSrxNR7lfucT+VBcms/xUP2WA4dRFnCj4=; b=cnYMSC/kDJetipCzftDjQbwmiDBDzsAl1qVXgvbg2cA/LK/FSIwMW+exFykDvwVX/j Sox4Loz5j2sni5slDyX7hF5LbDJHpOtUksYQ9EFtuJYyB2PTlcWzOaLsrEGnahlbRmS/ dnsyEilWOfSra2O2OIZNsaCu4NL3q8PPuJ3sDn9VfMGyFKZBa3bzXMNQ4cJUMQ6Yytxw 0mKsNThpdO2bsOBBSUQl2NaDr0MWzPx9xw56vw2ugwJBRxQWYEsC+EG9ZlKI13JOPHAV 9thUXApeS80SVxcO20QpVGksoYUcJqCCVifGpJvavtFKmk6AAW81t36S+n9aMeQ0dyaT BKwQ== X-Gm-Message-State: AOJu0YxqUAHS7n5xTvwPUdocGAu0ghiQfMZmjdVtWO7TfdkKD+auxyBf 3WwKIZ9SLfEwgqQZ+FgXXphI3e56dlt7nGVC0xg= X-Received: from seb.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:31bd]) (user=sebastianene job=sendgmr) by 2002:adf:9d86:0:b0:32d:885e:a0fa with SMTP id p6-20020adf9d86000000b0032d885ea0famr21519wre.10.1697726438121; Thu, 19 Oct 2023 07:40:38 -0700 (PDT) Date: Thu, 19 Oct 2023 14:40:21 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.42.0.655.g421f12c284-goog Message-ID: <20231019144032.2943044-1-sebastianene@google.com> Subject: [PATCH v2 00/11] arm64: ptdump: View the second stage page-tables From: Sebastian Ene To: will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com, akpm@linux-foundation.org, maz@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com, vdonnefort@google.com, qperret@google.com, smostafa@google.com, Sebastian Ene X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 19 Oct 2023 07:41:09 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780195238684158955 X-GMAIL-MSGID: 1780195238684158955 Hi, This can be used as a debugging tool for dumping the second stage page-tables under debugfs. From the previous feedback I re-worked the series and added support for guest page-tables dumping under VHE & nVHE configuration. I extended the list of reviewers as I missed the interested parties in the first round. When CONFIG_NVHE_EL2_PTDUMP_DEBUGFS is enabled under pKVM environment, ptdump registers the 'host_stage2_kernel_page_tables' entry with debugfs. Guests are registering a file named '%u_guest_stage2_page_tables' when they are created. This allows us to dump the host stage-2 page-tables with the following command: cat /sys/kernel/debug/host_stage2_kernel_page_tables. The output is showing the entries in the following format: The tool interprets the pKVM ownership annotation stored in the invalid entries and dumps to the console the ownership information. To be able to access the host stage-2 page-tables from the kernel, a new hypervisor call was introduced which allows us to snapshot the page-tables in a host provided buffer. The hypervisor call is hidden behind CONFIG_NVHE_EL2_DEBUG as this should be used under debugging environment. Link to the first version: https://lore.kernel.org/all/20230927112517.2631674-1-sebastianene@google.com/ Changelog: v1 -> v2: * use the stage-2 pagetable walker for dumping descriptors instead of the one provided by ptdump. * support for guests pagetables dumping under VHE/nVHE non-protected Thanks, Sebastian Ene (11): KVM: arm64: Add snap shooting the host stage-2 pagetables arm64: ptdump: Use the mask from the state structure arm64: ptdump: Add the walker function to the ptdump info structure KVM: arm64: Move pagetable definitions to common header arm64: ptdump: Introduce stage-2 pagetables format description arm64: ptdump: Add hooks on debugfs file operations arm64: ptdump: Register a debugfs entry for the host stage-2 page-tables arm64: ptdump: Parse the host stage-2 page-tables from the snapshot arm64: ptdump: Interpret memory attributes based on runtime configuration arm64: ptdump: Interpret pKVM ownership annotations arm64: ptdump: Add support for guest stage-2 pagetables dumping arch/arm64/include/asm/kvm_asm.h | 1 + arch/arm64/include/asm/kvm_pgtable.h | 85 +++ arch/arm64/include/asm/ptdump.h | 27 +- arch/arm64/kvm/Kconfig | 12 + arch/arm64/kvm/hyp/include/nvhe/mem_protect.h | 8 +- arch/arm64/kvm/hyp/nvhe/hyp-main.c | 18 + arch/arm64/kvm/hyp/nvhe/mem_protect.c | 103 ++++ arch/arm64/kvm/hyp/pgtable.c | 98 ++-- arch/arm64/kvm/mmu.c | 3 + arch/arm64/mm/ptdump.c | 487 +++++++++++++++++- arch/arm64/mm/ptdump_debugfs.c | 42 +- 11 files changed, 822 insertions(+), 62 deletions(-)