mbox series

[v2,0/2] w1: Add AXI 1-wire host driver for AMD programmable logic IP core

Message ID 20231019142526.10592-1-kris.chaplin@amd.com
Headers
Series w1: Add AXI 1-wire host driver for AMD programmable logic IP core |

Message

Kris Chaplin Oct. 19, 2023, 2:24 p.m. UTC 
  Changes since v1:
 Updated IP name and binding to axi-1wire-host and filenames to match
 Comment pruning where operation obvious, additional comments where not
 Unwrapped helper functions for register read/writes
 Removed un-necessary device reset on fail to add device
 Fixed duplicate clock disable in remove function
 Move bus master structure to per instance
 Improved hardware testing with multiple w1 instances

Add a host driver to support the AMD 1-Wire programmable logic IP block.
This block guarantees protocol timing for driving off-board devices such as thermal sensors, proms, etc.

Kris Chaplin (2):
  dt-bindings: w1: Add YAML DT schema for AMD AXI w1 host and
    MAINTAINERS entry
  w1: Add AXI 1-wire host driver for AMD programmable logic IP core

 .../bindings/w1/amd,axi-1wire-host.yaml       |  44 ++
 MAINTAINERS                                   |   8 +
 drivers/w1/masters/Kconfig                    |  11 +
 drivers/w1/masters/Makefile                   |   1 +
 drivers/w1/masters/amd_axi_w1.c               | 395 ++++++++++++++++++
 5 files changed, 459 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml
 create mode 100644 drivers/w1/masters/amd_axi_w1.c

Comments

Conor Dooley Oct. 19, 2023, 2:28 p.m. UTC | #1 
On Thu, Oct 19, 2023 at 07:24:16AM -0700, Kris Chaplin wrote:
> Changes since v1:
>  Updated IP name and binding to axi-1wire-host and filenames to match
>  Comment pruning where operation obvious, additional comments where not
>  Unwrapped helper functions for register read/writes
>  Removed un-necessary device reset on fail to add device
>  Fixed duplicate clock disable in remove function
>  Move bus master structure to per instance
>  Improved hardware testing with multiple w1 instances
> 
> Add a host driver to support the AMD 1-Wire programmable logic IP block.
> This block guarantees protocol timing for driving off-board devices such as thermal sensors, proms, etc.

btw, please do not send a vN as a response to the v(N-1) patchset. It
ends up hiding things in the depths of people's mailboxes that sort by
threads.

Cheers,
Conor.

> 
> Kris Chaplin (2):
>   dt-bindings: w1: Add YAML DT schema for AMD AXI w1 host and
>     MAINTAINERS entry
>   w1: Add AXI 1-wire host driver for AMD programmable logic IP core
> 
>  .../bindings/w1/amd,axi-1wire-host.yaml       |  44 ++
>  MAINTAINERS                                   |   8 +
>  drivers/w1/masters/Kconfig                    |  11 +
>  drivers/w1/masters/Makefile                   |   1 +
>  drivers/w1/masters/amd_axi_w1.c               | 395 ++++++++++++++++++
>  5 files changed, 459 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml
>  create mode 100644 drivers/w1/masters/amd_axi_w1.c
> 
> -- 
> 2.42.GIT
>