mbox series

[v3,0/3] Revamp k3-socinfo driver

Message ID 20231016101608.993921-1-n-francis@ti.com
Headers
Series Revamp k3-socinfo driver |

Message

Neha Malcom Francis Oct. 16, 2023, 10:16 a.m. UTC 
  k3-socinfo driver doesn't account for difference series of silicon
revisions instead of the typical 1.0, 2.0 etc case. This exception is
currently already seen in J721E. This series aims to modify the driver
to account for those exceptions as well as clean things up a bit.

Changes since v2:
	- Nishanth:
		- update commit message
		- move from double Signed-off-by to Co-developed-by
		- make j721e_rev_string_map[] a const char
		- drop k3_rev_string_map[] and continue using old
		  "variant++" logic for the typical cases
		- appropriate error handling with no overrides
		  distinguishing between ENODEV and ENOMEM
		- add patch for error handling initial cleanup
		- reorder patches

Changes since v1:
	- Nishanth:
		- undo churning of family attribute
		- remove unnecessary code relocation
		- add Thejasvi to Signed-off-by as we are now similar to
		  the initial attempt [1]
		- separate out typo fixes to another patch (2/2)

Boot log: https://gist.github.com/nehamalcom/ff9375dcde681dd78712ee8473b24a50
(See relevant k3-socinfo dev_info print on line 276)

v2: https://lore.kernel.org/lkml/20230915064650.2287638-1-n-francis@ti.com/T/
v1: https://lore.kernel.org/linux-arm-kernel/20230914074426.1901226-1-n-francis@ti.com/T/

[1] https://lore.kernel.org/all/20230607080349.26671-1-t-konduru@ti.com/

Neha Malcom Francis (3):
  soc: ti k3-socinfo: Fix typo
  soc: ti: k3-socinfo: Avoid overriding ret
  soc: ti: k3-socinfo: Revamp driver to accommodate different rev
    structs

 drivers/soc/ti/k3-socinfo.c | 76 +++++++++++++++++++++++++++----------
 1 file changed, 57 insertions(+), 19 deletions(-)

Comments

Nishanth Menon Oct. 16, 2023, 4:46 p.m. UTC | #1 
Hi Neha Malcom Francis,

On Mon, 16 Oct 2023 15:46:05 +0530, Neha Malcom Francis wrote:
> k3-socinfo driver doesn't account for difference series of silicon
> revisions instead of the typical 1.0, 2.0 etc case. This exception is
> currently already seen in J721E. This series aims to modify the driver
> to account for those exceptions as well as clean things up a bit.
> 
> Changes since v2:
> 	- Nishanth:
> 		- update commit message
> 		- move from double Signed-off-by to Co-developed-by
> 		- make j721e_rev_string_map[] a const char
> 		- drop k3_rev_string_map[] and continue using old
> 		  "variant++" logic for the typical cases
> 		- appropriate error handling with no overrides
> 		  distinguishing between ENODEV and ENOMEM
> 		- add patch for error handling initial cleanup
> 		- reorder patches
> 
> [...]

I have applied the following to branch ti-drivers-soc-next on [1] with minor
fixups.

Thank you!

[1/3] soc: ti k3-socinfo: Fix typo
      commit: 8dec342ead710dace27dc82096144bf7a1011827
[2/3] soc: ti: k3-socinfo: Avoid overriding ret
      commit: 3aeb0d3694e16b5066db82aa1152884f2e6aace0
[3/3] soc: ti: k3-socinfo: Revamp driver to accommodate different rev structs
      commit: 07e651db2d78eac4c41d7144eb5ea734af2328fc

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
Nishanth Menon Dec. 6, 2023, 3:58 p.m. UTC | #2 
Hi Neha Malcom Francis,

On Mon, 16 Oct 2023 15:46:05 +0530, Neha Malcom Francis wrote:
> k3-socinfo driver doesn't account for difference series of silicon
> revisions instead of the typical 1.0, 2.0 etc case. This exception is
> currently already seen in J721E. This series aims to modify the driver
> to account for those exceptions as well as clean things up a bit.
> 
> Changes since v2:
> 	- Nishanth:
> 		- update commit message
> 		- move from double Signed-off-by to Co-developed-by
> 		- make j721e_rev_string_map[] a const char
> 		- drop k3_rev_string_map[] and continue using old
> 		  "variant++" logic for the typical cases
> 		- appropriate error handling with no overrides
> 		  distinguishing between ENODEV and ENOMEM
> 		- add patch for error handling initial cleanup
> 		- reorder patches
> 
> [...]

I have applied the following to branch ti-drivers-soc-next on [1].
Thank you!

[3/3] soc: ti: k3-socinfo: Revamp driver to accommodate different rev structs
      commit: 3ba080bf46e4a9039d0d41356f4a2515e00bf747

The networking dependency previously identified has been sorted out
and available in linux-next[2] since next-20231206. So, this is a good
time for us to merge the patch that I have been keeping held up. At least
on my local scan, I don't see any other in-tree driver impacted by this.

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
[2] https://lore.kernel.org/all/20231201132033.29576-1-r-gunasekaran@ti.com/