From patchwork Sun Oct 15 23:29:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hengqi Chen X-Patchwork-Id: 15388 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3185073vqb; Sun, 15 Oct 2023 18:47:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjWba78kQxcMF7dDAnMtFPG0TqozGSXw6mdmEPUx0eso+GNQhqNW/UmveNAQYe/W/3zvjr X-Received: by 2002:a05:6a20:daa8:b0:171:947f:465b with SMTP id iy40-20020a056a20daa800b00171947f465bmr22066533pzb.4.1697420860336; Sun, 15 Oct 2023 18:47:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697420860; cv=none; d=google.com; s=arc-20160816; b=dgQoCu9jeTciFdSBn5/tpNUwx1641tu8gxHIbFVrQu1zBNC5ftn2v0h4/L2cwifmG+ aZeF+rE+TVXsbsmql3ckiuw0mxoLB/7PXCAEHKl7ilP1ZSmOjGI1gO7Qj38je63Rz58B ONCNK1xOF+dW8EMXWpA1v/7dSQGBsXFC/dacOUAbzgxQXQgOvsqUH0KQTr0xP8v/r4Pc hGFjKkK25U77mr0VQMIaXeYcjf8dEHlsp5/TJnqBicQjexmM5eTOoaF+y8Gl0mlOipCs rx/FBttb0eWLvjvZYtW43iXVaFvpXzpd9aP1n2xiYtRQ2qYkRYhaanE1YcuDNkVqnwuJ PFqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hSKqSeuO60jQ7suM+oaQb4M4uYV7/Tl47jargmSs7Lg=; fh=UUVBB6hdZtgkdevQaSWXrPPcR6FiQNJo3IQxWCli3s0=; b=EEwqMWEIsLO3xkoNG0dqGpYV/9VtXLLfKDeq8GCo9NBDTmWwezqmoH2OqF3mU+i3lw difXnYxVzPp4idU+53vHfGC3uwHc7kMdH707vtKkxXdoCSaFK01/zTSwmPCCfY4zdUIF nTWGJEkAMOsWzAwvo4BTEksSCNwxzzRjlZgA/MqID87PkIjKeEEN658NNwsvKwI+z3CR lUpXAy6AnW1gdnEClMlMBP3VfY72aSqFjQuUhQEVmY/N+3ThjWkPrV3rSr5y1r6ZXF1U dy3cC5Pii9w7MO+4X2u1CeVrJSO9OuNmAxzXiod7QZ23kWFWfuBhcRaLOwIDVt5e8272 uSDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=YA4fFmc5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id l7-20020a17090a850700b0027b4d1ee2c6si5058993pjn.144.2023.10.15.18.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 18:47:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=YA4fFmc5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 17A1D8096395; Sun, 15 Oct 2023 18:47:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231135AbjJPBr0 (ORCPT + 19 others); Sun, 15 Oct 2023 21:47:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjJPBrZ (ORCPT ); Sun, 15 Oct 2023 21:47:25 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB043DF; Sun, 15 Oct 2023 18:47:23 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6b5cac99cfdso1525847b3a.2; Sun, 15 Oct 2023 18:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697420842; x=1698025642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hSKqSeuO60jQ7suM+oaQb4M4uYV7/Tl47jargmSs7Lg=; b=YA4fFmc5MhQGHEiS/MMMICIWHzS6Ze0W4gWwhDswvVd8UxzXyS1An2lxv/NRmCHSBX e6KchBDveTRzxhwq+vb7sNbSnuzlMJwqmdQwV6dDhREPlW8KqN4o/Llu4n0ZopgEFrFw ptTpVuR+smmYOQe/hrfeoXzkZ37EgN1T+P0bo7QkZ9AyEPfGmiG1YRFfmQkT9u6Jyhbi bi8KrS05pfcHCfBZ3KwNZNTjwbMN5D/mTQ/MZvDFJIxXoW4jZSQhfixUjGMBLobSQcdE ln6iEjLiFuH9rb+/XLtPw6Mm6kthE++5IWi0XMrHxNO6D41HPXkb+LytS8GNf4jHZgTs 9Mgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697420842; x=1698025642; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hSKqSeuO60jQ7suM+oaQb4M4uYV7/Tl47jargmSs7Lg=; b=E1Ew9xblItQd2xseQZuMg8HBwkwhNxfV7GG4pIZeF89g8ZhRjHFfPES4R40ZkSjTy9 MSZ0jdf4EnieHiHifM7jjUmxzFtgh2nNTRP+VbNMukC8seQztiGAr2/I6yQaU1yyl59M 6ofDaEOJPPrBzTgAR6NbX09alVlyjSEMfW4pnBb5vLmZqjT9daJgcOKyoSLJ8W46/mea Wu93vbS8thovpkBgtJex6BAr8qtWy7iS8waasEkmtvQg6G5RVIfNqE7QQeHT5lT5xLOz Gz40/FZUIHElV10qUGXa5bUe70i7kusKCTulXhNMT296RBErm93jOMjwC6L7AkVqYQPJ qUxQ== X-Gm-Message-State: AOJu0YwrhL57Hc7wkNbu5TJekwHbDhn0yfSuU3TT20OvRgGjWM4W/4e4 SnL8ipxIlBxf4Wh9OZXYvChVsJZ4ngzzUg== X-Received: by 2002:a05:6a20:9152:b0:14c:5fa6:e308 with SMTP id x18-20020a056a20915200b0014c5fa6e308mr29271328pzc.43.1697420842494; Sun, 15 Oct 2023 18:47:22 -0700 (PDT) Received: from ubuntu.. ([203.205.141.13]) by smtp.googlemail.com with ESMTPSA id pd17-20020a17090b1dd100b0027cfb5f010dsm3574377pjb.4.2023.10.15.18.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 18:47:21 -0700 (PDT) From: Hengqi Chen To: linux-kernel@vger.kernel.org, bpf@vger.kernel.org Cc: keescook@chromium.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, luto@amacapital.net, wad@chromium.org, alexyonghe@tencent.com, hengqi.chen@gmail.com Subject: [PATCH v2 0/5] seccomp: Make seccomp filter reusable Date: Sun, 15 Oct 2023 23:29:48 +0000 Message-Id: <20231015232953.84836-1-hengqi.chen@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sun, 15 Oct 2023 18:47:38 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779874775971861201 X-GMAIL-MSGID: 1779874775971861201 This patchset introduces a new operation and a new flag to split the SECCOMP_SET_MODE_FILTER process into two steps: load filter and attach filter. Thus we can reuse the filter. The new SECCOMP_LOAD_FILTER loads the filter and returns a fd which can be pinned to bpffs. This extends the lifetime of the filter and thus can be reused by different processes. With this new operation, we can eliminate a hot path of JITing BPF program (the filter) where we apply the same seccomp filter to thousands of micro VMs on a bare metal instance. The new flag SECCOMP_FILTER_FLAG_BPF_PROG_FD is used to attach a filter which is loaded via SECCOMP_LOAD_FILTER and represented by a seccomp bpf prog fd. The fd is either returned from SECCOMP_LOAD_FILTER or obtained from bpffs using bpf syscall. Change logs: v1 -> v2: - Add a flag to attach filter from fd - Update selftests RFC -> v1: - Addressed comments from Kees - Reuse filter copy/create code (patch 1) - Add a selftest (patch 4) Hengqi Chen (5): seccomp: Refactor filter copy/create for reuse seccomp, bpf: Introduce SECCOMP_LOAD_FILTER operation seccomp: Introduce new flag SECCOMP_FILTER_FLAG_BPF_PROG_FD selftests/seccomp: Test seccomp filter load and attach selftests/bpf: Skip BPF_PROG_TYPE_SECCOMP-related tests include/linux/seccomp.h | 3 +- include/uapi/linux/bpf.h | 1 + include/uapi/linux/seccomp.h | 3 + kernel/seccomp.c | 170 +++++++++++++++--- tools/include/uapi/linux/bpf.h | 1 + .../selftests/bpf/prog_tests/libbpf_probes.c | 3 +- .../selftests/bpf/prog_tests/libbpf_str.c | 3 + tools/testing/selftests/seccomp/seccomp_bpf.c | 44 +++++ 8 files changed, 197 insertions(+), 31 deletions(-)