mbox series

[v6,0/2] Add maxim max34408/34409 ADC driver and yaml

Message ID 20231014211254.16719-1-fr0st61te@gmail.com
Headers
Series Add maxim max34408/34409 ADC driver and yaml |

Message

Ivan Mikhaylov Oct. 14, 2023, 9:12 p.m. UTC 
  Add Maxim max34408/34409 ADC driver and yaml for it. Until now it
supports only current monitioring function without overcurrent
threshold/delay, shutdown delay configuration, alert interrupt.

Changes from v1:
   - minor changes from Rob's comments for yaml
   - add ena, shtdn and make 4 inputs for R sense from Jonathan's comments for yaml
   - add _REG suffix and make prefix for bitmasks and statuses
   - add SCALE/OFFSET instead of AVG/PROCESSED from Jonathan and
     Lars-Peter comments
   - add chip data from Jonathan and Lars-Peter comments
   - minor changes from Lars-Peter and Jonathan comments for driver

Changes from v2:
   - add channels into hardware description into yaml
   - add rsense property per channel
   - rename pins for shtdn and ena pins
   - make one array for input_rsense values

Changes from v3:
   - change *_34408_OCT3 and 4 to *_34409_OCT3 and 4
   - change of_property_read_u32 to fwnode family calls
   - add i2c dev table
   - change of_match_device to i2c_of_match_device
   - change match->data to i2c_get_match_data 

Changes from v4:
   - minor changes in yaml

Changes from v5:
   - name and minor changes to properties in yaml from Rob's comments
   - shtdn-enable-gpios -> powerdown-status-gpios from Krzysztof and
     Jonathan comments in yaml
   - minor changes to driver

Ivan Mikhaylov (2):
  dt-bindings: adc: provide max34408/9 device tree binding document
  iio: adc: Add driver support for MAX34408/9

 .../bindings/iio/adc/maxim,max34408.yaml      | 139 +++++++++
 drivers/iio/adc/Kconfig                       |  11 +
 drivers/iio/adc/Makefile                      |   1 +
 drivers/iio/adc/max34408.c                    | 276 ++++++++++++++++++
 4 files changed, 427 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/maxim,max34408.yaml
 create mode 100644 drivers/iio/adc/max34408.c

Comments

Jonathan Cameron Oct. 18, 2023, 6:32 p.m. UTC | #1 
On Sun, 15 Oct 2023 00:12:52 +0300
Ivan Mikhaylov <fr0st61te@gmail.com> wrote:

> Add Maxim max34408/34409 ADC driver and yaml for it. Until now it
> supports only current monitioring function without overcurrent
> threshold/delay, shutdown delay configuration, alert interrupt.
> 
> Changes from v1:
>    - minor changes from Rob's comments for yaml
>    - add ena, shtdn and make 4 inputs for R sense from Jonathan's comments for yaml
>    - add _REG suffix and make prefix for bitmasks and statuses
>    - add SCALE/OFFSET instead of AVG/PROCESSED from Jonathan and
>      Lars-Peter comments
>    - add chip data from Jonathan and Lars-Peter comments
>    - minor changes from Lars-Peter and Jonathan comments for driver
> 
> Changes from v2:
>    - add channels into hardware description into yaml
>    - add rsense property per channel
>    - rename pins for shtdn and ena pins
>    - make one array for input_rsense values
> 
> Changes from v3:
>    - change *_34408_OCT3 and 4 to *_34409_OCT3 and 4
>    - change of_property_read_u32 to fwnode family calls
>    - add i2c dev table
>    - change of_match_device to i2c_of_match_device
>    - change match->data to i2c_get_match_data 
> 
> Changes from v4:
>    - minor changes in yaml
> 
> Changes from v5:
>    - name and minor changes to properties in yaml from Rob's comments
>    - shtdn-enable-gpios -> powerdown-status-gpios from Krzysztof and
>      Jonathan comments in yaml
>    - minor changes to driver
> 
> Ivan Mikhaylov (2):
>   dt-bindings: adc: provide max34408/9 device tree binding document
>   iio: adc: Add driver support for MAX34408/9
> 
>  .../bindings/iio/adc/maxim,max34408.yaml      | 139 +++++++++
>  drivers/iio/adc/Kconfig                       |  11 +
>  drivers/iio/adc/Makefile                      |   1 +
>  drivers/iio/adc/max34408.c                    | 276 ++++++++++++++++++
>  4 files changed, 427 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/maxim,max34408.yaml
>  create mode 100644 drivers/iio/adc/max34408.c
> 

Series applied to the togreg branch of iio.git and pushed out as testing.
We are very late in the cycle, so this is probably destined for 6.8

Jonathan