mbox series

[v4,0/2] Fix issues observed in selftests/amd-pstate

Message ID 20231012093225.2045109-1-swapnil.sapkal@amd.com
Headers
Series Fix issues observed in selftests/amd-pstate |

Message

Swapnil Sapkal Oct. 12, 2023, 9:32 a.m. UTC 
  This series fixes issues observed with selftests/amd-pstate while
running performance comparison tests with different governors. First
patch changes relative paths with absolute paths and also change it
with correct paths wherever it is broken.
The second patch adds an option to provide perf binary path to
handle the case where distro perf does not work.

Changelog v3->v4:
	* Addressed review comments from v3

Swapnil Sapkal (2):
  selftests/amd-pstate: Fix broken paths to run workloads in
    amd-pstate-ut
  selftests/amd-pstate: Added option to provide perf binary path

 .../x86/amd_pstate_tracer/amd_pstate_trace.py |  3 +--
 .../testing/selftests/amd-pstate/gitsource.sh | 17 +++++++++------
 tools/testing/selftests/amd-pstate/run.sh     | 21 +++++++++++++------
 tools/testing/selftests/amd-pstate/tbench.sh  |  4 ++--
 4 files changed, 29 insertions(+), 16 deletions(-)

Comments

Shuah Khan Oct. 16, 2023, 7:08 p.m. UTC | #1 
On 10/12/23 03:32, Swapnil Sapkal wrote:
> This series fixes issues observed with selftests/amd-pstate while
> running performance comparison tests with different governors. First
> patch changes relative paths with absolute paths and also change it
> with correct paths wherever it is broken.
> The second patch adds an option to provide perf binary path to
> handle the case where distro perf does not work.
> 
> Changelog v3->v4:
> 	* Addressed review comments from v3
> 
> Swapnil Sapkal (2):
>    selftests/amd-pstate: Fix broken paths to run workloads in
>      amd-pstate-ut
>    selftests/amd-pstate: Added option to provide perf binary path
> 
>   .../x86/amd_pstate_tracer/amd_pstate_trace.py |  3 +--
>   .../testing/selftests/amd-pstate/gitsource.sh | 17 +++++++++------
>   tools/testing/selftests/amd-pstate/run.sh     | 21 +++++++++++++------
>   tools/testing/selftests/amd-pstate/tbench.sh  |  4 ++--
>   4 files changed, 29 insertions(+), 16 deletions(-)
> 

Both applied to linux-kselftest next for Linux 6.7-rc1

thanks,
-- Shuah