Message ID | 20231010084731.30450-1-yangyicong@huawei.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp50695vqb; Tue, 10 Oct 2023 01:50:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJsfwjTvgLGjASpVGcFgZ6l2GstrqWZQXL76rrvsvfLjqQzU1X0Jr/vUgDuZAqW/B8QEDB X-Received: by 2002:a05:6a20:5485:b0:143:f4dd:dfae with SMTP id i5-20020a056a20548500b00143f4dddfaemr22882974pzk.43.1696927843916; Tue, 10 Oct 2023 01:50:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696927843; cv=none; d=google.com; s=arc-20160816; b=Inz2mmRwHBjeZ9OXS8LYueOVMBCl+pR+rN/13QH/g4UBBF1urd7cqsmAFMXyBh/fLC 9VjvZx1WnzAGqIdv1r5zpMJe2kQk2uImtsMDglQtQo3qc/CQxmKMAfbmlS7o56Bthmbr vB8YGXyCt/YjRye7ZFKUtkGsUkc4aLsoPT8f09eXzZo67jbmxzR5nyFjhrlJ4//MORCc lQ6EKOTbCxaGQTYRIqyLqa7xDfDNnhDeKbRl/b9p/LcOs4nmox3BC2T51soj1meL/T3T HWTb7pPdurUq4xzmixYFmgX+/0a+Q3KfHp4CdpSXhaGeM4fgHSaED3zqrcuHiyOxJiHJ TdaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=NgwsjWkjc91xqMSxVuyq6Q4zSIr7908TeSbbGjbAXvE=; fh=ko8w2iEBByNlWLnAg6bNI5pex73wZFG+4jwxERcD8TA=; b=a0Vv5viXa99CMPIYWQ8pO76ylggqj8L6TpU2RCigpkmQs5CONJPZpYY5aNZbTWJRZ6 1Bx8FXnZ3/ZqNJ8Dzyc3LtNLnIdBPoWX25CIw1RZCYC9+tShVTa5dQcsKQokcB2TLkGa w6so7aT8HUNcdXFlnjjbqMLr04/egD1E/EFDicE51sSuNDXN5JbctL+nreuPmd3BuyiI QnhLzRpa6Y0t5I72HafEQK9Qx+y1EWY++STny2e2tSKFNtIvV8bjrga+0Aq/RK+vr9rU hw8dskF83LaiiIO8szmzwMifA77QLuRfFCEFIx/Ffgwf5JNO2SvGK0Zwh161Ply4iiuV Mddg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id z41-20020a056a001da900b0068fcf6fe22csi9073183pfw.304.2023.10.10.01.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 01:50:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 53E578134CCD; Tue, 10 Oct 2023 01:50:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229485AbjJJIug (ORCPT <rfc822;rua109.linux@gmail.com> + 20 others); Tue, 10 Oct 2023 04:50:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbjJJIuZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 10 Oct 2023 04:50:25 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 641B1A4; Tue, 10 Oct 2023 01:50:22 -0700 (PDT) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S4Ty03029ztT9c; Tue, 10 Oct 2023 16:45:44 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 10 Oct 2023 16:50:20 +0800 From: Yicong Yang <yangyicong@huawei.com> To: <suzuki.poulose@arm.com>, <mathieu.poirier@linaro.org>, <jonathan.cameron@huawei.com>, <linux-kernel@vger.kernel.org> CC: <alexander.shishkin@linux.intel.com>, <helgaas@kernel.org>, <linux-pci@vger.kernel.org>, <prime.zeng@hisilicon.com>, <linuxarm@huawei.com>, <yangyicong@hisilicon.com>, <hejunhao3@huawei.com> Subject: [PATCH v3 0/5] Several updates for PTT driver Date: Tue, 10 Oct 2023 16:47:26 +0800 Message-ID: <20231010084731.30450-1-yangyicong@huawei.com> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 10 Oct 2023 01:50:43 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779357810906621735 X-GMAIL-MSGID: 1779357810906621735 |
Series |
Several updates for PTT driver
|
|
Message
Yicong Yang
Oct. 10, 2023, 8:47 a.m. UTC
From: Yicong Yang <yangyicong@hisilicon.com>
This series contains several updates for PTT driver:
- Disable interrupt when trace stops, reverse to what we do in trace start
- Always handle the interrupt in hardirq context
- Optimize the AUX buffer handling to make consumer have more time to process
the data
- Since we're a uncore PMU so block any task attach operation
- Add a dummy pmu::read() callback since the perf core may use
Change since v2:
- Add fix tag for Patch 5/5
- refine the commit in Patch 3/5, trying to make it more clear
Link: https://lore.kernel.org/all/20230914112223.27165-1-yangyicong@huawei.com/
Change since v1:
- Add Jonathan's tag, thanks
Link: https://lore.kernel.org/all/20230809081825.11518-1-yangyicong@huawei.com/
Junhao He (1):
hwtracing: hisi_ptt: Add dummy callback pmu::read()
Yicong Yang (4):
hwtracing: hisi_ptt: Disable interrupt after trace end
hwtracing: hisi_ptt: Handle the interrupt in hardirq context
hwtracing: hisi_ptt: Optimize the trace data committing
hwtracing: hisi_ptt: Don't try to attach a task
drivers/hwtracing/ptt/hisi_ptt.c | 33 +++++++++++++++++++++-----------
drivers/hwtracing/ptt/hisi_ptt.h | 1 +
2 files changed, 23 insertions(+), 11 deletions(-)
Comments
Hi Suzuki, a gentle ping.. Hope all previous comments are addressed/clarified. Any further comment on this? Thanks. On 2023/10/10 16:47, Yicong Yang wrote: > From: Yicong Yang <yangyicong@hisilicon.com> > > This series contains several updates for PTT driver: > - Disable interrupt when trace stops, reverse to what we do in trace start > - Always handle the interrupt in hardirq context > - Optimize the AUX buffer handling to make consumer have more time to process > the data > - Since we're a uncore PMU so block any task attach operation > - Add a dummy pmu::read() callback since the perf core may use > > Change since v2: > - Add fix tag for Patch 5/5 > - refine the commit in Patch 3/5, trying to make it more clear > Link: https://lore.kernel.org/all/20230914112223.27165-1-yangyicong@huawei.com/ > > Change since v1: > - Add Jonathan's tag, thanks > Link: https://lore.kernel.org/all/20230809081825.11518-1-yangyicong@huawei.com/ > > Junhao He (1): > hwtracing: hisi_ptt: Add dummy callback pmu::read() > > Yicong Yang (4): > hwtracing: hisi_ptt: Disable interrupt after trace end > hwtracing: hisi_ptt: Handle the interrupt in hardirq context > hwtracing: hisi_ptt: Optimize the trace data committing > hwtracing: hisi_ptt: Don't try to attach a task > > drivers/hwtracing/ptt/hisi_ptt.c | 33 +++++++++++++++++++++----------- > drivers/hwtracing/ptt/hisi_ptt.h | 1 + > 2 files changed, 23 insertions(+), 11 deletions(-) >
On Tue, 10 Oct 2023 16:47:26 +0800, Yicong Yang wrote: > From: Yicong Yang <yangyicong@hisilicon.com> > > This series contains several updates for PTT driver: > - Disable interrupt when trace stops, reverse to what we do in trace start > - Always handle the interrupt in hardirq context I wrapped the commit description to 75 chars for this patch to suppress the following checkpatch warning and queued it. WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #10: change of arm-ccn PMU commit 0811ef7e2f54 ("bus: arm-ccn: fix PMU interrupt flags"). total: 0 errors, 1 warnings, 12 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] hwtracing: hisi_ptt: Handle the interrupt in hardirq context" has style problems, please review. > - Optimize the AUX buffer handling to make consumer have more time to process > the data > - Since we're a uncore PMU so block any task attach operation > - Add a dummy pmu::read() callback since the perf core may use > > [...] Applied, thanks! [1/5] hwtracing: hisi_ptt: Disable interrupt after trace end https://git.kernel.org/coresight/c/4669551e797a [2/5] hwtracing: hisi_ptt: Handle the interrupt in hardirq context https://git.kernel.org/coresight/c/e8b7d8718c51 [3/5] hwtracing: hisi_ptt: Optimize the trace data committing https://git.kernel.org/coresight/c/7a527d4d9273 [4/5] hwtracing: hisi_ptt: Don't try to attach a task https://git.kernel.org/coresight/c/7d52e2cfef91 [5/5] hwtracing: hisi_ptt: Add dummy callback pmu::read() https://git.kernel.org/coresight/c/4708eada8bd6 Best regards,
On 2023/10/18 1:01, Suzuki K Poulose wrote: > On Tue, 10 Oct 2023 16:47:26 +0800, Yicong Yang wrote: >> From: Yicong Yang <yangyicong@hisilicon.com> >> >> This series contains several updates for PTT driver: >> - Disable interrupt when trace stops, reverse to what we do in trace start >> - Always handle the interrupt in hardirq context > > I wrapped the commit description to 75 chars for this patch to suppress the > following checkpatch warning and queued it. Thanks! Will take care next time. > > WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) > #10: > change of arm-ccn PMU commit 0811ef7e2f54 ("bus: arm-ccn: fix PMU interrupt flags"). > > total: 0 errors, 1 warnings, 12 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > "[PATCH] hwtracing: hisi_ptt: Handle the interrupt in hardirq context" has style problems, please review. > > >> - Optimize the AUX buffer handling to make consumer have more time to process >> the data >> - Since we're a uncore PMU so block any task attach operation >> - Add a dummy pmu::read() callback since the perf core may use >> >> [...] > > Applied, thanks! > > [1/5] hwtracing: hisi_ptt: Disable interrupt after trace end > https://git.kernel.org/coresight/c/4669551e797a > [2/5] hwtracing: hisi_ptt: Handle the interrupt in hardirq context > https://git.kernel.org/coresight/c/e8b7d8718c51 > [3/5] hwtracing: hisi_ptt: Optimize the trace data committing > https://git.kernel.org/coresight/c/7a527d4d9273 > [4/5] hwtracing: hisi_ptt: Don't try to attach a task > https://git.kernel.org/coresight/c/7d52e2cfef91 > [5/5] hwtracing: hisi_ptt: Add dummy callback pmu::read() > https://git.kernel.org/coresight/c/4708eada8bd6 > > Best regards, >