Message ID | 20231010-ad2s1210-mainline-v5-0-35a0f6ffa04a@baylibre.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp139804vqb; Tue, 10 Oct 2023 14:13:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHq7Ayo+bJk1egxBXcIwgYG9dGyh36eEoqPudnqhbioaEkvO/sehgiNcrBLXWWIujeFWzTM X-Received: by 2002:a05:6a21:197:b0:14e:2c56:7b02 with SMTP id le23-20020a056a21019700b0014e2c567b02mr24518120pzb.0.1696972414286; Tue, 10 Oct 2023 14:13:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696972414; cv=none; d=google.com; s=arc-20160816; b=VDp/6kSsul+xi7hDa/fdviEngtEiskEylPEzGktI9NLRItvR5wzGYpxWTW2ywBulk7 W+snUl/L2l123PAPS1YYGvmVjkWMaogRC5N83uh3vY4KAxcnU/GTjwyCy14ailcmjJTy +od1s3gxG0JVYNZTSpw5UZnx/DkZXo8eqPyimTK2eDDfYw489hvTjsLfML8qiCbuAci/ vFEapSNva1taCuYt6uEkzIs2p8YdCMOtLshfY18/vqqO1DFuYZ4rI7GLq5lQ96MSAkYA evMoi+bF59D6T8pzcqv2SU+alRI/tTSV2NasxizT7rGxppp23R87QF/HmBtC2PORTvB5 537g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ZlsnSgCmX4sVGhEbLuDndjyGxg5h5NrDjU/cZAb9NoA=; fh=kszEk+gff9dv1Go/VyZgnfqxXXEwVKycZ4FkCeISyE4=; b=SKZMt6R89FcmEbukkPyuNhAYE3k/4kwhoQg4FcBDdtnBW7xqM4UMLQaKfFedGhAmwz 6ji4guA+XHVpgNP7DlQkSkK1AsWpA3IeIFWkPnnYDzhb1JIWonV49XZ8wukO7T5Wqlxc kSX6v8N+i3oQma3SZQ5V+0VwgGfbM75sJZSlh+ATVeliSKOCp4BMdCNyHgdFXqrrOfJU I/ev4+oQnpQvRGDkVAAsFUCle/CcbR0JfwIzic0YWgJAab9HeQJ85yvPPJE6DQJqTrKZ 283onFcWaWxZVyAJL19/oM51R9xwz/Woea5ANosq2+gdj19hTFT+ZtQMAzkkz2QFCH+I wx6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=e+wnQ2qs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id k17-20020a170902c41100b001bbb6f4cd6dsi13856143plk.334.2023.10.10.14.13.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 14:13:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=e+wnQ2qs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 98C5680AA313; Tue, 10 Oct 2023 14:13:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343827AbjJJVM6 (ORCPT <rfc822;rua109.linux@gmail.com> + 19 others); Tue, 10 Oct 2023 17:12:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231768AbjJJVM5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 10 Oct 2023 17:12:57 -0400 Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C35F491 for <linux-kernel@vger.kernel.org>; Tue, 10 Oct 2023 14:12:54 -0700 (PDT) Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-1dd7139aa57so4236184fac.1 for <linux-kernel@vger.kernel.org>; Tue, 10 Oct 2023 14:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1696972374; x=1697577174; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZlsnSgCmX4sVGhEbLuDndjyGxg5h5NrDjU/cZAb9NoA=; b=e+wnQ2qs0C2gnuUTCNTcfEjEPy0svVm1gsQk8+hd78V6e/jbRXGgTyBXBNt+C7Y+L5 oib4Tv9G1L198ceTJUg2s4NZCZamUFiCYtdL8C9lfaPfeXLZIil4mhcoACqqEFyYMhMu rj2WM8dD542jLdAB7h5DzEYRo2TuG7kF78aUmb6+mYm4OJRig57/i9zfhftILknyJIke ICKyTsm/Dq8SdUadMKUXASj8OrbfiO204JzgteWiqIlHJGg3PKGwZRbLqs86EUGvuUk/ yuhyV7xSOi+XlKJwbgX4toY3uE25XPqpVDwzARbCkaXR4pcusdRxBIzfUFJxWK+1HF/x VReA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696972374; x=1697577174; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZlsnSgCmX4sVGhEbLuDndjyGxg5h5NrDjU/cZAb9NoA=; b=BGIHINUg02uJn49ej4NNaXoceArVLjJvK69iufRJVRNMkPVtcFd60l5N/MMs8QXY1X 7hJSmxeI/tuXjbdyWt0MHIJuUUSZc441sel4B9+K4BBjAMbp5lVB10bnj25ePyf7DlX8 /9mXyVchXH8ehjxMdvnGV2bGJvedg2lVb4UdzfWteGvrMboPrdQkl5QLXPRBeWRQCWIo paKoTKEjuDuD4nSi8IqG1l1PblU53qKuQlFvVx4gik3muEtv7PGTTQPdHlI5ePJ3iiNd JXt4nFFRLaUuYjxAVeC2s6e26aJvCs1dPNyiTi/DtmJCPq7yHaFLnEEq1M2Mhi1KDQz9 PpKQ== X-Gm-Message-State: AOJu0Yy6Sn+ksjsaL/Q0giaKi658pMDzY0aOtRy3Tglvl/geaZVJI/CY 3fBv3N1tLWNxdc2caO9wY60LwA== X-Received: by 2002:a05:6870:808a:b0:1a6:c968:4a15 with SMTP id q10-20020a056870808a00b001a6c9684a15mr22571454oab.4.1696972374046; Tue, 10 Oct 2023 14:12:54 -0700 (PDT) Received: from freyr.lechnology.com (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id ed46-20020a056870b7ae00b001e98b1544fesm52494oab.9.2023.10.10.14.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 14:12:53 -0700 (PDT) From: David Lechner <dlechner@baylibre.com> To: linux-iio@vger.kernel.org, linux-staging@lists.linux.dev Cc: David Lechner <dlechner@baylibre.com>, Jonathan Cameron <jic23@kernel.org>, Michael Hennerich <Michael.Hennerich@analog.com>, =?utf-8?q?Nuno_S=C3=A1?= <nuno.sa@analog.com>, Axel Haslam <ahaslam@baylibre.com>, Philip Molloy <pmolloy@baylibre.com>, linux-kernel@vger.kernel.org Subject: [PATCH v5 0/4] iio: resolver: move ad2s1210 out of staging Date: Tue, 10 Oct 2023 16:12:32 -0500 Message-ID: <20231010-ad2s1210-mainline-v5-0-35a0f6ffa04a@baylibre.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.12.3 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 10 Oct 2023 14:13:24 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779404546458498892 X-GMAIL-MSGID: 1779404546458498892 |
Series |
iio: resolver: move ad2s1210 out of staging
|
|
Message
David Lechner
Oct. 10, 2023, 9:12 p.m. UTC
This series is working towards moving the ad2s1210 resolver driver out of staging (after 13 years!). It involves a bunch of fixes and improvements to make proper device tree bindings and use standard IIO sysfs attributes. This series has been tested on actual hardware using a EVAL-AD2S1210 evaluation board. (Note: not all device tree features have been implemented in the driver since the eval board doesn't support them out of the box. We plan to add them later if needed.) --- v5 changes: * Dropped applied patches: * "staging: iio: resolver: ad2s1210: do not use fault register for dummy read" * "staging: iio: resolver: ad2s1210: implement hysteresis as channel attr" * "staging: iio: resolver: ad2s1210: convert fexcit to channel attribute" * "staging: iio: resolver: ad2s1210: convert resolution to devicetree property" * "staging: iio: resolver: ad2s1210: add phase lock range support" * "staging: iio: resolver: ad2s1210: add triggered buffer support" * "staging: iio: resolver: ad2s1210: convert LOT threshold attrs to event attrs" * "staging: iio: resolver: ad2s1210: convert LOS threshold to event attr" * "staging: iio: resolver: ad2s1210: convert DOS overrange threshold to event attr" * "staging: iio: resolver: ad2s1210: convert DOS mismatch threshold to event attr" * "staging: iio: resolver: ad2s1210: rename DOS reset min/max attrs" * "iio: event: add optional event label support" * "staging: iio: resolver: ad2s1210: implement fault events" * "staging: iio: resolver: ad2s1210: add register/fault support summary" * "staging: iio: resolver: ad2s1210: add label attribute support" * "staging: iio: resolver: ad2s1210: remove fault attribute" * Added new patches: * "staging: iio: resolver: ad2s1210: refactor sample toggle" * "staging: iio: resolver: ad2s1210: clear faults after soft reset" * "iio: resolver: ad2s1210: move out of staging" Link to v4: https://lore.kernel.org/r/20231005-ad2s1210-mainline-v4-0-ec00746840fc@baylibre.com v4 changes: * Dropped applied patches: * "dt-bindings: iio: resolver: add devicetree bindings for ad2s1210" * "staging: iio: resolver: ad2s1210: read excitation frequency from control register" * "staging: iio: resolver: ad2s1210: refactor setting excitation frequency" * "staging: iio: resolver: ad2s1210: rework gpios" * "staging: iio: resolver: ad2s1210: remove config attribute" * "staging: iio: resolver: ad2s1210: add debugfs reg access" * "staging: iio: resolver: ad2s1210: use regmap for config registers" * "staging: iio: resolver: ad2s1210: use devicetree to get CLKIN rate" * "staging: iio: resolver: ad2s1210: implement IIO_CHAN_INFO_SCALE" * "staging: iio: resolver: ad2s1210: always use 16-bit value for raw read" * "staging: iio: resolver: ad2s1210: sort imports" * "staging: iio: resolver: ad2s1210: remove spi_set_drvdata()" * "staging: iio: resolver: ad2s1210: check return of ad2s1210_initial()" * "staging: iio: resolver: ad2s1210: remove call to spi_setup()" * "staging: iio: resolver: ad2s1210: fix use before initialization" * Added new patches: * "staging: iio: resolver: ad2s1210: do not use fault register for dummy read" * "iio: event: add optional event label support" * "staging: iio: resolver: ad2s1210: add register/fault support summary" * "staging: iio: resolver: ad2s1210: remove fault attribute" * "staging: iio: resolver: ad2s1210: simplify code with guard(mutex)" * Fixed DT property name in commit description of "staging: iio: resolver: ad2s1210: convert resolution to devicetree property" * Fixed compile error in "staging: iio: resolver: ad2s1210: implement fault events". * Fixed angl0 hysteresis raw values when assigned-resolution-bits != 16. * Fixed missing word in "staging: iio: resolver: ad2s1210: convert DOS overrange threshold to event attr" commit description. * Fixed missing static qualifier on event attribute definitions. * Dropped used of X/Y modifiers on sine/cosine channels. * Changed type/direction on some events. * Added event *_label attributes. Link to v3: https://lore.kernel.org/r/20230929-ad2s1210-mainline-v3-0-fa4364281745@baylibre.com v3 changes: * Dropped applied patches: * "staging: iio: resolver: ad2s1210: fix ad2s1210_show_fault" * "staging: iio: resolver: ad2s1210: fix not restoring sample gpio in channel read" * Dropped "staging: iio: Documentation: document IIO resolver AD2S1210 sysfs attributes". We will attempt to use existing ABI for faults/ thresholds in a future series. * Added description of A0/A1 lines in DT bindings. * Added power supply regulators to DT bindings. * Moved sorting imports to separate patch. * Renamed fclkin to clkin_hz. * Added __be16 sample field to state struct for reading raw samples. * Split out new function ad2s1210_single_conversion() from ad2s1210_read_raw(). * Split out new ad2s1210_get_hysteresis() and ad2s1210_set_hysteresis() functions. * Fixed multi-line comment style. * Added notes about soft reset not resetting config registers. * Made use of FIELD_PREP() macro. * Added more explanation to regmap commit message. * Removed datasheet names from channel specs. * Replaced "staging: iio: resolver: ad2s1210: rename fexcit attribute" with "staging: iio: resolver: ad2s1210: convert fexcit to channel attribute". * Replaced "staging: iio: resolver: ad2s1210: add phase_lock_range attributes" with "staging: iio: resolver: ad2s1210: add phase lock range support" * Added additional patches to convert custom device attributes to event attributes. * Added patch for to add label attributes. Link to v2: https://lore.kernel.org/r/20230921144400.62380-1-dlechner@baylibre.com v2 changes: * Address initial device tree patch feedback * Drop "iio: sysfs: add IIO_DEVICE_ATTR_NAMED_RW macro" (related cleanups also dropped for now, will address in a future series if needed) * Apply improvements as a series of patches to the staging driver. It is not quite ready for the move out of staging patch yet. --- David Lechner (4): staging: iio: resolver: ad2s1210: refactor sample toggle staging: iio: resolver: ad2s1210: clear faults after soft reset staging: iio: resolver: ad2s1210: simplify code with guard(mutex) iio: resolver: ad2s1210: move out of staging .../ABI/testing}/sysfs-bus-iio-resolver-ad2s1210 | 0 drivers/iio/resolver/Kconfig | 13 ++ drivers/iio/resolver/Makefile | 1 + drivers/{staging => }/iio/resolver/ad2s1210.c | 208 ++++++++++----------- drivers/staging/iio/Kconfig | 1 - drivers/staging/iio/Makefile | 1 - drivers/staging/iio/resolver/Kconfig | 19 -- drivers/staging/iio/resolver/Makefile | 6 - 8 files changed, 109 insertions(+), 140 deletions(-) --- base-commit: 57fd97ead0e87ca528736f1945a3ba3096de2f3e change-id: 20230925-ad2s1210-mainline-2791ef75e386 Best regards,