From patchwork Mon Oct 9 12:19:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yang X-Patchwork-Id: 15095 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp1827286vqo; Mon, 9 Oct 2023 05:20:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFvRfjgB6TbLtTgyV78OKf3oBrw7+3tx2CuW4IGTXmJQfK7lKiGJ2uV8zedMqvt5Y2/kHIu X-Received: by 2002:a05:6a20:8f1f:b0:13d:5b8e:db83 with SMTP id b31-20020a056a208f1f00b0013d5b8edb83mr16783489pzk.9.1696854039142; Mon, 09 Oct 2023 05:20:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696854039; cv=none; d=google.com; s=arc-20160816; b=KZhggkT6xOe7YsxXHjs+l4KXr+IYA9QNcK/yp6oP5GEGZ1fyWYpbDULBpEO4ecSNHb oLR81nCf4L20ARUuwIvugDTPXdygVWH/0gPwjVEs6DvWqEJS/Or+DccouSUPMM1UCBF5 3zgvBQho23Qw4xVb1Yp0aEhVErOwbkYxoAsbO2463TTNT0JX2707oQapdM1WKQ37wl8l 05Rr6gfDH7q72TnkFQPEGQHYTNd1x6YNj4+XN8zU3Y8cx/dpyeiEJgWWv9rKOIam10pG lx3UpsFRZ+pzXRfgKWSwnJ3Hqx5zfTNzrHmXZqJ6uEM+UBIDdV3Hiaaq2rx67j8nS/Qu LKSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:references :in-reply-to:message-id:date; bh=SGuTye89iG7ePXACzqo8uDHnnNoUxX/BYQdC+hwxdUk=; fh=QA5pAs70psIMGwCg98gn5bGA5RYRu0ubnZRcj3fF3SU=; b=V8ocQkk1Sw0sdZNWyJL4qKd+dLt/CRIcBRkgqV5YI3tSHtr8z+RCXtjrF+K+F2hzGi z+pSYLGKNh9QtoI5zzZ/1FlNhnyztbM/CwuY0cMFEpYju5aWQasU5ddvvYpcj2z1/I/L B1skbBWvgj+x4tQe88vcZM5l721mIHnaYRzzA5QG8O/5c3JgNvyg6eyQxJMI0duWnAHZ uedfXO1Ss47Y3SPKsYa9uN+cihBMMUBvE39H/aOQYtydHvNcgLvlbQ4ecN0dIqxO69aE 6Rm9lT2FjpLmAcMJwwfvZEcL/qzmgFLyG6Ww4p3NUVwJtWwozxRjjXxYTHRycYHuplzW QLyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id kp13-20020a170903280d00b001c3e13018ffsi9198897plb.51.2023.10.09.05.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:20:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id C9EA68050F9F; Mon, 9 Oct 2023 05:20:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346651AbjJIMUX (ORCPT + 18 others); Mon, 9 Oct 2023 08:20:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346640AbjJIMUJ (ORCPT ); Mon, 9 Oct 2023 08:20:09 -0400 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEF61CA for ; Mon, 9 Oct 2023 05:19:14 -0700 (PDT) Received: from mxct.zte.com.cn (unknown [192.168.251.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4S3ykk1fcMz8XrRJ for ; Mon, 9 Oct 2023 20:19:10 +0800 (CST) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4S3ykb5bS6z4xVbr; Mon, 9 Oct 2023 20:19:03 +0800 (CST) Received: from szxlzmapp05.zte.com.cn ([10.5.230.85]) by mse-fl1.zte.com.cn with SMTP id 399CJ1NO046217; Mon, 9 Oct 2023 20:19:01 +0800 (+08) (envelope-from yang.yang29@zte.com.cn) Received: from mapi (szxlzmapp02[null]) by mapi (Zmail) with MAPI id mid14; Mon, 9 Oct 2023 20:19:05 +0800 (CST) Date: Mon, 9 Oct 2023 20:19:05 +0800 (CST) X-Zmail-TransId: 2b046523efb95fa-35ade X-Mailer: Zmail v1.0 Message-ID: <202310092019052043489@zte.com.cn> In-Reply-To: References: CAJuCfpHV+Tf+-YqdWFwQNAeQJU5aqOM56R2GzbehFaFQcHuxAg@mail.gmail.com,202310071421311735972@zte.com.cn,ZSPayGSz6HQBp+3W@gmail.com Mime-Version: 1.0 From: To: , , Cc: , , , Subject: =?utf-8?q?=5BPATCH_linux-next_0/3=5D_sched/psi=3A_Optimize_the?= =?utf-8?q?=C2=A0process_of_updating_triggers_and=C2=A0rtpoll=5Ftotal?= X-MAIL: mse-fl1.zte.com.cn 399CJ1NO046217 X-Fangmail-Gw-Spam-Type: 0 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 6523EFBE.000/4S3ykk1fcMz8XrRJ X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 09 Oct 2023 05:20:36 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779280421342744975 X-GMAIL-MSGID: 1779280421342744975 From: Yang Yang When psimon wakes up and there are no state changes for rtpoll_states, it's unnecessary to update triggers and rtpoll_total because the pressures being monitored by user have not changed. This will help to slightly reduce unnecessary computations of psi. There are also some minor related optimizations, please see below. The parameter update_total in update_triggers() is useless now. Since if changed_states & group->rtpoll_states is true, new_stall in update_triggers() will be true, then update_total should also be true. We have no need for update_total to help judgment whether to update rtpoll_total, so delete update_total. Update_triggers() always return now + group->rtpoll_min_period, and the return value is only used by psi_rtpoll_work(), so change update_triggers() to a void function, let group->rtpoll_next_update = now + group->rtpoll_min_period directly. Yang Yang(3): sched/psi: Change update_triggers() to a void function sched/psi: Avoid update triggers and rtpoll_total when it is unnecessary sched/psi: Delete the function parameter update_total of update_triggers() kernel/sched/psi.c | 23 ++++++----------------- 1 file changed, 6 insertions(+), 17 deletions(-)