From patchwork Mon Oct 9 15:51:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?K=C3=B6ry_Maincent?= X-Patchwork-Id: 15104 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp1961172vqo; Mon, 9 Oct 2023 08:52:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTr7xiltzuYxVo6DGR/CqHYDFEEg+Qhfk67VL3COvrk6kbg1iimpFp1p6PJk0TpKN/la40 X-Received: by 2002:a17:903:230b:b0:1c7:3558:721a with SMTP id d11-20020a170903230b00b001c73558721amr18308569plh.58.1696866728700; Mon, 09 Oct 2023 08:52:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696866728; cv=none; d=google.com; s=arc-20160816; b=TWDzq6/YEa2JyrMve4R2B0h8AxzY8CTG6XadMWqC7H0QWC5hcHiqP4zfr8nEdqfO9g eD7BUv/lvQjNf33+lAd2yGpy/Dl42PhNnrdnxwohJRIruIqlTmUYPGlIoJs7zHhyJEMr JFudR+6Xq718gMAp6XpLONJ927sBdz6TedZbCbNhvaCzk4D3wscZIVf6QZVi/skyP2iA tuSwc9xM4AUYu3IepcA1iN7XGaGe4qBirfxAOIXGLCn0RLvCQsCgRpvE/rFioUI0CAk6 7VwCameAZ3xXMdJ0Jc0ckkvVUlCImoXAyry1RoiAVosTDukSQMyQ2Mu3b+4gdPwn0I62 j7QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=d+vplipnnIWIzmNSzthBNOqx4T8NoqkpkC2gykdesK8=; fh=G6KN1zqmJBGIhpPSq1AWsD4aWgSLDy1jBh7tZkBaukM=; b=mZ+8sJTPIm0jxfxOWQ1PDSIZSpUO58dT74L6TVbmm1iyoJmOvI9MOc+QGFugYcxQgH YiUkgcwyt8Fc87QKggFXesDDeIF1sU4Gyfvi/RZlTMeBzxTLq3QbIDUUVOUMUMwAf4tl GOK+cQ3yPGdWm1vbxbK8OT6iGIBjiAZ98M0G5sMx0NmkN6wR1jsaOnmmqXrGLWkWUcrB dp/qlsAO+1YCJMFGwngWaI0fcdvx2lp9j8dAnv3P8pky1RnVJogFtKH5esUABD9Yn+I5 t6HdcJ7pKO8M3uGUnCNFRN55bSV6VPSQy6b3bElAkUYvwXkWhzoA4IC65ppLmmgT/Q/H mEbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=FNpZC8N6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id s9-20020a170902c64900b001c5b9ef1d34si9167521pls.340.2023.10.09.08.52.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 08:52:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=FNpZC8N6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 959F2801C1E1; Mon, 9 Oct 2023 08:52:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377078AbjJIPvv (ORCPT + 18 others); Mon, 9 Oct 2023 11:51:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377063AbjJIPvs (ORCPT ); Mon, 9 Oct 2023 11:51:48 -0400 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C525D6; Mon, 9 Oct 2023 08:51:46 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 55EF11C0003; Mon, 9 Oct 2023 15:51:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696866705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=d+vplipnnIWIzmNSzthBNOqx4T8NoqkpkC2gykdesK8=; b=FNpZC8N6MIxp3OfN4IJMd1lHXfjnF2RXmlnDiH3Lx6GEdspNWJYG84yxHvA4GBA+AHeyOF kaU+5AM3NDtGR1Ew+fpdjwD7Vhtp5bv+ZrDNk7PcHAXR8cxdYRyaVac4llbF4BsOgPf9dA Lukykm3s1ERmcXdIff/lBjWYXtLSUH6cU0trifpPLlqOAXcOe6/y+x+UO4lyOaY5S7SmNV cD3VX09c3pmNC2zdX0PVBAeiu7HmGZU/1S3gZ6XGsLC/daCTLoVrOCD++KuI4oJxtiCIeD IV7GhOJ4aovV1tjG70sSYLaANw8hJOrHJMN0kAAXlzopIeiyZ7A77uqp1bl2EQ== From: =?utf-8?q?K=C3=B6ry_Maincent?= To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: Thomas Petazzoni , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Horatiu Vultur , UNGLinuxDriver@microchip.com, Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Radu Pirea , Willem de Bruijn , Vladimir Oltean , Michael Walle , Jacob Keller , Maxime Chevallier , Kory Maincent Subject: [PATCH net-next v5 00/16] net: Make timestamping selectable Date: Mon, 9 Oct 2023 17:51:22 +0200 Message-Id: <20231009155138.86458-1-kory.maincent@bootlin.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-GND-Sasl: kory.maincent@bootlin.com X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 09 Oct 2023 08:52:01 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779293726738286433 X-GMAIL-MSGID: 1779293726738286433 From: Kory Maincent Up until now, there was no way to let the user select the layer at which time stamping occurs. The stack assumed that PHY time stamping is always preferred, but some MAC/PHY combinations were buggy. This series updates the default MAC/PHY default timestamping and aims to allow the user to select the desired layer administratively. Changes in v2: - Move selected_timestamping_layer variable of the concerned patch. - Use sysfs_streq instead of strmcmp. - Use the PHY timestamp only if available. Changes in v3: - Expose the PTP choice to ethtool instead of sysfs. You can test it with the ethtool source on branch feature_ptp of: https://github.com/kmaincent/ethtool - Added a devicetree binding to select the preferred timestamp. Changes in v4: - Move on to ethtool netlink instead of ioctl. - Add a netdev notifier to allow packet trapping by the MAC in case of PHY time stamping. - Add a PHY whitelist to not break the old PHY default time-stamping preference API. Change in v5: - Update to ndo_hwstamp_get/set. This bring several new patches. - Add few patches to make the glue. - Convert macb to ndo_hwstamp_get/set. - Add netlink specs description of new ethtool commands. - Removed netdev notifier. - Split the patches that expose the timestamping to userspace to separate the core and ethtool development. - Add description of software timestamping. - Convert PHYs hwtstamp callback to use kernel_hwtstamp_config. Kory Maincent (15): net: Convert PHYs hwtstamp callback to use kernel_hwtstamp_config net: phy: Remove the call to phy_mii_ioctl in phy_hwstamp_get/set net: macb: Convert to ndo_hwtstamp_get() and ndo_hwtstamp_set() net: Make dev_set_hwtstamp_phylib accessible net_tstamp: Add TIMESTAMPING SOFTWARE and HARDWARE mask net: phy: micrel: fix ts_info value in case of no phc net: ethtool: Add a command to expose current time stamping layer netlink: specs: Introduce new netlink command to get current timestamp net: ethtool: Add a command to list available time stamping layers netlink: specs: Introduce new netlink command to list available time stamping layers net: Replace hwtstamp_source by timestamping layer net: Change the API of PHY default timestamp to MAC net: ethtool: ts: Update GET_TS to reply the current selected timestamp net ethtool: net: Let the active time stamping layer be selectable netlink: specs: Introduce time stamping set command Richard Cochran (1): net: ethtool: Refactor identical get_ts_info implementations. Documentation/netlink/specs/ethtool.yaml | 57 +++++ Documentation/networking/ethtool-netlink.rst | 63 ++++++ drivers/net/bonding/bond_main.c | 27 +-- drivers/net/ethernet/cadence/macb.h | 15 +- drivers/net/ethernet/cadence/macb_main.c | 42 +++- drivers/net/ethernet/cadence/macb_ptp.c | 28 +-- .../ethernet/microchip/lan966x/lan966x_main.c | 6 +- drivers/net/macvlan.c | 14 +- drivers/net/phy/bcm-phy-ptp.c | 15 +- drivers/net/phy/dp83640.c | 24 +- drivers/net/phy/micrel.c | 44 ++-- drivers/net/phy/mscc/mscc_ptp.c | 18 +- drivers/net/phy/nxp-c45-tja11xx.c | 17 +- drivers/net/phy/phy.c | 28 ++- drivers/net/phy/phy_device.c | 68 ++++++ drivers/ptp/ptp_ines.c | 16 +- include/linux/ethtool.h | 8 + include/linux/mii_timestamper.h | 4 +- include/linux/net_tstamp.h | 11 +- include/linux/netdevice.h | 8 + include/linux/phy.h | 6 +- include/uapi/linux/ethtool_netlink.h | 29 +++ include/uapi/linux/net_tstamp.h | 22 ++ net/8021q/vlan_dev.c | 15 +- net/core/dev.c | 3 + net/core/dev_ioctl.c | 42 ++-- net/core/timestamping.c | 9 + net/ethtool/Makefile | 2 +- net/ethtool/common.c | 22 +- net/ethtool/common.h | 1 + net/ethtool/netlink.c | 28 +++ net/ethtool/netlink.h | 4 + net/ethtool/ts.c | 210 ++++++++++++++++++ 33 files changed, 707 insertions(+), 199 deletions(-) create mode 100644 net/ethtool/ts.c