mbox series

[0/2] lib: unload lib/bitmap.c

Message ID 20231007233510.2097166-1-yury.norov@gmail.com
Headers
Series lib: unload lib/bitmap.c |

Message

Yury Norov Oct. 7, 2023, 11:35 p.m. UTC 
  The file is intended to hold functions to operate on bit arrays, but
this days, more than 1/3 of bitmap.c is helpers for bitmap-to-string
converters, plus some wrappers for device.h.

So move those out of lib/bitmap.c in sake of readability and
maintainability.

Functionally, this series is a no-op.

Yury Norov (2):
  lib/bitmap: move bitmap allocators for device to linux/device.h
  lib/bitmap: split-out string-related operations to a separate files

 MAINTAINERS                |   2 +
 include/linux/bitmap-str.h |  16 ++
 include/linux/bitmap.h     |  25 +-
 include/linux/device.h     |  30 ++
 lib/Makefile               |   2 +-
 lib/bitmap-str.c           | 510 ++++++++++++++++++++++++++++++++++
 lib/bitmap.c               | 545 -------------------------------------
 7 files changed, 560 insertions(+), 570 deletions(-)
 create mode 100644 include/linux/bitmap-str.h
 create mode 100644 lib/bitmap-str.c

Comments

Yury Norov Oct. 15, 2023, 2:32 a.m. UTC | #1 
On Sat, Oct 07, 2023 at 04:35:08PM -0700, Yury Norov wrote:
> The file is intended to hold functions to operate on bit arrays, but
> this days, more than 1/3 of bitmap.c is helpers for bitmap-to-string
> converters, plus some wrappers for device.h.
> 
> So move those out of lib/bitmap.c in sake of readability and
> maintainability.
> 
> Functionally, this series is a no-op.
> 
> Yury Norov (2):
>   lib/bitmap: move bitmap allocators for device to linux/device.h
>   lib/bitmap: split-out string-related operations to a separate files

OK, then if no objections, I drop #1 as a controversial, and pull #2
into bitmap-for-next.
Greg KH Oct. 16, 2023, 6:38 p.m. UTC | #2 
On Sat, Oct 14, 2023 at 07:32:28PM -0700, Yury Norov wrote:
> On Sat, Oct 07, 2023 at 04:35:08PM -0700, Yury Norov wrote:
> > The file is intended to hold functions to operate on bit arrays, but
> > this days, more than 1/3 of bitmap.c is helpers for bitmap-to-string
> > converters, plus some wrappers for device.h.
> > 
> > So move those out of lib/bitmap.c in sake of readability and
> > maintainability.
> > 
> > Functionally, this series is a no-op.
> > 
> > Yury Norov (2):
> >   lib/bitmap: move bitmap allocators for device to linux/device.h
> >   lib/bitmap: split-out string-related operations to a separate files
> 
> OK, then if no objections, I drop #1 as a controversial, and pull #2
> into bitmap-for-next.

That's fine with me, thanks.

greg k-h