From patchwork Wed Oct 4 16:16:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 14926 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:254a:b0:403:3b70:6f57 with SMTP id hf10csp247895vqb; Wed, 4 Oct 2023 09:17:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEX2dOHaz/aSEp3p1MheTiM0yAC/mguOecBHpUTnM9kbBpdVKXYraVY0VcZc3ZjEMMN/8hT X-Received: by 2002:a05:6358:720f:b0:143:5697:b682 with SMTP id h15-20020a056358720f00b001435697b682mr3713815rwa.24.1696436262833; Wed, 04 Oct 2023 09:17:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1696436262; cv=pass; d=google.com; s=arc-20160816; b=0h9z177Z02EMUI++nkj1ELGjlQdlgrS4/oC/KG5hEDK4LXuAeDS5PZlSTn4hQRI8UF Nl2CDNnFBG4yYvKCR2NDqGYARA+nONiAi6UE6HBOSYwHden07QQLDA8bWva+uSGTfwx1 YvVOgZ96v94UR0cFwUPVaQ1pqu0vBvVXxBjbh0wgWdrYAXNLZP0SqL1OPy2Sp/dwmbfT zqCuMcEEBR2lISoG35kN9He5Tq/appQsdD7l4RjrhCYGCBastu+CsGbh41qV2sQlDAUG GoaY8TSRmaPzxyHYAAnUNH87U0Iemn+GwF0kYHPL+5x5WTU4aaUcvVH1SsB38zQqdK6C lRzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=T5pusBspMFJdz8Nbczdfqv2EwTWgulJlEx81GdPzMa8=; fh=M28ys7dR9+fMW6Pr0elMIiY3AX3h/ADN6VduvSx2I6c=; b=UMibxbhoKSXhHqeFCW0oxVWomX7Gls4je+STgumdD5p1kx4zT75/lHuU6fiyxBPr+x yM8N24+fJaRagIwjC22z+3N9JawzyfGxD6JGoNypiWwYhJRoWPOtRISmfEzNmjzltzdC UfeUgQJBisXyFgS/9MOfhqoMePmha3ljF9okHxGco0Xfc8n184cp3aP1VJppgdGddaBS BDYvFzKndce+xEZUBDJoJXhmAZhakJFi28Oc2Un0iigQvzuAyvORA8CDDBD/b0cdsBb8 AEQP74QT09EHZSvrUfZykHJ+37alRB2bqpPKg2PYI56fPm+ePdSbdfjFfFPREjOiH+sW 2qCg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=tMAPNTVo; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id d1-20020a056a00244100b00696f1c14972si1380413pfj.208.2023.10.04.09.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 09:17:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=tMAPNTVo; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id CF4CF80A2184; Wed, 4 Oct 2023 09:17:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233477AbjJDQRf (ORCPT + 19 others); Wed, 4 Oct 2023 12:17:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233486AbjJDQRf (ORCPT ); Wed, 4 Oct 2023 12:17:35 -0400 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2044.outbound.protection.outlook.com [40.107.212.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81B96A9 for ; Wed, 4 Oct 2023 09:17:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BuwF52tdaMAePjIji27BuvX+N1BP6XxL9Z65lP9szn8oWN0TyWfXWzfd+s+RUr2Iw5HyVmMTO83eJB3qTX+FUg6P4H842o737joCDpE0MOUp5gTsKZ1Vz+x5IR9g3JMWNzt/3i0ImsTsE3UZk4lmnYKrklrmeNImHQXeC7P0gWLR85owWPFx1zYk3wD6/T3Uex0L3a/WD1Ptggq4Vt7kfeSdG1AOV55op3rAU3KWhX4+rwCSO/+AA7fMVKphGus89No34Q+3peRcTmlSYoKDCdCDngGwy+vZ2m0USs7+5j9Bc25Det1iT42Vi2ZeJPtWC4tDl9T8WzEO3iC+54VDog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T5pusBspMFJdz8Nbczdfqv2EwTWgulJlEx81GdPzMa8=; b=GPIadkdLdeCTzugL8rXvYqGMidlNEKA54UR0Zu1NBte+v99EikCuT1bPttBF99i8XTqj9mpSFHjtJcM1qCeUjUrLYBMzsSKkclgqvWnCmToOg2Yb93WRVzd9A53k0Xddy820TAF7I2JAjMX2DQACtetioe1iAi/BbavCIwKFYtMyjIksNI1E4ePZ1J3R8oyYW7TtiwE8zkJKSs0CvVzJ2q0njD/ZHrdyy+JZFq0wh8HYOKWtHjZioD6zttoSSFUCVqWOuGSoSt4Za4davJCYriDK9NbySeCUjpV8IFYr4DCAUZ1/4nJmhsq/aEZLKi0pVD/qC5ZnxebKjWm86E8zIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T5pusBspMFJdz8Nbczdfqv2EwTWgulJlEx81GdPzMa8=; b=tMAPNTVo4dL7cafwvJDH1dBOO6H97TaNYKSPtCzh8MZXyGA/OsZe+lO4wb52aJp8l/yQPRtSwExxENkBwFUKuLTUka2fs5d59rXSDj6iAWUSoQ8knsiGiT+zGkY7SUyvJzOU2Mb4ny9LhrqrmC0AaMJIVM3CQC1TpXyWnw3PKmI= Received: from PA7P264CA0518.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:3db::15) by BY5PR12MB4952.namprd12.prod.outlook.com (2603:10b6:a03:1d8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.36; Wed, 4 Oct 2023 16:17:27 +0000 Received: from SA2PEPF00001509.namprd04.prod.outlook.com (2603:10a6:102:3db:cafe::6a) by PA7P264CA0518.outlook.office365.com (2603:10a6:102:3db::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.27 via Frontend Transport; Wed, 4 Oct 2023 16:17:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF00001509.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6838.14 via Frontend Transport; Wed, 4 Oct 2023 16:17:26 +0000 Received: from rtg-Artic.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 4 Oct 2023 11:17:21 -0500 From: Arvind Yadav To: , , , , , , , CC: , , , Arvind Yadav Subject: [PATCH v3 0/2] drm/amdkfd: Fix unaligned doorbell absolute offset for gfx8 Date: Wed, 4 Oct 2023 21:46:50 +0530 Message-ID: <20231004161652.3082-1-Arvind.Yadav@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001509:EE_|BY5PR12MB4952:EE_ X-MS-Office365-Filtering-Correlation-Id: 41137fae-046f-40cf-0e1b-08dbc4f5665b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KQbXHuUoPIaMp7eHTCk1+0X6M7t0v6OAPaa26GOBob5oC3/M9p60HrpuJ0QsD+J81tvDCOPQb7ylpJBtBpeJnUojxlOYq7iwCKxXR0Yx0K5cx0bkV1WQd6yr9G6fZuwxuGn+kFNssLVi5JXHfq0VNkOjU4p9h6bksWyGl9bGQYrNHabS+QVZ15FKAwN4XWVxoWJsiddSqq6KlfWmTCS6apkv0Vl2zm3DIbNNGmNM6ZXENoYKsAEiYzAZA5IhVsD6d2n2e6tetov6iHS3Vh16hFYpUiLASpFyyC0aqCUwUnUo2CziKco1yh7stAjTHlBIBDZRp7GNYUxyAImHET9RcRNUVhUV3qDF9LNNgWqhBa7lbyEuGMY4ER+mgrJGoamQ0xeBanCbVDZPgeXLhw3zhF/pmYINPgi+gbBp9bknPheTuquxzsZXtlQ/FgWfc3Tuq0RVIAGpaGXG2elvyA6QG6Pu7Q0y3RflC7xcy8cCofMzdxk/65zbHfTBFZruiZMDZ1/0EswJjrF9f6/BZxpMNRSXDLxfab1CN3/8MHhQ2HZA6PhJkv0urPQKYJ2uhlLeCNRaAhFppHbuX7nN+mx93QBMgM00BHuF6hkDwlqkKxvrfsrj30oEgU622wl6GXOrcKn0FE2aAbwQCrqV+rAzxRc4aJV+zb8/AqOxzLoUtrXMcIeEennoIXwDMk2bZLP+CMQhaglubFFZiXZrN+v3odvc4AktANmbaUSYONIKViqQHxwX8+kiBzPEDbCx68LAFIQ7UMdwj3uDf/kQEhtkzg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(376002)(346002)(396003)(136003)(39860400002)(230922051799003)(64100799003)(82310400011)(451199024)(1800799009)(186009)(40470700004)(36840700001)(46966006)(41300700001)(40480700001)(316002)(54906003)(70206006)(110136005)(70586007)(478600001)(6666004)(40460700003)(36756003)(86362001)(2906002)(4744005)(8676002)(8936002)(4326008)(5660300002)(82740400003)(81166007)(356005)(2616005)(1076003)(83380400001)(47076005)(7696005)(336012)(16526019)(36860700001)(26005)(426003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 16:17:26.5707 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 41137fae-046f-40cf-0e1b-08dbc4f5665b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001509.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4952 X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 04 Oct 2023 09:17:42 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778842350414562544 X-GMAIL-MSGID: 1778842350414562544 On older chips, the absolute doorbell offset within the doorbell page is based on the queue ID. KFD is using queue ID and doorbell size to get an absolute doorbell offset in userspace. Here, adding db_size in byte to find the doorbell's absolute offset for both 32-bit and 64-bit doorbell sizes. So that doorbell offset will be aligned based on the doorbell size. v2: - Addressed the review comment from Felix. v3: - Adding doorbell_size as parameter to get db absolute offset. Arvind Yadav (2): drm/amdgpu: Adding db_size to get doorbell absolute offset drm/amdkfd: get doorbell's absolute offset based on the db size drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h | 5 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 13 +++++++++---- .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 6 +++++- drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c | 13 +++++++++++-- .../gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 4 +++- 5 files changed, 31 insertions(+), 10 deletions(-)