mbox series

[v5,0/2] firmware: arm_scmi: clock: support parents commands

Message ID 20231004-scmi-clock-v3-v5-0-1b8a1435673e@nxp.com
Headers
Series firmware: arm_scmi: clock: support parents commands |

Message

Peng Fan (OSS) Oct. 3, 2023, 11:42 p.m. UTC 
  SCMI v3.2 spec adds parents commands, this patchset is to support them:
CLOCK_POSSIBLE_PARENTS_GET
CLOCK_PARENT_SET
CLOCK_PARENT_GET

Besides firmware api clock driver update, the clk_scmi driver also
updated to support set_parent and get_parent ops.

Signed-off-by: Peng Fan <peng.fan@nxp.com>

To: Sudeep Holla <sudeep.holla@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>
To: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-clk@vger.kernel.org

Changes in v5:
- check return value of devm_kcalloc in patch 2 Per Cristian's comment
- Link to v4: https://lore.kernel.org/r/20231003-scmi-clock-v3-v4-0-358d7f916a05@nxp.com

Changes in v4:
 Included Cristian's fix in patch 2 for get parent. Thanks, Cristian.
 Add Cristian's R-b in patch 1
 Rebased on https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/log/?h=for-next/scmi/updates
 - Link to v3: https://lore.kernel.org/all/20231001-scmi-clock-v2-v3-0-898bd92d8939@nxp.com/

Changes in v3:
  Address Cristian's comments:
   - Drop SCMI_MAX_NUM_PARENTS, alloc memory dynamically
   - Check clk_id, parent_id
   - Add comment for parent_get/set
 - Link to v2: https://lore.kernel.org/r/20230925-scmi-clock-v2-v2-0-2d4d7127ebc1@nxp.com

Changes in V2:
 - Add determine_rate hooks

---
Peng Fan (2):
      firmware: arm_scmi: clock: support clock parents
      clk: scmi: add set/get_parent support

 drivers/clk/clk-scmi.c            |  60 ++++++++++++-
 drivers/firmware/arm_scmi/clock.c | 182 ++++++++++++++++++++++++++++++++++++--
 include/linux/scmi_protocol.h     |   6 ++
 3 files changed, 241 insertions(+), 7 deletions(-)
---
base-commit: 8b6022be4c6e3e0d37c3e1378c9ff0a2c8717b09
change-id: 20231003-scmi-clock-v3-ae65eb755d15

Best regards,

Comments

Sudeep Holla Oct. 9, 2023, 11:17 a.m. UTC | #1 
On Wed, 04 Oct 2023 07:42:22 +0800, Peng Fan (OSS) wrote:
> SCMI v3.2 spec adds parents commands, this patchset is to support them:
> CLOCK_POSSIBLE_PARENTS_GET
> CLOCK_PARENT_SET
> CLOCK_PARENT_GET
> 
> Besides firmware api clock driver update, the clk_scmi driver also
> updated to support set_parent and get_parent ops.
> 
> [...]

Hi Stephen,

Since you have acked other changes in the same driver and agreed to take it
via SoC tree, I have applied these changes as well.

Applied(with minor edits to the subject and the commit messages) to
sudeep.holla/linux (for-next/scmi/updates), thanks!

[1/2] firmware: arm_scmi: clock: support clock parents
      https://git.kernel.org/sudeep.holla/c/77bbfe607b1d
[2/2] clk: scmi: add set/get_parent support
      https://git.kernel.org/sudeep.holla/c/65a8a3dd3b95
--
Regards,
Sudeep