mbox series

[v2,0/2] Drop runtime PM support for Baytrail and Lynxpoint pinctrl

Message ID 20231003114036.27674-1-raag.jadav@intel.com
Headers
Series Drop runtime PM support for Baytrail and Lynxpoint pinctrl |

Message

Raag Jadav Oct. 3, 2023, 11:40 a.m. UTC 
  This series removes runtime PM support for the devices that are not
explicitly attached to acpi_lpss_pm_domain as it is dead code anyway.

This has no functional impact and helps reduce their code and memory
footprint.

bloat-o-meter:
==============

Baytrail:
add/remove: 2/4 grow/shrink: 0/3 up/down: 49/-103 (-54)
Total: Before=16104, After=16050, chg -0.34%

Lynxpoint:
add/remove: 7/10 grow/shrink: 1/3 up/down: 152/-223 (-71)
Total: Before=7506, After=7435, chg -0.95%

Changes since v1:
- Add missing pm.h

Raag Jadav (2):
  pinctrl: baytrail: drop runtime PM support
  pinctrl: lynxpoint: drop runtime PM support

 drivers/pinctrl/intel/pinctrl-baytrail.c  | 19 ++------------
 drivers/pinctrl/intel/pinctrl-lynxpoint.c | 32 +++--------------------
 2 files changed, 5 insertions(+), 46 deletions(-)

Comments

Andy Shevchenko Oct. 3, 2023, 12:16 p.m. UTC | #1 
On Tue, Oct 03, 2023 at 05:10:34PM +0530, Raag Jadav wrote:
> This series removes runtime PM support for the devices that are not
> explicitly attached to acpi_lpss_pm_domain as it is dead code anyway.
> 
> This has no functional impact and helps reduce their code and memory
> footprint.
> 
> bloat-o-meter:
> ==============
> 
> Baytrail:
> add/remove: 2/4 grow/shrink: 0/3 up/down: 49/-103 (-54)
> Total: Before=16104, After=16050, chg -0.34%
> 
> Lynxpoint:
> add/remove: 7/10 grow/shrink: 1/3 up/down: 152/-223 (-71)
> Total: Before=7506, After=7435, chg -0.95%
> 
> Changes since v1:
> - Add missing pm.h
> 
> Raag Jadav (2):
>   pinctrl: baytrail: drop runtime PM support
>   pinctrl: lynxpoint: drop runtime PM support
> 
>  drivers/pinctrl/intel/pinctrl-baytrail.c  | 19 ++------------
>  drivers/pinctrl/intel/pinctrl-lynxpoint.c | 32 +++--------------------
>  2 files changed, 5 insertions(+), 46 deletions(-)

You forgot --base... :-(
Andy Shevchenko Oct. 3, 2023, 12:31 p.m. UTC | #2 
On Tue, Oct 03, 2023 at 05:10:34PM +0530, Raag Jadav wrote:
> This series removes runtime PM support for the devices that are not
> explicitly attached to acpi_lpss_pm_domain as it is dead code anyway.
> 
> This has no functional impact and helps reduce their code and memory
> footprint.
> 
> bloat-o-meter:
> ==============
> 
> Baytrail:
> add/remove: 2/4 grow/shrink: 0/3 up/down: 49/-103 (-54)
> Total: Before=16104, After=16050, chg -0.34%
> 
> Lynxpoint:
> add/remove: 7/10 grow/shrink: 1/3 up/down: 152/-223 (-71)
> Total: Before=7506, After=7435, chg -0.95%

Pushed to my review and testing queue, thanks!
Raag Jadav Oct. 3, 2023, 1:31 p.m. UTC | #3 
On Tue, Oct 03, 2023 at 03:16:25PM +0300, Andy Shevchenko wrote:
> On Tue, Oct 03, 2023 at 05:10:34PM +0530, Raag Jadav wrote:
> > This series removes runtime PM support for the devices that are not
> > explicitly attached to acpi_lpss_pm_domain as it is dead code anyway.
> > 
> > This has no functional impact and helps reduce their code and memory
> > footprint.
> > 
> > bloat-o-meter:
> > ==============
> > 
> > Baytrail:
> > add/remove: 2/4 grow/shrink: 0/3 up/down: 49/-103 (-54)
> > Total: Before=16104, After=16050, chg -0.34%
> > 
> > Lynxpoint:
> > add/remove: 7/10 grow/shrink: 1/3 up/down: 152/-223 (-71)
> > Total: Before=7506, After=7435, chg -0.95%
> > 
> > Changes since v1:
> > - Add missing pm.h
> > 
> > Raag Jadav (2):
> >   pinctrl: baytrail: drop runtime PM support
> >   pinctrl: lynxpoint: drop runtime PM support
> > 
> >  drivers/pinctrl/intel/pinctrl-baytrail.c  | 19 ++------------
> >  drivers/pinctrl/intel/pinctrl-lynxpoint.c | 32 +++--------------------
> >  2 files changed, 5 insertions(+), 46 deletions(-)
> 
> You forgot --base... :-(

Sorry, I need to go figure out some send-email automation.

Raag
Andy Shevchenko Oct. 3, 2023, 1:43 p.m. UTC | #4 
On Tue, Oct 03, 2023 at 04:31:12PM +0300, Raag Jadav wrote:
> On Tue, Oct 03, 2023 at 03:16:25PM +0300, Andy Shevchenko wrote:
> > On Tue, Oct 03, 2023 at 05:10:34PM +0530, Raag Jadav wrote:

...

> > You forgot --base... :-(
> 
> Sorry, I need to go figure out some send-email automation.

You can start with my "smart" script [1] (patches are welcome!).

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh