Message ID | 20231003105539.1698436-1-danishanwar@ti.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1997914vqb; Tue, 3 Oct 2023 03:56:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKISdF25lmy6Gr4hXK8WNlM/7FfylGXQHtff5GnEtXRiQau71QSw0lh3LVMIxO23vCthh1 X-Received: by 2002:a05:6871:b1f:b0:1dd:651a:74ac with SMTP id fq31-20020a0568710b1f00b001dd651a74acmr17717730oab.45.1696330588935; Tue, 03 Oct 2023 03:56:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696330588; cv=none; d=google.com; s=arc-20160816; b=w5ahKunJ6yI415dXFK6X5qigwEhUdL30hBXYzVn8NRsskHHStjzzpOXr29a4TBdeBe lszIr+I2jkir3AeiyXh3DXGyo08rRg7eztKa9deWcnJJpEcU95L9PjQfHf7q9J6TcWSb v9MQBdEs91XpF1L6pNSeq/GsVy6bZAPEdVX1WcxGKF10ud61MOg+8ui3CfLdGWzYVucr Aw/kQO95dBqs2nBC9wyyr7hu9Oi+dFDrPlv/hMxEx1GKlrFzeFJjuRn2tNjlWh+DRAUS oVS/x5c1Xs08LNbiHQW00LufAR6jEyKedcXpcH2jCyfVmypLFSKelEXEWEFaxFUja1oO bPug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=qfxFibk2z512fCIHjq/ouom5dRBwGuEZAl2syfqwaSs=; fh=1d9W1ie+sqDX2apz1R1h6xLUOGKBrSQJ1VsJenLtToc=; b=X56n9HgqyGllzT+F/3R9BTQ/txczOTCgU43NTjASvonzIDupyfwT4cds3qXFLM/bmN UX8J7ECsIE3bB7r4fa2+/EQ91+vOsP0OESS25TyHE6FWzFoCJuIe7xEFdIMTU+6TfyeF AXpKk756lYLDWpCcbEoG0aNwMA9Kk+CpqJtLZLJRkWc0BNfrkOS97jiN7VOi09Td488E o1+4FY8I/LeVDGK//9zDj4z7qOrAanrGhQxqnTMg8Hg46LUZS3Ur7PbPMAOs7yqHxK3A 7u81SNrWIvPC8pSdOd04/tSqMgMzLtA0qs4Sv8nOUOaPyQ8Oi5NN07mWWYBRI/JXyD5F hvYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=bmlI58Sf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id v63-20020a638942000000b00578d6a88716si1177540pgd.3.2023.10.03.03.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 03:56:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=bmlI58Sf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 1F934815D7E5; Tue, 3 Oct 2023 03:56:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239737AbjJCK41 (ORCPT <rfc822;pusanteemu@gmail.com> + 18 others); Tue, 3 Oct 2023 06:56:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239718AbjJCK4Y (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 3 Oct 2023 06:56:24 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE677AC; Tue, 3 Oct 2023 03:56:21 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 393Atm8B059039; Tue, 3 Oct 2023 05:55:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1696330548; bh=qfxFibk2z512fCIHjq/ouom5dRBwGuEZAl2syfqwaSs=; h=From:To:CC:Subject:Date; b=bmlI58Sf4zIY+pcO8LhvJhRqCOoMipIzu9Wt2Q6GCo5RAeztRGZ+t1DVQZnKwDcux 6wNAEZbMdTEHba9FfSj5cEmWQNVhCR7Ki2vcdgzTG/KtH+ngRi9slsny76qWbCiV0V EiMh+KBFUHOjD9fXZnzX7s6EiA164tbzfU6I5m9o= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 393Atmjl006116 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Oct 2023 05:55:48 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 3 Oct 2023 05:55:47 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 3 Oct 2023 05:55:47 -0500 Received: from fllv0122.itg.ti.com (fllv0122.itg.ti.com [10.247.120.72]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 393AtluA122962; Tue, 3 Oct 2023 05:55:47 -0500 Received: from localhost (danish-tpc.dhcp.ti.com [10.24.69.199]) by fllv0122.itg.ti.com (8.14.7/8.14.7) with ESMTP id 393Atlsg007878; Tue, 3 Oct 2023 05:55:47 -0500 From: MD Danish Anwar <danishanwar@ti.com> To: Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com> CC: Peng Fan <peng.fan@nxp.com>, Udit Kumar <u-kumar1@ti.com>, =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>, Neil Armstrong <neil.armstrong@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Konrad Dybcio <konrad.dybcio@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Bjorn Andersson <quic_bjorande@quicinc.com>, Will Deacon <will@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Conor Dooley <conor+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, Tero Kristo <kristo@kernel.org>, <linux-omap@vger.kernel.org>, <srk@ti.com>, <r-gunasekaran@ti.com>, MD Danish Anwar <danishanwar@ti.com> Subject: [PATCH v4 0/4] Add AM65x ICSSG Ethernet support Date: Tue, 3 Oct 2023 16:25:35 +0530 Message-ID: <20231003105539.1698436-1-danishanwar@ti.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 03 Oct 2023 03:56:28 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778731543595871071 X-GMAIL-MSGID: 1778731543595871071 |
Series | Add AM65x ICSSG Ethernet support | |
Message
MD Danish Anwar
Oct. 3, 2023, 10:55 a.m. UTC
Hi All, This series adds support for ICSSG ethernet on AM65x SR2.0. This series also enables TI_ICSSG_PRUETH as loadable kernel module. This series is based on the latest next-20230925 linux-next. This is the v4 of the series [v1]. This addresses comments made on v3. Changes from v3 to v4: *) Added RB tag of Andrew Davis. *) Added LAKML to the --cc of this series as it was dropped in v3. Changes from v2 to v3: *) Changed comment of icssg nodes in device trees from "Dual Ethernet application node" to "Ethernet node" as asked by Andrew L. *) Applied k3-am654-idk.dtbo at build time to the k3-am654-base-board.dtb in order to not have orphan DTBO as asked by Andrew D. *) Modified k3-am654-gp-evm.dtb to have k3-am654-icssg2.dtbo as well. Changes from v1 to v2: *) Moved ICSSG2 nodes from k3-am654-base-board.dts to new overlay file k3-am654-icssg2.dtso as asked by Andrew. *) Renamed k3-am654-base-board.dts to k3-am654-common-board.dts *) Added "Enable TI_ICSSG_PRUETH" patch to this series. [v1] https://lore.kernel.org/all/20230911071245.2173520-1-danishanwar@ti.com/ [v2] https://lore.kernel.org/all/20230921060913.721336-1-danishanwar@ti.com/ [v3] https://lore.kernel.org/all/20230926045337.1248276-1-danishanwar@ti.com/ Thanks and Regards, MD Danish Anwar MD Danish Anwar (4): arm64: dts: ti: k3-am65-main: Add ICSSG IEP nodes arm64: dts: ti: k3-am654-base-board: add ICSSG2 Ethernet support arm64: dts: ti: k3-am654-idk: Add ICSSG Ethernet ports arm64: defconfig: Enable TI_ICSSG_PRUETH arch/arm64/boot/dts/ti/Makefile | 4 + arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 36 +++ ...se-board.dts => k3-am654-common-board.dts} | 0 arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 145 +++++++++ arch/arm64/boot/dts/ti/k3-am654-idk.dtso | 296 ++++++++++++++++++ arch/arm64/configs/defconfig | 1 + 6 files changed, 482 insertions(+) rename arch/arm64/boot/dts/ti/{k3-am654-base-board.dts => k3-am654-common-board.dts} (100%) create mode 100644 arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso create mode 100644 arch/arm64/boot/dts/ti/k3-am654-idk.dtso
Comments
On 03/10/23 16:25, MD Danish Anwar wrote: > Hi All, > > This series adds support for ICSSG ethernet on AM65x SR2.0. > This series also enables TI_ICSSG_PRUETH as loadable kernel module. > This series is based on the latest next-20230925 linux-next. > > This is the v4 of the series [v1]. This addresses comments made on v3. > > Changes from v3 to v4: > *) Added RB tag of Andrew Davis. > *) Added LAKML to the --cc of this series as it was dropped in v3. > > Changes from v2 to v3: > *) Changed comment of icssg nodes in device trees from "Dual Ethernet > application node" to "Ethernet node" as asked by Andrew L. > *) Applied k3-am654-idk.dtbo at build time to the k3-am654-base-board.dtb > in order to not have orphan DTBO as asked by Andrew D. > *) Modified k3-am654-gp-evm.dtb to have k3-am654-icssg2.dtbo as well. > > Changes from v1 to v2: > *) Moved ICSSG2 nodes from k3-am654-base-board.dts to new overlay file > k3-am654-icssg2.dtso as asked by Andrew. > *) Renamed k3-am654-base-board.dts to k3-am654-common-board.dts > *) Added "Enable TI_ICSSG_PRUETH" patch to this series. > > [v1] https://lore.kernel.org/all/20230911071245.2173520-1-danishanwar@ti.com/ > [v2] https://lore.kernel.org/all/20230921060913.721336-1-danishanwar@ti.com/ > [v3] https://lore.kernel.org/all/20230926045337.1248276-1-danishanwar@ti.com/ > Wit this series applied I see build failures like: arch/arm64/boot/dts/ti/k3-am65-main.dtsi:897.25-916.4: Warning (unique_unit_address): /bus@100000/pcie@5600000: duplicate unit-address (also used in node /bus@100000/pcie-ep@5600000) DTC arch/arm64/boot/dts/ti/k3-am654-icssg2.dtbo arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso:14.6-85.3: Warning (node_name_chars_strict): /fragment@0/__overlay__: Character '_' not recommended in node name arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso:87.12-125.3: Warning (node_name_chars_strict): /fragment@1/__overlay__: Character '_' not recommended in node name arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso:127.14-145.3: Warning (node_name_chars_strict): /fragment@2/__overlay__: Character '_' not recommended in node name DTOVL arch/arm64/boot/dts/ti/k3-am654-base-board.dtb Overlay 'arch/arm64/boot/dts/ti/k3-am654.dtsi' is incomplete (4096 / 1346656301 bytes read) make[3]: *** [scripts/Makefile.lib:402: arch/arm64/boot/dts/ti/k3-am654-base-board.dtb] Error 1 make[2]: *** [scripts/Makefile.build:480: arch/arm64/boot/dts/ti] Error 2 make[1]: *** [/home/a0132425/workspace/k3-next/Makefile:1391: dtbs] Error 2 make: *** [Makefile:234: __sub-make] Error 2 There probably is some race here as I see this with make -j32 dtbs but not on my less powerful laptop > Thanks and Regards, > MD Danish Anwar > > MD Danish Anwar (4): > arm64: dts: ti: k3-am65-main: Add ICSSG IEP nodes > arm64: dts: ti: k3-am654-base-board: add ICSSG2 Ethernet support > arm64: dts: ti: k3-am654-idk: Add ICSSG Ethernet ports > arm64: defconfig: Enable TI_ICSSG_PRUETH > > arch/arm64/boot/dts/ti/Makefile | 4 + > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 36 +++ > ...se-board.dts => k3-am654-common-board.dts} | 0 > arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 145 +++++++++ > arch/arm64/boot/dts/ti/k3-am654-idk.dtso | 296 ++++++++++++++++++ > arch/arm64/configs/defconfig | 1 + > 6 files changed, 482 insertions(+) > rename arch/arm64/boot/dts/ti/{k3-am654-base-board.dts => k3-am654-common-board.dts} (100%) > create mode 100644 arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso > create mode 100644 arch/arm64/boot/dts/ti/k3-am654-idk.dtso >
Hi Vignesh, On 12/10/23 14:48, Vignesh Raghavendra wrote: > > > On 03/10/23 16:25, MD Danish Anwar wrote: >> Hi All, >> >> This series adds support for ICSSG ethernet on AM65x SR2.0. >> This series also enables TI_ICSSG_PRUETH as loadable kernel module. >> This series is based on the latest next-20230925 linux-next. >> >> This is the v4 of the series [v1]. This addresses comments made on v3. >> >> Changes from v3 to v4: >> *) Added RB tag of Andrew Davis. >> *) Added LAKML to the --cc of this series as it was dropped in v3. >> >> Changes from v2 to v3: >> *) Changed comment of icssg nodes in device trees from "Dual Ethernet >> application node" to "Ethernet node" as asked by Andrew L. >> *) Applied k3-am654-idk.dtbo at build time to the k3-am654-base-board.dtb >> in order to not have orphan DTBO as asked by Andrew D. >> *) Modified k3-am654-gp-evm.dtb to have k3-am654-icssg2.dtbo as well. >> >> Changes from v1 to v2: >> *) Moved ICSSG2 nodes from k3-am654-base-board.dts to new overlay file >> k3-am654-icssg2.dtso as asked by Andrew. >> *) Renamed k3-am654-base-board.dts to k3-am654-common-board.dts >> *) Added "Enable TI_ICSSG_PRUETH" patch to this series. >> >> [v1] https://lore.kernel.org/all/20230911071245.2173520-1-danishanwar@ti.com/ >> [v2] https://lore.kernel.org/all/20230921060913.721336-1-danishanwar@ti.com/ >> [v3] https://lore.kernel.org/all/20230926045337.1248276-1-danishanwar@ti.com/ >> > > Wit this series applied I see build failures like: > > arch/arm64/boot/dts/ti/k3-am65-main.dtsi:897.25-916.4: Warning (unique_unit_address): /bus@100000/pcie@5600000: duplicate unit-address (also used in node /bus@100000/pcie-ep@5600000) > DTC arch/arm64/boot/dts/ti/k3-am654-icssg2.dtbo > arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso:14.6-85.3: Warning (node_name_chars_strict): /fragment@0/__overlay__: Character '_' not recommended in node name > arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso:87.12-125.3: Warning (node_name_chars_strict): /fragment@1/__overlay__: Character '_' not recommended in node name > arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso:127.14-145.3: Warning (node_name_chars_strict): /fragment@2/__overlay__: Character '_' not recommended in node name > DTOVL arch/arm64/boot/dts/ti/k3-am654-base-board.dtb > > Overlay 'arch/arm64/boot/dts/ti/k3-am654.dtsi' is incomplete (4096 / 1346656301 bytes read) > make[3]: *** [scripts/Makefile.lib:402: arch/arm64/boot/dts/ti/k3-am654-base-board.dtb] Error 1 > make[2]: *** [scripts/Makefile.build:480: arch/arm64/boot/dts/ti] Error 2 > make[1]: *** [/home/a0132425/workspace/k3-next/Makefile:1391: dtbs] Error 2 > make: *** [Makefile:234: __sub-make] Error 2 > > There probably is some race here as I see this with make -j32 dtbs > but not on my less powerful laptop > I am running -j20 and I don't see this build failure whien applying the patches and running 'make mroproper' before building. Please try with a clean build. I just did applied this patch on linux-next with a clean build and the patches got applied without any failure / warnings. > > >> Thanks and Regards, >> MD Danish Anwar >> >> MD Danish Anwar (4): >> arm64: dts: ti: k3-am65-main: Add ICSSG IEP nodes >> arm64: dts: ti: k3-am654-base-board: add ICSSG2 Ethernet support >> arm64: dts: ti: k3-am654-idk: Add ICSSG Ethernet ports >> arm64: defconfig: Enable TI_ICSSG_PRUETH >> >> arch/arm64/boot/dts/ti/Makefile | 4 + >> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 36 +++ >> ...se-board.dts => k3-am654-common-board.dts} | 0 >> arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 145 +++++++++ >> arch/arm64/boot/dts/ti/k3-am654-idk.dtso | 296 ++++++++++++++++++ >> arch/arm64/configs/defconfig | 1 + >> 6 files changed, 482 insertions(+) >> rename arch/arm64/boot/dts/ti/{k3-am654-base-board.dts => k3-am654-common-board.dts} (100%) >> create mode 100644 arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso >> create mode 100644 arch/arm64/boot/dts/ti/k3-am654-idk.dtso >> >