Message ID | 20231002094813.6633-1-ilpo.jarvinen@linux.intel.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1312582vqb; Mon, 2 Oct 2023 02:57:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJ+VTG8qAXpiL61DsY5dDkRrcylMasjgEPP6It3jnKoBu7Quvnw6fGDNacoGg5MlNCqxNg X-Received: by 2002:a17:902:e548:b0:1c4:13cd:b85f with SMTP id n8-20020a170902e54800b001c413cdb85fmr10622463plf.5.1696240678551; Mon, 02 Oct 2023 02:57:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696240678; cv=none; d=google.com; s=arc-20160816; b=LAJIq4hHEDDL1QMEhDryU1+xbPTA7slgzHar1j9wOEs9OELpF8sFlNeEjnXPuWSwtJ frGVXohuFlAI1J3lMwjJ1T9/Dw6l3YdBbar5+rA6R8NxBu7BD+XnACp/zSlpJ6RKOGux 1rAGsE/er0PEf4Os5YDWkgqqEoFm9rPFE5if+1bMcIKxlmMJXaooQiem9w/CDoKpGazN gJv4uHSSLhy9KWNMBCS7DFlMe5zju67hxp7bvZp9MT/t1JFZtLhkhdTL/bO48W755FBx LOPhvWS+vLC1Ks6gqbx/PigakQGNR2oNKV3l2YD1wBMjP6vScKC4/qv+P5jMeem9ND1E FU9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=htFAGJ9TrXMR/6/2q1/h4WxAnShxZaDMp5wIYbLnUIE=; fh=0zBAjxShfumhVJgCQ7/PrZqZq2D8mhtAJK1GC38L6Jc=; b=XZT7uT90dDVDdJLThXOazuG54tKFGmYYJ9ULn118jKngdqm5rBcAE975qmPqkF7a1X 4LTbs3xfxwe6ONSSNFj2syBLZWtrJkRS3u0TLUxXOYnEOpFh/nAOQO5agdb/joB7NfnR ABf0lLh4QGr/rJEW9j9ZXSVCHFlG7tLhW5fWRZhg58QG3tffswLZ4UhEKZ+MikJDY684 WWlLgzVMg65b5m/TlCxKOjUYqsKMR4YbzblJNSjckzhKax5akHzE/VPo1utN/DyoQsBd bJKiQfvg80D3igvMf7q0w18z4VqLCDkDIAgecawIdHoCL2EVvNHGPAVyU9xpSBlckx7q b2oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aliqrT7h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id z6-20020a170903018600b001c611f285a6si22119437plg.452.2023.10.02.02.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 02:57:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aliqrT7h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 1D1108040C41; Mon, 2 Oct 2023 02:48:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236234AbjJBJsb (ORCPT <rfc822;pwkd43@gmail.com> + 16 others); Mon, 2 Oct 2023 05:48:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236129AbjJBJs1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 2 Oct 2023 05:48:27 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 383B2A7; Mon, 2 Oct 2023 02:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696240105; x=1727776105; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IZ04flaM+gh3eNQmfe1Szfitj8qEmKU9aHqincz+DA8=; b=aliqrT7hEAkrWoMbcLeZvuqY/WHOimajtWIr2xigj1XvKioxC67PmtDm /RQULfVmX6rtwHo3aXOJXzWQMizKNLQPAkZAQR5XigMvAbuFcvvCoQ3o0 Ds/hr44vB0LA7ScIvfWkxlpKbF2GFa6Vo2YSRqWHPAffgEt+U1d+pxBRq 87yaC29rknLWzuxCfZbgT6sFtryHHdIt3c8n3ZYxRkT1ssUkoopVWEdKp v4GiAlJDQ04PREmP2r9tazVi37SCToJP/bzhjbnjs0mezkE4v0eWowZrC btwREw/dnOMT119L5Mrn/bLsQzdD88kCz4ciMeGRyMgOlkkC35YBJzlIF Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="413523698" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="413523698" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:48:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="874301805" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="874301805" Received: from aanantha-mobl.gar.corp.intel.com (HELO localhost) ([10.251.221.191]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:48:21 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> To: linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>, Reinette Chatre <reinette.chatre@intel.com>, =?utf-8?q?Maciej_Wiecz=C3=B3r-?= =?utf-8?q?Retman?= <maciej.wieczor-retman@intel.com>, Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?q?Ilpo_J?= =?utf-8?q?=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> Subject: [PATCH v4 0/7] selftests/resctrl: Fixes to failing tests Date: Mon, 2 Oct 2023 12:48:06 +0300 Message-Id: <20231002094813.6633-1-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 02 Oct 2023 02:48:42 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778637266121929986 X-GMAIL-MSGID: 1778637266121929986 |
Series |
selftests/resctrl: Fixes to failing tests
|
|
Message
Ilpo Järvinen
Oct. 2, 2023, 9:48 a.m. UTC
Fix four issues with resctrl selftests. The signal handling fix became necessary after the mount/umount fixes and the uninitialized member bug was discovered during the review. The other two came up when I ran resctrl selftests across the server fleet in our lab to validate the upcoming CAT test rewrite (the rewrite is not part of this series). These are developed and should apply cleanly at least on top the benchmark cleanup series (might apply cleanly also w/o the benchmark series, I didn't test). v4: - Use func(void) for functions taking no arguments - Correct Fixes tag formatting v3: - Add fix to uninitialized sa_flags - Handle ksft_exit_fail_msg() in per test functions - Make signal handler register fails to also exit - Improve changelogs v2: - Include patch to move _GNU_SOURCE to Makefile to allow normal #include placement - Rework the signal register/unregister into patch to use helpers - Fixed incorrect function parameter description - Use return !!res to avoid confusing implicit boolean conversion - Improve MBA/MBM success bound patch's changelog - Tweak Cc: stable dependencies (make it a chain). Ilpo Järvinen (7): selftests/resctrl: Fix uninitialized .sa_flags selftests/resctrl: Extend signal handler coverage to unmount on receiving signal selftests/resctrl: Remove duplicate feature check from CMT test selftests/resctrl: Move _GNU_SOURCE define into Makefile selftests/resctrl: Refactor feature check to use resource and feature name selftests/resctrl: Fix feature checks selftests/resctrl: Reduce failures due to outliers in MBA/MBM tests tools/testing/selftests/resctrl/Makefile | 2 +- tools/testing/selftests/resctrl/cat_test.c | 8 -- tools/testing/selftests/resctrl/cmt_test.c | 3 - tools/testing/selftests/resctrl/mba_test.c | 2 +- tools/testing/selftests/resctrl/mbm_test.c | 2 +- tools/testing/selftests/resctrl/resctrl.h | 7 +- .../testing/selftests/resctrl/resctrl_tests.c | 82 ++++++++++++------- tools/testing/selftests/resctrl/resctrl_val.c | 26 +++--- tools/testing/selftests/resctrl/resctrlfs.c | 69 ++++++---------- 9 files changed, 97 insertions(+), 104 deletions(-)
Comments
On Mon, 2 Oct 2023, Ilpo Järvinen wrote: > Fix four issues with resctrl selftests. > > The signal handling fix became necessary after the mount/umount fixes > and the uninitialized member bug was discovered during the review. > > The other two came up when I ran resctrl selftests across the server > fleet in our lab to validate the upcoming CAT test rewrite (the rewrite > is not part of this series). > > These are developed and should apply cleanly at least on top the > benchmark cleanup series (might apply cleanly also w/o the benchmark > series, I didn't test). LKP seems to no longer happy to apply this cleanly without the benchmark rework series as the signal handling fix got now a bigger footprint (maybe LKP didn't build v3 at all as the changes from v3->v4 were really small and I did not get error out of v3). Shuah, would you want me to reorganize this such that it goes in before the benchmark series? In any case, I'll wait until Reinette has had time to look at the first patch if I'm to send the series reordered.
On 10/2/2023 4:31 AM, Ilpo Järvinen wrote: > On Mon, 2 Oct 2023, Ilpo Järvinen wrote: > >> Fix four issues with resctrl selftests. >> >> The signal handling fix became necessary after the mount/umount fixes >> and the uninitialized member bug was discovered during the review. >> >> The other two came up when I ran resctrl selftests across the server >> fleet in our lab to validate the upcoming CAT test rewrite (the rewrite >> is not part of this series). >> >> These are developed and should apply cleanly at least on top the >> benchmark cleanup series (might apply cleanly also w/o the benchmark >> series, I didn't test). > > LKP seems to no longer happy to apply this cleanly without the benchmark > rework series as the signal handling fix got now a bigger footprint > (maybe LKP didn't build v3 at all as the changes from v3->v4 were really > small and I did not get error out of v3). > > Shuah, would you want me to reorganize this such that it goes in before > the benchmark series? In any case, I'll wait until Reinette has had time > to look at the first patch if I'm to send the series reordered. That sounds unnecessary to me because I assume that doing such reorganization would require a new version of the benchmark series [1] that has been ready for a while now. Both series look good to me. I just added my "Reviewed-by" to the first patch of this series and it (this series) applies cleanly on top of the benchmark series. Reinette [1] https://lore.kernel.org/lkml/20230904095339.11321-1-ilpo.jarvinen@linux.intel.com/
Hi Ilpo, I ran the test set on Intel(R) Xeon(R) Gold 6254 CPU. There is no problem. Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> Best regards, Shaopeng TAN