Message ID | 20230929112039.7488-1-ilpo.jarvinen@linux.intel.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp4121574vqu; Fri, 29 Sep 2023 08:34:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLzMn9WkESFQF94ytQdpF1FganCM7XVXWcLeE1+uwE70WX6IvmdbdwemIhC6liMkTBAiCe X-Received: by 2002:a17:903:32cb:b0:1c4:3ae6:381a with SMTP id i11-20020a17090332cb00b001c43ae6381amr5943295plr.0.1696001647655; Fri, 29 Sep 2023 08:34:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696001647; cv=none; d=google.com; s=arc-20160816; b=oFQ0e54P509y4FZRZcnaF09O4vcNM9/oeah0xpD/cZoAZJ/hWkQqmu37AeAe8+v3e6 73z+4gZmOodPoprHDM65z2ahh4vIrQ3aVqF0SzlRzrHvoNxa7FBypQkw3TeKYAXHWxJ8 pglcRhVWWQcaNIhMm/yuG43lYOos3YERuQvS9CqjnV1HTyjAZcjdO+SDsq6zF6HyxuXI WSVEbInBiZp6Q+htbrMQkosGKmjeaLsMoaxyJGTMuGZPwkMzYn40oJY/d33zgYxmKlwh 5gtx6x7VXk9O/PVVCD9Ix/5lxgkeGNrHwcD9kD2vvUTQmV76XGhR/Zn0RD5M6LAnw0wh Xo5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=g8H/wOhq3VulyLRLQIBDqWqbF2a97QozWPpdJlKV3+E=; fh=0zBAjxShfumhVJgCQ7/PrZqZq2D8mhtAJK1GC38L6Jc=; b=hsORh+8bDY2IXUIIPpdnIrsye1kr+w9EF7Fq/ITVRxdp05pZBHKgadcDQXpNvMaSKy Fxa6FadY1+w7MLZ5oqvH/fESZNbSEZuT6ZVLRcgDn+PDwCT6pUKXIWiyyOvTiqL8Kiu8 Q4fzhvYjASAc14iYUKwh/ndI3EECXCSj48lBG0Kcif6Hg3+5Vh8ESOEbXLooAfYvfww4 aPpkM6it34n3DYcbolG/2C7xkYdLuJ97YQKrnwO0OJq+phFj9ncZOUi2NHrP1jb5PVRd g4njnpq1GfS+2ZXVhR8oNjxNX7IGcgM4vNcmuiFyqMRnchsNcknsKV1ww6azqzye6bIp kotg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=n31Kxup6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id ik22-20020a170902ab1600b001b7d2b55d8asi14203348plb.626.2023.09.29.08.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 08:34:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=n31Kxup6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 68E6F80B6323; Fri, 29 Sep 2023 04:21:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232912AbjI2LUz (ORCPT <rfc822;pwkd43@gmail.com> + 20 others); Fri, 29 Sep 2023 07:20:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229754AbjI2LUx (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 29 Sep 2023 07:20:53 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD663B7; Fri, 29 Sep 2023 04:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695986451; x=1727522451; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=QXUMqBfSGsGhYFch5ouPdVeZ7w7T5gbJgbet+vA/gDU=; b=n31Kxup6vMg5NHYtgtwyeE1Dm2or0VT2yGk9eKQHm0eHJCl+yqaGQX3v 4oKupdjMRlM/crKrN6s6DFpPpVn8F0khqDQdjMaLKq4Z0JdO4jrwTCRTz 8EEugg49OyJPqohgxIm/pl4GDHKla9++m3RjVhYGstJGxOPjkQW72GbiE f0fjLdMP+0sYdQSrTvOdhj89cRSk5ZSvxjqhCY7U3deONGrfToSw1vtyZ 6hUfmtc6NZzEMbdstXSjSqCC8WgP9kPsBi5MutaADDP8s2LYp+n/Jroib OuF85gAwrPnh70M3NEywFSoGU/xSFGB08kkcWRqWDxVCFtXTf8H4xmeMB Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10847"; a="468558396" X-IronPort-AV: E=Sophos;i="6.03,187,1694761200"; d="scan'208";a="468558396" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2023 04:20:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10847"; a="923571025" X-IronPort-AV: E=Sophos;i="6.03,187,1694761200"; d="scan'208";a="923571025" Received: from valeks2x-mobl.ger.corp.intel.com (HELO localhost) ([10.252.53.242]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2023 04:20:47 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> To: linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>, Reinette Chatre <reinette.chatre@intel.com>, =?utf-8?q?Maciej_Wiecz=C3=B3r-?= =?utf-8?q?Retman?= <maciej.wieczor-retman@intel.com>, Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?q?Ilpo_J?= =?utf-8?q?=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> Subject: [PATCH v3 0/7] selftests/resctrl: Fixes to failing tests Date: Fri, 29 Sep 2023 14:20:32 +0300 Message-Id: <20230929112039.7488-1-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 29 Sep 2023 04:21:00 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778386624099496785 X-GMAIL-MSGID: 1778386624099496785 |
Series |
selftests/resctrl: Fixes to failing tests
|
|
Message
Ilpo Järvinen
Sept. 29, 2023, 11:20 a.m. UTC
Fix four issues with resctrl selftests. The signal handling fix became necessary after the mount/umount fixes and the uninitialized member bug was discovered during the review. The other two came up when I ran resctrl selftests across the server fleet in our lab to validate the upcoming CAT test rewrite (the rewrite is not part of this series). These are developed and should apply cleanly at least on top the benchmark cleanup series (might apply cleanly also w/o the benchmark series, I didn't test). v3: - Add fix to uninitialized sa_flags - Handle ksft_exit_fail_msg() in per test functions - Make signal handler register fails to also exit - Improve changelogs v2: - Include patch to move _GNU_SOURCE to Makefile to allow normal #include placement - Rework the signal register/unregister into patch to use helpers - Fixed incorrect function parameter description - Use return !!res to avoid confusing implicit boolean conversion - Improve MBA/MBM success bound patch's changelog - Tweak Cc: stable dependencies (make it a chain). Ilpo Järvinen (7): selftests/resctrl: Fix uninitialized .sa_flags selftests/resctrl: Extend signal handler coverage to unmount on receiving signal selftests/resctrl: Remove duplicate feature check from CMT test selftests/resctrl: Move _GNU_SOURCE define into Makefile selftests/resctrl: Refactor feature check to use resource and feature name selftests/resctrl: Fix feature checks selftests/resctrl: Reduce failures due to outliers in MBA/MBM tests tools/testing/selftests/resctrl/Makefile | 2 +- tools/testing/selftests/resctrl/cat_test.c | 8 -- tools/testing/selftests/resctrl/cmt_test.c | 3 - tools/testing/selftests/resctrl/mba_test.c | 2 +- tools/testing/selftests/resctrl/mbm_test.c | 2 +- tools/testing/selftests/resctrl/resctrl.h | 7 +- .../testing/selftests/resctrl/resctrl_tests.c | 82 ++++++++++++------- tools/testing/selftests/resctrl/resctrl_val.c | 24 +++--- tools/testing/selftests/resctrl/resctrlfs.c | 69 ++++++---------- 9 files changed, 96 insertions(+), 103 deletions(-)