mbox series

[net-next,v2,0/9] i40e: House-keeping and clean-up

Message ID 20230927083135.3237206-1-ivecera@redhat.com
Headers
Series i40e: House-keeping and clean-up |

Message

Ivan Vecera Sept. 27, 2023, 8:31 a.m. UTC 
  The series makes some house-keeping tasks on i40e driver:

Patch 1: Removes unnecessary back pointer from i40e_hw
Patch 2: Moves I40E_MASK macro to i40e_register.h where is used
Patch 3: Refactors I40E_MDIO_CLAUSE* to use the common macro
Patch 4: Add header dependencies to <linux/avf/virtchnl.h>
Patch 5: Simplifies memory alloction functions
Patch 6: Moves mem alloc structures to i40e_alloc.h
Patch 7: Splits i40e_osdep.h to i40e_debug.h and i40e_io.h
Patch 8: Removes circular header deps, fixes and cleans headers
Patch 9: Moves DDP specific macros and structs to i40e_ddp.c

Changes:
v2 - Fixed kdoc comment for i40e_hw_to_pf()
   - Reordered patches 5 and 7-9 to make them simplier

 drivers/net/ethernet/intel/i40e/i40e.h        | 76 +++++--------------
 drivers/net/ethernet/intel/i40e/i40e_adminq.c |  8 +-
 drivers/net/ethernet/intel/i40e/i40e_adminq.h |  3 +-
 .../net/ethernet/intel/i40e/i40e_adminq_cmd.h |  2 +
 drivers/net/ethernet/intel/i40e/i40e_alloc.h  | 24 +++---
 drivers/net/ethernet/intel/i40e/i40e_client.c |  1 -
 drivers/net/ethernet/intel/i40e/i40e_common.c | 11 ++-
 drivers/net/ethernet/intel/i40e/i40e_dcb.c    |  4 +-
 drivers/net/ethernet/intel/i40e/i40e_dcb_nl.c |  2 +-
 drivers/net/ethernet/intel/i40e/i40e_ddp.c    | 24 +++++-
 drivers/net/ethernet/intel/i40e/i40e_debug.h  | 47 ++++++++++++
 .../net/ethernet/intel/i40e/i40e_debugfs.c    |  3 +-
 drivers/net/ethernet/intel/i40e/i40e_diag.h   |  5 +-
 .../net/ethernet/intel/i40e/i40e_ethtool.c    |  3 +-
 drivers/net/ethernet/intel/i40e/i40e_hmc.c    | 16 ++--
 drivers/net/ethernet/intel/i40e/i40e_hmc.h    |  4 +
 drivers/net/ethernet/intel/i40e/i40e_io.h     | 16 ++++
 .../net/ethernet/intel/i40e/i40e_lan_hmc.c    |  9 +--
 .../net/ethernet/intel/i40e/i40e_lan_hmc.h    |  2 +
 drivers/net/ethernet/intel/i40e/i40e_main.c   | 57 ++++++++------
 drivers/net/ethernet/intel/i40e/i40e_nvm.c    |  2 +
 drivers/net/ethernet/intel/i40e/i40e_osdep.h  | 59 --------------
 .../net/ethernet/intel/i40e/i40e_prototype.h  |  9 ++-
 drivers/net/ethernet/intel/i40e/i40e_ptp.c    |  3 +-
 .../net/ethernet/intel/i40e/i40e_register.h   |  5 ++
 drivers/net/ethernet/intel/i40e/i40e_txrx.c   |  7 +-
 drivers/net/ethernet/intel/i40e/i40e_txrx.h   |  1 +
 .../ethernet/intel/i40e/i40e_txrx_common.h    |  2 +
 drivers/net/ethernet/intel/i40e/i40e_type.h   | 59 +++-----------
 .../ethernet/intel/i40e/i40e_virtchnl_pf.c    |  2 +
 .../ethernet/intel/i40e/i40e_virtchnl_pf.h    |  4 +-
 drivers/net/ethernet/intel/i40e/i40e_xsk.c    |  4 -
 drivers/net/ethernet/intel/i40e/i40e_xsk.h    |  4 +
 include/linux/avf/virtchnl.h                  |  4 +
 34 files changed, 231 insertions(+), 251 deletions(-)
 create mode 100644 drivers/net/ethernet/intel/i40e/i40e_debug.h
 create mode 100644 drivers/net/ethernet/intel/i40e/i40e_io.h
 delete mode 100644 drivers/net/ethernet/intel/i40e/i40e_osdep.h

Comments

Przemek Kitszel Sept. 27, 2023, 8:53 a.m. UTC | #1 
On 9/27/23 10:31, Ivan Vecera wrote:
> The series makes some house-keeping tasks on i40e driver:
> 
> Patch 1: Removes unnecessary back pointer from i40e_hw
> Patch 2: Moves I40E_MASK macro to i40e_register.h where is used
> Patch 3: Refactors I40E_MDIO_CLAUSE* to use the common macro
> Patch 4: Add header dependencies to <linux/avf/virtchnl.h>
> Patch 5: Simplifies memory alloction functions
> Patch 6: Moves mem alloc structures to i40e_alloc.h
> Patch 7: Splits i40e_osdep.h to i40e_debug.h and i40e_io.h
> Patch 8: Removes circular header deps, fixes and cleans headers
> Patch 9: Moves DDP specific macros and structs to i40e_ddp.c
> 
> Changes:
> v2 - Fixed kdoc comment for i40e_hw_to_pf()
>     - Reordered patches 5 and 7-9 to make them simplier
> 
>   drivers/net/ethernet/intel/i40e/i40e.h        | 76 +++++--------------
>   drivers/net/ethernet/intel/i40e/i40e_adminq.c |  8 +-
>   drivers/net/ethernet/intel/i40e/i40e_adminq.h |  3 +-
>   .../net/ethernet/intel/i40e/i40e_adminq_cmd.h |  2 +
>   drivers/net/ethernet/intel/i40e/i40e_alloc.h  | 24 +++---
>   drivers/net/ethernet/intel/i40e/i40e_client.c |  1 -
>   drivers/net/ethernet/intel/i40e/i40e_common.c | 11 ++-
>   drivers/net/ethernet/intel/i40e/i40e_dcb.c    |  4 +-
>   drivers/net/ethernet/intel/i40e/i40e_dcb_nl.c |  2 +-
>   drivers/net/ethernet/intel/i40e/i40e_ddp.c    | 24 +++++-
>   drivers/net/ethernet/intel/i40e/i40e_debug.h  | 47 ++++++++++++
>   .../net/ethernet/intel/i40e/i40e_debugfs.c    |  3 +-
>   drivers/net/ethernet/intel/i40e/i40e_diag.h   |  5 +-
>   .../net/ethernet/intel/i40e/i40e_ethtool.c    |  3 +-
>   drivers/net/ethernet/intel/i40e/i40e_hmc.c    | 16 ++--
>   drivers/net/ethernet/intel/i40e/i40e_hmc.h    |  4 +
>   drivers/net/ethernet/intel/i40e/i40e_io.h     | 16 ++++
>   .../net/ethernet/intel/i40e/i40e_lan_hmc.c    |  9 +--
>   .../net/ethernet/intel/i40e/i40e_lan_hmc.h    |  2 +
>   drivers/net/ethernet/intel/i40e/i40e_main.c   | 57 ++++++++------
>   drivers/net/ethernet/intel/i40e/i40e_nvm.c    |  2 +
>   drivers/net/ethernet/intel/i40e/i40e_osdep.h  | 59 --------------
>   .../net/ethernet/intel/i40e/i40e_prototype.h  |  9 ++-
>   drivers/net/ethernet/intel/i40e/i40e_ptp.c    |  3 +-
>   .../net/ethernet/intel/i40e/i40e_register.h   |  5 ++
>   drivers/net/ethernet/intel/i40e/i40e_txrx.c   |  7 +-
>   drivers/net/ethernet/intel/i40e/i40e_txrx.h   |  1 +
>   .../ethernet/intel/i40e/i40e_txrx_common.h    |  2 +
>   drivers/net/ethernet/intel/i40e/i40e_type.h   | 59 +++-----------
>   .../ethernet/intel/i40e/i40e_virtchnl_pf.c    |  2 +
>   .../ethernet/intel/i40e/i40e_virtchnl_pf.h    |  4 +-
>   drivers/net/ethernet/intel/i40e/i40e_xsk.c    |  4 -
>   drivers/net/ethernet/intel/i40e/i40e_xsk.h    |  4 +
>   include/linux/avf/virtchnl.h                  |  4 +
>   34 files changed, 231 insertions(+), 251 deletions(-)
>   create mode 100644 drivers/net/ethernet/intel/i40e/i40e_debug.h
>   create mode 100644 drivers/net/ethernet/intel/i40e/i40e_io.h
>   delete mode 100644 drivers/net/ethernet/intel/i40e/i40e_osdep.h
> 

Thank you!
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Jesse Brandeburg Sept. 28, 2023, 10:12 p.m. UTC | #2 
On 9/27/2023 1:31 AM, Ivan Vecera wrote:
> The series makes some house-keeping tasks on i40e driver:
> 
> Patch 1: Removes unnecessary back pointer from i40e_hw
> Patch 2: Moves I40E_MASK macro to i40e_register.h where is used
> Patch 3: Refactors I40E_MDIO_CLAUSE* to use the common macro
> Patch 4: Add header dependencies to <linux/avf/virtchnl.h>
> Patch 5: Simplifies memory alloction functions
> Patch 6: Moves mem alloc structures to i40e_alloc.h
> Patch 7: Splits i40e_osdep.h to i40e_debug.h and i40e_io.h
> Patch 8: Removes circular header deps, fixes and cleans headers
> Patch 9: Moves DDP specific macros and structs to i40e_ddp.c
> 
> Changes:
> v2 - Fixed kdoc comment for i40e_hw_to_pf()
>     - Reordered patches 5 and 7-9 to make them simplier

spelling: simpler

Thanks for this cleanup series, the changes all seem sane.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Jakub Kicinski Oct. 4, 2023, 7:17 p.m. UTC | #3 
On Thu, 28 Sep 2023 15:12:09 -0700 Jesse Brandeburg wrote:
> On 9/27/2023 1:31 AM, Ivan Vecera wrote:
> > The series makes some house-keeping tasks on i40e driver:
> > 
> > Patch 1: Removes unnecessary back pointer from i40e_hw
> > Patch 2: Moves I40E_MASK macro to i40e_register.h where is used
> > Patch 3: Refactors I40E_MDIO_CLAUSE* to use the common macro
> > Patch 4: Add header dependencies to <linux/avf/virtchnl.h>
> > Patch 5: Simplifies memory alloction functions
> > Patch 6: Moves mem alloc structures to i40e_alloc.h
> > Patch 7: Splits i40e_osdep.h to i40e_debug.h and i40e_io.h
> > Patch 8: Removes circular header deps, fixes and cleans headers
> > Patch 9: Moves DDP specific macros and structs to i40e_ddp.c
> > 
> > Changes:
> > v2 - Fixed kdoc comment for i40e_hw_to_pf()
> >     - Reordered patches 5 and 7-9 to make them simplier  
> 
> spelling: simpler
> 
> Thanks for this cleanup series, the changes all seem sane.
> 
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

I'm marking as "awaiting upstream" but feel free to ask for these
to be applied directly to net-next if you prefer.