mbox series

[00/27] platform: Convert to platform remove callback returning void

Message ID 20230927081040.2198742-1-u.kleine-koenig@pengutronix.de
Headers
Series platform: Convert to platform remove callback returning void |

Message

Uwe Kleine-König Sept. 27, 2023, 8:10 a.m. UTC 
  Hello,

this series converts all platform drivers below drivers/platform to use
.remove_new(). The motivation is to get rid of an integer return code
that is (mostly) ignored by the platform driver core and error prone on
the driver side.

See commit 5c5a7680e67b ("platform: Provide a remove callback that
returns no value") for an extended explanation and the eventual goal.

As there is no single maintainer team for drivers/platform, I suggest
the individual maintainers to pick up "their" patches. The only
inter-dependency in this series is that the patches #24 - #27 depend on
#23. Otherwise there are no inter-dependencies, so that should work
fine. As there are still quite a few drivers to convert in other areas
than drivers/platform, I'm happy about every patch that makes it in and
there is no need for further coordination. So even if there is a merge
conflict with one patch until you apply or a subject prefix is
suboptimal, please don't let you stop by negative feedback for other
patches (unless it applies to "your" patches, too, of course).

Best regards and thanks for considering,
Uwe

Uwe Kleine-König (27):
  platform/chrome: cros_ec_chardev: Convert to platform remove callback
    returning void
  platform/chrome: cros_ec_debugfs: Convert to platform remove callback
    returning void
  platform/chrome: cros_ec_lightbar: Convert to platform remove callback
    returning void
  platform/chrome: cros_ec_lpc: Convert to platform remove callback
    returning void
  platform/chrome: cros_ec_sysfs: Convert to platform remove callback
    returning void
  platform/chrome: cros_ec_vbc: Convert to platform remove callback
    returning void
  platform/chrome: cros_typec_switch: Convert to platform remove
    callback returning void
  platform/chrome: cros_usbpd_logger: Convert to platform remove
    callback returning void
  platform/chrome: cros_usbpd_notify: Convert to platform remove
    callback returning void
  platform/chrome/wilco_ec: core: Convert to platform remove callback
    returning void
  platform/chrome/wilco_ec: debugfs: Convert to platform remove callback
    returning void
  platform/chrome/wilco_ec: telemetry: Convert to platform remove
    callback returning void
  platform/goldfish: goldfish_pipe: Convert to platform remove callback
    returning void
  platform/mellanox: mlxbf-bootctl: Convert to platform remove callback
    returning void
  platform/mellanox: mlxbf-tmfifo: Convert to platform remove callback
    returning void
  platform/mellanox: mlxreg-hotplug: Convert to platform remove callback
    returning void
  platform/mellanox: mlxreg-io: Convert to platform remove callback
    returning void
  platform/mellanox: mlxreg-lc: Convert to platform remove callback
    returning void
  platform/mellanox: nvsw-sn2201: Convert to platform remove callback
    returning void
  platform/x86/intel: bytcrc_pwrsrc: Convert to platform remove callback
    returning void
  platform/x86: mlx-platform: Convert to platform remove callback
    returning void
  platform/x86: sel3350-platform: Convert to platform remove callback
    returning void
  platform/x86/siemens: simatic-ipc-batt: Simplify
    simatic_ipc_batt_remove()
  platform/x86/siemens: simatic-ipc-batt: Convert to platform remove
    callback returning void
  platform/x86/siemens: simatic-ipc-batt-apollolake: Convert to platform
    remove callback returning void
  platform/x86/siemens: simatic-ipc-batt-elkhartlake: Convert to
    platform remove callback returning void
  platform/x86/siemens: simatic-ipc-batt-f7188x: Convert to platform
    remove callback returning void

 drivers/platform/chrome/cros_ec_chardev.c            |  6 ++----
 drivers/platform/chrome/cros_ec_debugfs.c            |  6 ++----
 drivers/platform/chrome/cros_ec_lightbar.c           |  6 ++----
 drivers/platform/chrome/cros_ec_lpc.c                |  6 ++----
 drivers/platform/chrome/cros_ec_sysfs.c              |  6 ++----
 drivers/platform/chrome/cros_ec_vbc.c                |  6 ++----
 drivers/platform/chrome/cros_typec_switch.c          |  5 ++---
 drivers/platform/chrome/cros_usbpd_logger.c          |  6 ++----
 drivers/platform/chrome/cros_usbpd_notify.c          | 12 ++++--------
 drivers/platform/chrome/wilco_ec/core.c              |  5 ++---
 drivers/platform/chrome/wilco_ec/debugfs.c           |  6 ++----
 drivers/platform/chrome/wilco_ec/telemetry.c         |  6 ++----
 drivers/platform/goldfish/goldfish_pipe.c            |  5 ++---
 drivers/platform/mellanox/mlxbf-bootctl.c            |  6 ++----
 drivers/platform/mellanox/mlxbf-tmfifo.c             |  6 ++----
 drivers/platform/mellanox/mlxreg-hotplug.c           |  6 ++----
 drivers/platform/mellanox/mlxreg-io.c                |  6 ++----
 drivers/platform/mellanox/mlxreg-lc.c                |  8 +++-----
 drivers/platform/mellanox/nvsw-sn2201.c              |  6 ++----
 drivers/platform/x86/intel/bytcrc_pwrsrc.c           |  5 ++---
 drivers/platform/x86/mlx-platform.c                  |  5 ++---
 drivers/platform/x86/sel3350-platform.c              |  6 ++----
 .../x86/siemens/simatic-ipc-batt-apollolake.c        |  6 +++---
 .../x86/siemens/simatic-ipc-batt-elkhartlake.c       |  6 +++---
 .../platform/x86/siemens/simatic-ipc-batt-f7188x.c   |  6 +++---
 drivers/platform/x86/siemens/simatic-ipc-batt.c      |  9 ++++-----
 drivers/platform/x86/siemens/simatic-ipc-batt.h      |  4 ++--
 27 files changed, 62 insertions(+), 104 deletions(-)

base-commit: 18030226a48de1fbfabf4ae16aaa2695a484254f

Comments

patchwork-bot+chrome-platform@kernel.org Sept. 28, 2023, 5:30 a.m. UTC | #1 
Hello:

This series was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Wed, 27 Sep 2023 10:10:13 +0200 you wrote:
> Hello,
> 
> this series converts all platform drivers below drivers/platform to use
> .remove_new(). The motivation is to get rid of an integer return code
> that is (mostly) ignored by the platform driver core and error prone on
> the driver side.
> 
> [...]

Here is the summary with links:
  - [01/27] platform/chrome: cros_ec_chardev: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/f04410e7be65
  - [02/27] platform/chrome: cros_ec_debugfs: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/f366fa0064ef
  - [03/27] platform/chrome: cros_ec_lightbar: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/fa45583c3133
  - [04/27] platform/chrome: cros_ec_lpc: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/e02944e85169
  - [05/27] platform/chrome: cros_ec_sysfs: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/6478e302409a
  - [06/27] platform/chrome: cros_ec_vbc: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/58b15196b0ef
  - [07/27] platform/chrome: cros_typec_switch: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/ea4bad2badb7
  - [08/27] platform/chrome: cros_usbpd_logger: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/b6c1fea83550
  - [09/27] platform/chrome: cros_usbpd_notify: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/b98362be7c92
  - [10/27] platform/chrome/wilco_ec: core: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/48648504e488
  - [11/27] platform/chrome/wilco_ec: debugfs: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/1fca58f347d8
  - [12/27] platform/chrome/wilco_ec: telemetry: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/7396a5b980fd

You are awesome, thank you!
Ilpo Järvinen Sept. 28, 2023, 11:03 a.m. UTC | #2 
On Wed, 27 Sep 2023, Uwe Kleine-König wrote:

> Hello,
> 
> this series converts all platform drivers below drivers/platform to use
> .remove_new(). The motivation is to get rid of an integer return code
> that is (mostly) ignored by the platform driver core and error prone on
> the driver side.
> 
> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
> 
> As there is no single maintainer team for drivers/platform, I suggest
> the individual maintainers to pick up "their" patches. The only
> inter-dependency in this series is that the patches #24 - #27 depend on
> #23. Otherwise there are no inter-dependencies, so that should work
> fine. As there are still quite a few drivers to convert in other areas
> than drivers/platform, I'm happy about every patch that makes it in and
> there is no need for further coordination. So even if there is a merge
> conflict with one patch until you apply or a subject prefix is
> suboptimal, please don't let you stop by negative feedback for other
> patches (unless it applies to "your" patches, too, of course).
> 
> Best regards and thanks for considering,
> Uwe
> 
> Uwe Kleine-König (27):
>   platform/chrome: cros_ec_chardev: Convert to platform remove callback
>     returning void
>   platform/chrome: cros_ec_debugfs: Convert to platform remove callback
>     returning void
>   platform/chrome: cros_ec_lightbar: Convert to platform remove callback
>     returning void
>   platform/chrome: cros_ec_lpc: Convert to platform remove callback
>     returning void
>   platform/chrome: cros_ec_sysfs: Convert to platform remove callback
>     returning void
>   platform/chrome: cros_ec_vbc: Convert to platform remove callback
>     returning void
>   platform/chrome: cros_typec_switch: Convert to platform remove
>     callback returning void
>   platform/chrome: cros_usbpd_logger: Convert to platform remove
>     callback returning void
>   platform/chrome: cros_usbpd_notify: Convert to platform remove
>     callback returning void
>   platform/chrome/wilco_ec: core: Convert to platform remove callback
>     returning void
>   platform/chrome/wilco_ec: debugfs: Convert to platform remove callback
>     returning void
>   platform/chrome/wilco_ec: telemetry: Convert to platform remove
>     callback returning void
>   platform/goldfish: goldfish_pipe: Convert to platform remove callback
>     returning void
>   platform/mellanox: mlxbf-bootctl: Convert to platform remove callback
>     returning void
>   platform/mellanox: mlxbf-tmfifo: Convert to platform remove callback
>     returning void
>   platform/mellanox: mlxreg-hotplug: Convert to platform remove callback
>     returning void
>   platform/mellanox: mlxreg-io: Convert to platform remove callback
>     returning void
>   platform/mellanox: mlxreg-lc: Convert to platform remove callback
>     returning void
>   platform/mellanox: nvsw-sn2201: Convert to platform remove callback
>     returning void
>   platform/x86/intel: bytcrc_pwrsrc: Convert to platform remove callback
>     returning void
>   platform/x86: mlx-platform: Convert to platform remove callback
>     returning void
>   platform/x86: sel3350-platform: Convert to platform remove callback
>     returning void
>   platform/x86/siemens: simatic-ipc-batt: Simplify
>     simatic_ipc_batt_remove()
>   platform/x86/siemens: simatic-ipc-batt: Convert to platform remove
>     callback returning void
>   platform/x86/siemens: simatic-ipc-batt-apollolake: Convert to platform
>     remove callback returning void
>   platform/x86/siemens: simatic-ipc-batt-elkhartlake: Convert to
>     platform remove callback returning void
>   platform/x86/siemens: simatic-ipc-batt-f7188x: Convert to platform
>     remove callback returning void

Thanks for the patches.

I don't know if you got the auto generated thank you email as it seemed to 
hit a character encoding problem while sending the email out.

But in any case, I've applied patches 14-27 to my local review-ilpo branch 
(they will eventually appear on the public repo too and propagate to 
for-next).
patchwork-bot+chrome-platform@kernel.org Oct. 2, 2023, 3 a.m. UTC | #3 
Hello:

This series was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Wed, 27 Sep 2023 10:10:13 +0200 you wrote:
> Hello,
> 
> this series converts all platform drivers below drivers/platform to use
> .remove_new(). The motivation is to get rid of an integer return code
> that is (mostly) ignored by the platform driver core and error prone on
> the driver side.
> 
> [...]

Here is the summary with links:
  - [01/27] platform/chrome: cros_ec_chardev: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/f04410e7be65
  - [02/27] platform/chrome: cros_ec_debugfs: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/f366fa0064ef
  - [03/27] platform/chrome: cros_ec_lightbar: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/fa45583c3133
  - [04/27] platform/chrome: cros_ec_lpc: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/e02944e85169
  - [05/27] platform/chrome: cros_ec_sysfs: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/6478e302409a
  - [06/27] platform/chrome: cros_ec_vbc: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/58b15196b0ef
  - [07/27] platform/chrome: cros_typec_switch: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/ea4bad2badb7
  - [08/27] platform/chrome: cros_usbpd_logger: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/b6c1fea83550
  - [09/27] platform/chrome: cros_usbpd_notify: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/b98362be7c92
  - [10/27] platform/chrome/wilco_ec: core: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/48648504e488
  - [11/27] platform/chrome/wilco_ec: debugfs: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/1fca58f347d8
  - [12/27] platform/chrome/wilco_ec: telemetry: Convert to platform remove callback returning void
    https://git.kernel.org/chrome-platform/c/7396a5b980fd

You are awesome, thank you!