Message ID | 20230927033634.make.602-kees@kernel.org |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2409700vqu; Tue, 26 Sep 2023 22:57:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFSIudQbIscrv4lQqFbk8vaVBehffsPu7e2DpdM9p3yQHf23hVAyRTI7YFcU9EEQvpZBXGQ X-Received: by 2002:a05:6870:a118:b0:1dd:7fa9:ed52 with SMTP id m24-20020a056870a11800b001dd7fa9ed52mr1602306oae.17.1695794236432; Tue, 26 Sep 2023 22:57:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695794236; cv=none; d=google.com; s=arc-20160816; b=aNO6433Nd8KegMEdtfv/Jwm0WW3mMsdDsn68ULVKYFJhdEpesYnDNBfNZeBOl/NQ+1 JgFtysTbwPcaDkflgRuhyhjl00MUyxG/LiXFzKkLMxMpkDRMfiPTS9JcCQg/9CvXYK4r +vUIhHP4AKF5bso/aeGvpi+4pt84kQwsd7O83lqythciQTPp8ZxWsoNOoxX7kkmWgNPG cg1sPdxjODKLZ9UDSb88uguje46I4eLomimublEuSY2MWrAKbroVBdyi3FSefDNrTQMw 8BYdi8WDbm7HgJM1xwp1Oms8O/LOV5ts7HFuEO6obGxepDA5dALrq70P4lMntkT5czzf sZUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=PGJfI+lZ4iSfQ93mihAmCKetWCxWqPDzFkg6Q6FWgBc=; fh=P4Uo5mCdy/9CDzRumP301c4uGkyxyxnnPfF9guP4zY0=; b=hDwoHZSxD/2sjX9JjX1fArSkZtDS/JDHNG6oft20cyDyk3aaru5PPbe87ZEKRW1h0D YGhbZdDSO5q/gsA2CdLtxVXh5flGlvZlqihnNmLcD2C+D9pOC+4u2xLsBRbX49xPM/KM BsRaqgiSw3NThlyL/33PsKc2of+k9xDnjTejE3/tnGdu5MsQfCH6l54kTjxJ4iS2OJS1 cjCP/LupYWv2ru997WCLOxLc2u1Pyvqc4PQ3jZ3KrywoPKOpskOcpyNBia9wVudv6X5K gWX5D7S4EgcnBaleWe27YYPEwtiVgEekAIbPgDG08Q09RKVMGdH96uirT7xsnL7xnCy6 8GlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Bs7xjUEu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id f20-20020a637554000000b005776040b2a6si15019979pgn.187.2023.09.26.22.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 22:57:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Bs7xjUEu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 23824809A7A5; Tue, 26 Sep 2023 21:20:54 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbjI0EUj (ORCPT <rfc822;pwkd43@gmail.com> + 26 others); Wed, 27 Sep 2023 00:20:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbjI0ETa (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 27 Sep 2023 00:19:30 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 841A91BDA for <linux-kernel@vger.kernel.org>; Tue, 26 Sep 2023 20:42:27 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1c46b30a1ceso91357555ad.3 for <linux-kernel@vger.kernel.org>; Tue, 26 Sep 2023 20:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695786147; x=1696390947; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PGJfI+lZ4iSfQ93mihAmCKetWCxWqPDzFkg6Q6FWgBc=; b=Bs7xjUEuS8NkFPZHJGDJ2TEI8MNHM5Tz6S/mOzXHCqJoYeG8s73+rqFxehM6W9d0Kt wgxsaFDT4RoUKAw+CU0VmHrZgfzI1vpBz7Y07O6WES0bdXkIyYu2DrOxTBJ5JixFquGM J/7Qe5i1yvKNnVZ0c/UHwkPScoP7L+UScfV04= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695786147; x=1696390947; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PGJfI+lZ4iSfQ93mihAmCKetWCxWqPDzFkg6Q6FWgBc=; b=AwsgNzkci2jCzScoIX5A6WRlEli6j56FGy/HA/ge/hl0W6xvWi533sMDSLGL+yHqzK 0DWEJF/FL3dLn3oHc5D2v1o3L7MJQlGBJ8BoFSPCsiUsODq7wHhXDH5vj83jcCmZCtS/ WRJLz61b+nZ8HljgRKY/rNyoR+Xn/2IUDsvPlhH1bukJzlwLhdX02ZqwiyfH+BdwGngP pndE/8xcuL0MeHIt2c6k8dHIEi/Zw5JEeX3ZTS0J0xAbRGenTFxLtx2G1XYJwL1yZKf2 6jh2Rbxsiy270Igk7zawI+TxUFtIpkkbijRaVuEHv9lo5t3ZE+7sBQKBHsXRTmOSl5zI 9+Yw== X-Gm-Message-State: AOJu0YybTGo5VqP7NnKgAsPh7cSZl+hArZQlSjN8DGkWWTBkj97QvUDg SW0MVmgcxA9oQEEjRQKEA1h1ug== X-Received: by 2002:a17:902:c94f:b0:1bb:598a:14e5 with SMTP id i15-20020a170902c94f00b001bb598a14e5mr992121pla.43.1695786146709; Tue, 26 Sep 2023 20:42:26 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id jj11-20020a170903048b00b001bdc6ca748esm11918838plb.185.2023.09.26.20.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 20:42:24 -0700 (PDT) From: Kees Cook <keescook@chromium.org> To: Eric Biederman <ebiederm@xmission.com> Cc: Kees Cook <keescook@chromium.org>, Sebastian Ott <sebott@redhat.com>, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>, Al Viro <viro@zeniv.linux.org.uk>, Christian Brauner <brauner@kernel.org>, Pedro Falcato <pedro.falcato@gmail.com>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: [PATCH v3 0/4] binfmt_elf: Support segments with 0 filesz and misaligned starts Date: Tue, 26 Sep 2023 20:42:17 -0700 Message-Id: <20230927033634.make.602-kees@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=868; i=keescook@chromium.org; h=from:subject:message-id; bh=lOC6dIm6BOZ5YdJlYfTe2LeekCnJ++QGcs0vKnnP4ps=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBlE6ScQrYRvW7/cLoTymNp+QzCK4E5+g2pQV1h7 2TULnPSJZmJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCZROknAAKCRCJcvTf3G3A JoDCEACiqN/qgoJ0Ne6hePry6JkdekxC2ghpkyg+pmI99pumwTcgld+j67+ZMdlJ1uoiL+ZLTZW kpZQc19iF4kz/hS2BzF5fc3o9zbbnksf5M41zq8EHUWlTko2ebswjaLUUI/dADhqmcfsFOxdlYK a9Wn4Yo+Jsryxk8lZr8iC1UsqxoN2OD1JZ/IScy8PRDGyoj5SW/8KXm4YVbT+dUCx5rv/HJ+qzk n6mLTE09gnExRim0Wkug8xsfhXdnRLf3JEwhHm1uYDvLhIVG4jp9a/C/HyB52YRBBD0pM7HD93r eDzoVjwiGJLGETpwCEoKdJaiNrkBYYwZ4uS/OTgkBkxm/y/MykXwxzIH2FQRU6ex9YHjbc68Re4 abj6Ut8m5K8OBP497GvZJeM6fR4y1bL3UtMBqHGNipTauOPZtp14wuE26++n4jCcIdnbdo9FmYz GXg3/jNe4JkK4sHhwUXSCm07Gn3QavzFisWXca4G/AqBjF5k4hwBnYd8jg6ObkJgzPZgIHuZ+CN AiMdCAMOGj2d0N/Jlti27JIkfB5ifjxiV+OXygf99lkJgwVe18U6L6cPvdtxbYOW3xWLKUwxgqL mpHIt8n/rKLRvretb5VXJySNBh2q2kAngczfkZzyHdbxaj6wAKLbZiiVdt+WDa7CcxMhvKi9oot B6BlPROL CGrPl5w== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 26 Sep 2023 21:20:55 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778167120323499637 X-GMAIL-MSGID: 1778169137053493306 |
Series |
binfmt_elf: Support segments with 0 filesz and misaligned starts
|
|
Message
Kees Cook
Sept. 27, 2023, 3:42 a.m. UTC
Hi, This is the continuation of the work Eric started for handling "p_memsz > p_filesz" in arbitrary segments (rather than just the last, BSS, segment). I've added the suggested changes: - drop unused "elf_bss" variable - report padzero() errors when PROT_WRITE is present - refactor load_elf_interp() to use elf_load() This passes my quick smoke tests, but I'm still trying to construct some more complete tests... -Kees Eric W. Biederman (1): binfmt_elf: Support segments with 0 filesz and misaligned starts Kees Cook (3): binfmt_elf: elf_bss no longer used by load_elf_binary() binfmt_elf: Provide prot bits as context for padzero() errors binfmt_elf: Use elf_load() for interpreter fs/binfmt_elf.c | 192 ++++++++++++++++++------------------------------ 1 file changed, 71 insertions(+), 121 deletions(-)
Comments
Kees Cook <keescook@chromium.org> writes: > Hi, > > This is the continuation of the work Eric started for handling > "p_memsz > p_filesz" in arbitrary segments (rather than just the last, > BSS, segment). I've added the suggested changes: > > - drop unused "elf_bss" variable > - report padzero() errors when PROT_WRITE is present > - refactor load_elf_interp() to use elf_load() > > This passes my quick smoke tests, but I'm still trying to construct some > more complete tests... Acked-by: "Eric W. Biederman" <ebiederm@xmission.com> You might also consider using elf_load in load_elf_library. The code in load_elf_library only supports files with a single program header, and I think is only needed for libc5. The advantage is that load_elf_library would be using well tested code, vm_brk would have no callers, and padzero would only be called by elf_load, and load_elf_library would do little more than just call load_elf_library. Eric > > -Kees > > Eric W. Biederman (1): > binfmt_elf: Support segments with 0 filesz and misaligned starts > > Kees Cook (3): > binfmt_elf: elf_bss no longer used by load_elf_binary() > binfmt_elf: Provide prot bits as context for padzero() errors > binfmt_elf: Use elf_load() for interpreter > > fs/binfmt_elf.c | 192 ++++++++++++++++++------------------------------ > 1 file changed, 71 insertions(+), 121 deletions(-)
On Tue, 26 Sep 2023, Kees Cook wrote: > This is the continuation of the work Eric started for handling > "p_memsz > p_filesz" in arbitrary segments (rather than just the last, > BSS, segment). I've added the suggested changes: > > - drop unused "elf_bss" variable > - report padzero() errors when PROT_WRITE is present > - refactor load_elf_interp() to use elf_load() > > This passes my quick smoke tests, but I'm still trying to construct some > more complete tests... I've repeated all my tests with this one - no issues found. Thanks, Sebastian